Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTreeIndex Charge Groups #1224

Merged
merged 16 commits into from
Jan 25, 2024
Merged

BTreeIndex Charge Groups #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4fb2477
test groups
kunga Jan 22, 2024
45b03cf
remove strange default no history
kunga Jan 22, 2024
8674b8b
DoPrechargeGroup
kunga Jan 22, 2024
518ae4a
+ handleDataPage
kunga Jan 22, 2024
0ec3a42
bugfix assert
kunga Jan 23, 2024
50a21d7
almost working version
kunga Jan 23, 2024
0fdc9c4
almost working version with fixes
kunga Jan 23, 2024
6e22cb9
fix when key before slice
kunga Jan 24, 2024
be2c73f
little rename
kunga Jan 24, 2024
ff2696d
row2 -> endRowId
kunga Jan 24, 2024
88605f3
apply changes onto DoPrechargeGroup
kunga Jan 24, 2024
30faf2e
reverse without slices
kunga Jan 25, 2024
d1c89e9
clean up
kunga Jan 25, 2024
00d301f
clean up
kunga Jan 25, 2024
4aaee8c
Merge branch 'main' into KIKIMR-19522-btree-precharge-groups
kunga Jan 25, 2024
e935dfa
cr fixes
kunga Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ydb/core/tablet_flat/flat_part_charge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace NTable {
using TDataPage = NPage::TDataPage;
using TGroupId = NPage::TGroupId;

TCharge(IPages *env, const TPart &part, TTagsRef tags, bool includeHistory = false)
TCharge(IPages *env, const TPart &part, TTagsRef tags, bool includeHistory)
: Env(env)
, Part(&part)
, Scheme(*Part->Scheme)
Expand Down Expand Up @@ -326,7 +326,11 @@ namespace NTable {
if (key1Page && key1Page == current) {
if (needExactBounds && page) {
auto key1RowId = LookupRowIdReverse(key1, page, Scheme.Groups[0], ESeek::Lower, keyDefaults);
prechargeCurrentFirstRowId = Min(prechargeCurrentFirstRowId, key1RowId);
if (key1RowId != Max<TRowId>()) { // Max<TRowId>() means that lower bound is before current page, so doesn't charge current page
prechargeCurrentFirstRowId = Min(prechargeCurrentFirstRowId, key1RowId);
} else {
prechargeCurrentLastRowId = Max<TRowId>(); // no precharge
}
} else {
prechargeCurrentLastRowId = Max<TRowId>(); // no precharge
}
Expand Down
Loading
Loading