Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WriteActor #12167

Merged
merged 18 commits into from
Dec 3, 2024
Merged

Improve WriteActor #12167

merged 18 commits into from
Dec 3, 2024

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Dec 1, 2024

Changelog entry

Improve WriteActor:

  • move serialization to fwd actor
  • remove table resolve
  • fixed segfault

Changelog category

  • Improvement
  • Bugfix

Additional information

...

@nikvas0 nikvas0 force-pushed the move-serialization branch from 00b36ca to e8c8b8e Compare December 2, 2024 07:27
Copy link

github-actions bot commented Dec 2, 2024

2024-12-02 07:30:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98ffaf5 has started.
2024-12-02 07:30:53 UTC Artifacts will be uploaded here
2024-12-02 07:34:08 UTC ya make is running...
🔴 2024-12-02 07:42:53 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 2, 2024

2024-12-02 07:30:48 UTC Pre-commit check linux-x86_64-release-asan for 98ffaf5 has started.
2024-12-02 07:30:59 UTC Artifacts will be uploaded here
2024-12-02 07:34:15 UTC ya make is running...
🔴 2024-12-02 07:53:42 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 2, 2024

2024-12-02 08:39:03 UTC Pre-commit check linux-x86_64-release-asan for c324bcc has started.
2024-12-02 08:39:15 UTC Artifacts will be uploaded here
2024-12-02 08:42:41 UTC ya make is running...
🟡 2024-12-02 10:04:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15199 15085 0 61 9 44

🟢 2024-12-02 10:06:00 UTC Build successful.
🟢 2024-12-02 10:06:30 UTC ydbd size 4.9 GiB changed* by -21.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9bef86a merge: c324bcc diff diff %
ydbd size 5 290 521 624 Bytes 5 290 499 536 Bytes -21.6 KiB -0.000%
ydbd stripped size 1 364 839 376 Bytes 1 364 837 296 Bytes -2.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 2, 2024

2024-12-02 11:02:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for c324bcc has started.
2024-12-02 11:02:21 UTC Artifacts will be uploaded here
2024-12-02 11:05:44 UTC ya make is running...
2024-12-02 12:21:13 UTC Check cancelled

Copy link

github-actions bot commented Dec 2, 2024

2024-12-02 12:24:07 UTC Pre-commit check linux-x86_64-release-asan for 992de91 has started.
2024-12-02 12:24:18 UTC Artifacts will be uploaded here
2024-12-02 12:27:31 UTC ya make is running...
🟡 2024-12-02 13:43:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15202 15120 0 21 10 51

🟢 2024-12-02 13:44:51 UTC Build successful.
🟢 2024-12-02 13:45:21 UTC ydbd size 4.9 GiB changed* by -432 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d029c27 merge: 992de91 diff diff %
ydbd size 5 291 894 792 Bytes 5 291 894 360 Bytes -432 Bytes -0.000%
ydbd stripped size 1 365 080 336 Bytes 1 365 085 616 Bytes +5.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 2, 2024

2024-12-02 12:24:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 992de91 has started.
2024-12-02 12:24:39 UTC Artifacts will be uploaded here
2024-12-02 12:27:54 UTC ya make is running...
🟡 2024-12-02 13:35:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32651 29796 0 2 2729 124

2024-12-02 13:37:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-02 13:51:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
812 (only retried tests) 704 0 0 0 108

🟢 2024-12-02 13:51:57 UTC Build successful.
🟢 2024-12-02 13:52:17 UTC ydbd size 2.5 GiB changed* by +9.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d029c27 merge: 992de91 diff diff %
ydbd size 2 692 171 576 Bytes 2 692 181 208 Bytes +9.4 KiB +0.000%
ydbd stripped size 483 439 056 Bytes 483 446 096 Bytes +6.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) December 2, 2024 14:20
@nikvas0 nikvas0 requested a review from gridnevvvit December 2, 2024 14:40
@nikvas0 nikvas0 merged commit 9a920b4 into ydb-platform:main Dec 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants