Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy Compaction Read code #12078

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented Nov 28, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Is needed for getting rid of extra Private Cache usages

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 08:50:23 UTC Pre-commit check linux-x86_64-release-asan for 6855f58 has started.
2024-11-28 08:51:00 UTC Artifacts will be uploaded here
2024-11-28 08:54:25 UTC ya make is running...
🟡 2024-11-28 09:56:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13541 13476 0 10 6 49

🟢 2024-11-28 09:57:42 UTC Build successful.
🟢 2024-11-28 09:58:10 UTC ydbd size 4.9 GiB changed* by -161.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bf6d055 merge: 6855f58 diff diff %
ydbd size 5 294 621 088 Bytes 5 294 455 736 Bytes -161.5 KiB -0.003%
ydbd stripped size 1 361 097 392 Bytes 1 361 052 848 Bytes -43.5 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 08:51:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6855f58 has started.
2024-11-28 08:51:59 UTC Artifacts will be uploaded here
2024-11-28 08:55:00 UTC ya make is running...
🟡 2024-11-28 09:48:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21232 19709 0 2 1397 124

2024-11-28 09:50:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-28 10:02:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
857 (only retried tests) 747 0 0 0 110

🟢 2024-11-28 10:03:05 UTC Build successful.
🟢 2024-11-28 10:03:25 UTC ydbd size 2.5 GiB changed* by -85.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bf6d055 merge: 6855f58 diff diff %
ydbd size 2 694 916 240 Bytes 2 694 828 288 Bytes -85.9 KiB -0.003%
ydbd stripped size 482 180 240 Bytes 482 157 904 Bytes -21.8 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga marked this pull request as ready for review November 28, 2024 10:52
@kunga kunga requested a review from snaury November 28, 2024 10:53
@kunga kunga merged commit 121d6ae into ydb-platform:main Nov 28, 2024
13 checks passed
@kunga kunga mentioned this pull request Nov 28, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants