Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dqrun with enabled row dispatcher #12068

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Nov 27, 2024

VERIFY:
AppData(): requirement x && x->Magic == TAppData::MagicTag

Changelog entry

...

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam yumkam changed the title Fixes AppData(): requirement x && x->Magic == TAppData::MagicTag Fixes dqrun with enabled row dispatcher Nov 27, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 16:12:59 UTC Pre-commit check linux-x86_64-release-asan for a9eb4b3 has started.
2024-11-27 16:13:11 UTC Artifacts will be uploaded here
2024-11-27 16:16:09 UTC ya make is running...
🟡 2024-11-27 17:21:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12927 12857 0 18 7 45

🟢 2024-11-27 17:22:53 UTC Build successful.
🟢 2024-11-27 17:23:23 UTC ydbd size 4.9 GiB changed* by +8 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f54668a merge: a9eb4b3 diff diff %
ydbd size 5 293 726 840 Bytes 5 293 726 848 Bytes +8 Bytes +0.000%
ydbd stripped size 1 360 903 600 Bytes 1 360 903 568 Bytes -32 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 16:13:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9eb4b3 has started.
2024-11-27 16:14:01 UTC Artifacts will be uploaded here
2024-11-27 16:16:55 UTC ya make is running...
🟢 2024-11-27 17:10:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30062 27228 0 0 2719 115

🟢 2024-11-27 17:13:01 UTC Build successful.
🟢 2024-11-27 17:13:18 UTC ydbd size 2.5 GiB changed* by -176 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f54668a merge: a9eb4b3 diff diff %
ydbd size 2 694 438 592 Bytes 2 694 438 416 Bytes -176 Bytes -0.000%
ydbd stripped size 482 133 104 Bytes 482 132 976 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review November 27, 2024 16:27
@yumkam yumkam requested a review from a team as a code owner November 27, 2024 16:27
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 18:18:50 UTC Pre-commit check linux-x86_64-release-asan for dfc2202 has started.
2024-11-27 18:19:24 UTC Artifacts will be uploaded here
2024-11-27 18:22:49 UTC ya make is running...
🟡 2024-11-27 19:26:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12930 12860 0 15 8 47

🟢 2024-11-27 19:27:49 UTC Build successful.
🟢 2024-11-27 19:28:15 UTC ydbd size 4.9 GiB changed* by -320 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e6457a7 merge: dfc2202 diff diff %
ydbd size 5 294 702 112 Bytes 5 294 701 792 Bytes -320 Bytes -0.000%
ydbd stripped size 1 361 108 272 Bytes 1 361 108 208 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 18:20:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for dfc2202 has started.
2024-11-27 18:20:42 UTC Artifacts will be uploaded here
2024-11-27 18:23:44 UTC ya make is running...
🟡 2024-11-27 19:19:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30065 27227 0 1 2720 117

2024-11-27 19:22:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-27 19:43:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
775 (only retried tests) 666 0 0 0 109

🟢 2024-11-27 19:43:50 UTC Build successful.
🟢 2024-11-27 19:44:09 UTC ydbd size 2.5 GiB changed* by -416 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e6457a7 merge: dfc2202 diff diff %
ydbd size 2 694 952 248 Bytes 2 694 951 832 Bytes -416 Bytes -0.000%
ydbd stripped size 482 189 008 Bytes 482 188 880 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit 3891cbb into ydb-platform:main Nov 28, 2024
10 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants