Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify for wrong StartOffset and EndOffset. Fix copy of blob. #12049

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Add verify for wrong StartOffset and EndOffset. Fix copy of blob. #12049

merged 4 commits into from
Nov 28, 2024

Conversation

nshestakov
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@nshestakov nshestakov requested a review from a team as a code owner November 27, 2024 12:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 12:25:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for ecffc62 has started.
⚪ 2024-11-27 12:25:38 UTC Artifacts will be uploaded here
⚪ 2024-11-27 12:28:46 UTC ya make is running...
⚫ 2024-11-27 13:00:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 12:25:59 UTC Pre-commit check linux-x86_64-release-asan for ecffc62 has started.
⚪ 2024-11-27 12:26:30 UTC Artifacts will be uploaded here
⚪ 2024-11-27 12:29:54 UTC ya make is running...
⚫ 2024-11-27 13:00:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 13:02:12 UTC Pre-commit check linux-x86_64-release-asan for c8f51d5 has started.
⚪ 2024-11-27 13:02:23 UTC Artifacts will be uploaded here
⚪ 2024-11-27 13:05:17 UTC ya make is running...
🟡 2024-11-27 14:31:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14883 14808 0 23 6 46

🟢 2024-11-27 14:32:39 UTC Build successful.
🟢 2024-11-27 14:33:09 UTC ydbd size 4.9 GiB changed* by -13.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e89b8d6 merge: c8f51d5 diff diff %
ydbd size 5 293 665 816 Bytes 5 293 651 616 Bytes -13.9 KiB -0.000%
ydbd stripped size 1 360 902 544 Bytes 1 360 902 480 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 13:02:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for c8f51d5 has started.
⚪ 2024-11-27 13:03:18 UTC Artifacts will be uploaded here
⚪ 2024-11-27 13:06:36 UTC ya make is running...
🟡 2024-11-27 14:18:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22574 21060 0 1 1396 117

⚪ 2024-11-27 14:20:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-27 14:32:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
751 (only retried tests) 641 0 1 0 109

⚪ 2024-11-27 14:32:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-27 14:45:37 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
684 (only retried tests) 574 0 1 0 109

🟢 2024-11-27 14:45:47 UTC Build successful.
🟢 2024-11-27 14:46:12 UTC ydbd size 2.5 GiB changed* by -3.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e89b8d6 merge: c8f51d5 diff diff %
ydbd size 2 694 386 536 Bytes 2 694 382 592 Bytes -3.9 KiB -0.000%
ydbd stripped size 482 132 592 Bytes 482 132 720 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexnick88
alexnick88 previously approved these changes Nov 27, 2024
View reviewed changes
@nshestakov nshestakov enabled auto-merge (squash) November 27, 2024 13:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 16:39:19 UTC Pre-commit check linux-x86_64-release-asan for 703649b has started.
⚪ 2024-11-27 16:39:30 UTC Artifacts will be uploaded here
⚪ 2024-11-27 16:42:27 UTC ya make is running...
🟡 2024-11-27 17:51:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14886 14804 0 19 12 51

🟢 2024-11-27 17:53:08 UTC Build successful.
🟢 2024-11-27 17:53:35 UTC ydbd size 4.9 GiB changed* by -13.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c381728 merge: 703649b diff diff %
ydbd size 5 294 418 648 Bytes 5 294 404 840 Bytes -13.5 KiB -0.000%
ydbd stripped size 1 361 080 464 Bytes 1 361 080 528 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 16:39:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 703649b has started.
⚪ 2024-11-27 16:39:34 UTC Artifacts will be uploaded here
⚪ 2024-11-27 16:42:30 UTC ya make is running...
🟡 2024-11-27 17:42:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22577 21057 0 6 1396 118

⚪ 2024-11-27 17:44:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-27 17:56:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
756 (only retried tests) 647 0 2 1 106

⚪ 2024-11-27 17:56:27 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-27 18:08:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
635 (only retried tests) 529 0 0 0 106

🟢 2024-11-27 18:08:14 UTC Build successful.
🟢 2024-11-27 18:08:35 UTC ydbd size 2.5 GiB changed* by -3.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c381728 merge: 703649b diff diff %
ydbd size 2 694 781 912 Bytes 2 694 777 976 Bytes -3.8 KiB -0.000%
ydbd stripped size 482 174 288 Bytes 482 174 416 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov merged commit 38350c0 into ydb-platform:main Nov 28, 2024
10 checks passed
@nshestakov nshestakov deleted the AP-fromTime-test-2 branch November 28, 2024 06:49
nshestakov added a commit to nshestakov/ydb that referenced this pull request Nov 29, 2024
@nshestakov
partial of PR ydb-platform#12049
d352144
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
@naspirato naspirato mentioned this pull request Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

@FloatingCrowbar FloatingCrowbar Awaiting requested review from FloatingCrowbar FloatingCrowbar is a code owner automatically assigned from ydb-platform/topics

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nshestakov @alexnick88