-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blob writing error processing for portion-write-mode #12029
blob writing error processing for portion-write-mode #12029
Conversation
ivanmorozov333
commented
Nov 26, 2024
- Improvement
- Bugfix
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
@@ -127,7 +127,7 @@ void TWriteOperation::FromProto(const NKikimrTxColumnShard::TInternalOperationDa | |||
} | |||
|
|||
void TWriteOperation::AbortOnExecute(TColumnShard& owner, NTabletFlatExecutor::TTransactionContext& txc) const { | |||
Y_ABORT_UNLESS(Status == EOperationStatus::Prepared); | |||
Y_ABORT_UNLESS(Status != EOperationStatus::Draft); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Как по мне, прямое условие было бы более читаемым: Y_ABORT_IF(Status == Draft)