Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob writing error processing for portion-write-mode #12029

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement
  • Bugfix

Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 18:01:52 UTC Pre-commit check linux-x86_64-release-asan for fc9b423 has started.
2024-11-26 18:02:31 UTC Artifacts will be uploaded here
2024-11-26 18:06:12 UTC ya make is running...
🟡 2024-11-26 19:36:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10521 10452 0 15 8 46

🟢 2024-11-26 19:37:38 UTC Build successful.
🟢 2024-11-26 19:38:05 UTC ydbd size 4.9 GiB changed* by +56.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0a9693f merge: fc9b423 diff diff %
ydbd size 5 293 855 752 Bytes 5 293 913 320 Bytes +56.2 KiB +0.001%
ydbd stripped size 1 361 407 056 Bytes 1 361 416 784 Bytes +9.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 26, 2024

2024-11-26 18:02:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc9b423 has started.
2024-11-26 18:03:03 UTC Artifacts will be uploaded here
2024-11-26 18:06:16 UTC ya make is running...
🟡 2024-11-26 19:32:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26319 23488 0 1 2718 112

2024-11-26 19:34:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-26 19:46:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 5 0 0 1 107

🟢 2024-11-26 19:46:17 UTC Build successful.
🟢 2024-11-26 19:46:36 UTC ydbd size 2.5 GiB changed* by +28.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0a9693f merge: fc9b423 diff diff %
ydbd size 2 694 619 000 Bytes 2 694 647 952 Bytes +28.3 KiB +0.001%
ydbd stripped size 482 600 784 Bytes 482 604 304 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -127,7 +127,7 @@ void TWriteOperation::FromProto(const NKikimrTxColumnShard::TInternalOperationDa
}

void TWriteOperation::AbortOnExecute(TColumnShard& owner, NTabletFlatExecutor::TTransactionContext& txc) const {
Y_ABORT_UNLESS(Status == EOperationStatus::Prepared);
Y_ABORT_UNLESS(Status != EOperationStatus::Draft);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Как по мне, прямое условие было бы более читаемым: Y_ABORT_IF(Status == Draft)

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 27, 2024 06:58
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 27, 2024 06:58
@ivanmorozov333 ivanmorozov333 merged commit e92e224 into ydb-platform:main Nov 27, 2024
11 checks passed
@ivanmorozov333 ivanmorozov333 deleted the process_fails_on_write branch November 27, 2024 06:59
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants