Remove share body logic #11987

kunga · 2024-11-26T08:44:37Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

As a final step of removing Private Cache Share Body logic, remove itself

github-actions · 2024-11-26T08:45:21Z

⚪ 2024-11-26 08:45:20 UTC Pre-commit check linux-x86_64-release-asan for 13fbc05 has started.
⚪ 2024-11-26 08:46:06 UTC Artifacts will be uploaded here
⚪ 2024-11-26 08:49:43 UTC ya make is running...
⚫ 2024-11-26 08:57:48 UTC Check cancelled

github-actions · 2024-11-26T08:48:12Z

⚪ 2024-11-26 08:48:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13fbc05 has started.
⚪ 2024-11-26 08:48:15 UTC Artifacts will be uploaded here
⚪ 2024-11-26 08:51:42 UTC ya make is running...
⚫ 2024-11-26 08:57:49 UTC Check cancelled

github-actions · 2024-11-26T08:59:46Z

⚪ 2024-11-26 08:59:46 UTC Pre-commit check linux-x86_64-release-asan for 69a0c17 has started.
⚪ 2024-11-26 08:59:58 UTC Artifacts will be uploaded here
⚪ 2024-11-26 09:03:25 UTC ya make is running...
🟡 2024-11-26 10:40:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10508	10424	0	22	10	52

🟢 2024-11-26 10:41:35 UTC Build successful.
🟢 2024-11-26 10:42:07 UTC ydbd size 4.9 GiB changed* by -118.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `8999d1e`	merge: `69a0c17`	diff	diff %
ydbd size	5 285 635 624 Bytes	5 285 514 584 Bytes	-118.2 KiB	-0.002%
ydbd stripped size	1 360 314 896 Bytes	1 360 289 360 Bytes	-24.9 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-26T09:00:53Z

⚪ 2024-11-26 09:00:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 69a0c17 has started.
⚪ 2024-11-26 09:01:04 UTC Artifacts will be uploaded here
⚪ 2024-11-26 09:04:18 UTC ya make is running...
🟡 2024-11-26 10:28:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
26268	23379	0	7	2763	119

⚪ 2024-11-26 10:30:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-26 10:42:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
167 (only retried tests)	54	0	4	1	108

⚪ 2024-11-26 10:42:50 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-26 10:54:27 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
112 (only retried tests)	2	0	4	0	106

🟢 2024-11-26 10:54:34 UTC Build successful.
🟢 2024-11-26 10:54:57 UTC ydbd size 2.5 GiB changed* by -47.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `8999d1e`	merge: `69a0c17`	diff	diff %
ydbd size	2 690 586 840 Bytes	2 690 537 952 Bytes	-47.7 KiB	-0.002%
ydbd stripped size	482 259 632 Bytes	482 249 264 Bytes	-10.1 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-26T12:08:12Z

⚪ 2024-11-26 12:08:12 UTC Pre-commit check linux-x86_64-release-asan for 7ffdf5b has started.
⚪ 2024-11-26 12:08:37 UTC Artifacts will be uploaded here
⚪ 2024-11-26 12:12:04 UTC ya make is running...
🟡 2024-11-26 13:51:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10510	10432	0	21	7	50

🟢 2024-11-26 13:52:19 UTC Build successful.
🟢 2024-11-26 13:52:51 UTC ydbd size 4.9 GiB changed* by -118.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `2a7eb6b`	merge: `7ffdf5b`	diff	diff %
ydbd size	5 293 729 296 Bytes	5 293 608 256 Bytes	-118.2 KiB	-0.002%
ydbd stripped size	1 361 387 440 Bytes	1 361 361 904 Bytes	-24.9 KiB	-0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-26T12:08:30Z

⚪ 2024-11-26 12:08:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ffdf5b has started.
⚪ 2024-11-26 12:09:06 UTC Artifacts will be uploaded here
⚪ 2024-11-26 12:12:49 UTC ya make is running...
🟡 2024-11-26 13:40:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
26266	23432	0	2	2719	113

⚪ 2024-11-26 13:42:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-26 13:54:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
114 (only retried tests)	7	0	0	0	107

🟢 2024-11-26 13:55:00 UTC Build successful.
🟢 2024-11-26 13:55:19 UTC ydbd size 2.5 GiB changed* by -43.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `2a7eb6b`	merge: `7ffdf5b`	diff	diff %
ydbd size	2 694 580 984 Bytes	2 694 536 200 Bytes	-43.7 KiB	-0.002%
ydbd stripped size	482 594 640 Bytes	482 588 368 Bytes	-6.1 KiB	-0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-27T11:38:48Z

⚪ 2024-11-27 11:38:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0a93980 has started.
⚪ 2024-11-27 11:39:22 UTC Artifacts will be uploaded here
⚪ 2024-11-27 11:43:01 UTC ya make is running...
🟡 2024-11-27 12:36:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
21229	19712	0	1	1397	119

⚪ 2024-11-27 12:38:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-27 12:51:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
893 (only retried tests)	785	0	0	0	108

🟢 2024-11-27 12:51:14 UTC Build successful.
🟢 2024-11-27 12:51:35 UTC ydbd size 2.5 GiB changed* by -104.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `d6aa89c`	merge: `0a93980`	diff	diff %
ydbd size	2 694 334 272 Bytes	2 694 227 720 Bytes	-104.1 KiB	-0.004%
ydbd stripped size	482 130 736 Bytes	482 105 712 Bytes	-24.4 KiB	-0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-27T11:40:06Z

⚪ 2024-11-27 11:40:06 UTC Pre-commit check linux-x86_64-release-asan for 0a93980 has started.
⚪ 2024-11-27 11:40:16 UTC Artifacts will be uploaded here
⚪ 2024-11-27 11:43:17 UTC ya make is running...
🟡 2024-11-27 12:52:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13534	13457	0	23	6	48

🟢 2024-11-27 12:54:07 UTC Build successful.
🟢 2024-11-27 12:54:36 UTC ydbd size 4.9 GiB changed* by -236.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `d6aa89c`	merge: `0a93980`	diff	diff %
ydbd size	5 293 592 392 Bytes	5 293 350 304 Bytes	-236.4 KiB	-0.005%
ydbd stripped size	1 360 890 064 Bytes	1 360 834 448 Bytes	-54.3 KiB	-0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-27T16:06:52Z

⚪ 2024-11-27 16:06:51 UTC Pre-commit check linux-x86_64-release-asan for 13fb1a6 has started.
⚪ 2024-11-27 16:07:03 UTC Artifacts will be uploaded here
⚪ 2024-11-27 16:10:11 UTC ya make is running...
🟡 2024-11-27 17:15:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13538	13464	0	21	7	46

🟢 2024-11-27 17:16:14 UTC Build successful.
🟢 2024-11-27 17:16:42 UTC ydbd size 4.9 GiB changed* by -140.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `0cbe1e0`	merge: `13fb1a6`	diff	diff %
ydbd size	5 293 778 208 Bytes	5 293 634 056 Bytes	-140.8 KiB	-0.003%
ydbd stripped size	1 360 915 280 Bytes	1 360 876 464 Bytes	-37.9 KiB	-0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-11-27T16:09:21Z

⚪ 2024-11-27 16:09:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13fb1a6 has started.
⚪ 2024-11-27 16:09:32 UTC Artifacts will be uploaded here
⚪ 2024-11-27 16:12:42 UTC ya make is running...
🟡 2024-11-27 17:05:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
21229	19720	0	1	1396	112

⚪ 2024-11-27 17:07:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-27 17:19:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
719 (only retried tests)	610	0	0	0	109

🟢 2024-11-27 17:19:32 UTC Build successful.
🟢 2024-11-27 17:19:51 UTC ydbd size 2.5 GiB changed* by -41.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `f54668a`	merge: `13fb1a6`	diff	diff %
ydbd size	2 694 438 592 Bytes	2 694 396 448 Bytes	-41.2 KiB	-0.002%
ydbd stripped size	482 133 104 Bytes	482 120 496 Bytes	-12.3 KiB	-0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

kunga · 2024-11-27T16:13:16Z

ydb/core/tablet_flat/ut/ut_shared_sausagecache.cpp

@@ -425,7 +425,7 @@ Y_UNIT_TEST(S3FIFO) {
    }
    LogCounters(counters);
    UNIT_ASSERT_DOUBLES_EQUAL(counters->ActiveBytes->Val(), static_cast<i64>(8_MB), static_cast<i64>(1_MB / 3));
-    UNIT_ASSERT_VALUES_EQUAL(retried, (TVector<ui32>{100, 21, 2}));


Незначительные изменения в тестах из-за того что sticky страницы перестали отправляться в первом Touch

snaury

Не уверен в корректности такого коммита без полного отказа от приватного кеша, ведь сразу после компакшена в него кладутся какие-то страницы (результат компакшена), и shared body у них к этому моменту ещё нет (или может не совпадать с тем которое успел создать shared cache). Впрочем если ничего не ломается, то разницы немного (может что-нибудь задублироваться и потреблять лишнюю память по идее).

kunga · 2024-11-28T08:28:02Z

Для истории: TEvSaveCompactedPages передаёт то самое shared body в Shared Cache, поэтому оба кэша будут указывать на одну страницу

github-actions bot added the not-for-changelog label Nov 26, 2024

kunga self-assigned this Nov 26, 2024

kunga force-pushed the no-shared-pending-3 branch from 878e57c to 2df30eb Compare November 27, 2024 11:36

kunga added 5 commits November 27, 2024 16:05

Remove share body logic

cb30a2f

verify shared body

49ca1b4

yes

90f8513

fix arg

73c32c5

fix tests

328e063

kunga force-pushed the no-shared-pending-3 branch from 2df30eb to 328e063 Compare November 27, 2024 16:05

github-actions bot added not-for-changelog and removed not-for-changelog labels Nov 27, 2024

kunga commented Nov 27, 2024

View reviewed changes

kunga marked this pull request as ready for review November 28, 2024 08:06

kunga requested a review from snaury November 28, 2024 08:07

snaury approved these changes Nov 28, 2024

View reviewed changes

kunga merged commit bf6d055 into ydb-platform:main Nov 28, 2024
11 checks passed

kunga mentioned this pull request Nov 28, 2024

👑 Concurrent Shared Cache #8447

Open

25 tasks

StekPerepolnen mentioned this pull request Nov 29, 2024

viewer script execute swagger #12137

Merged

naspirato mentioned this pull request Dec 1, 2024

regression TPCC main 28.11-30.11 #12165

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove share body logic #11987

Remove share body logic #11987

kunga commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

kunga Nov 27, 2024

snaury left a comment

kunga commented Nov 28, 2024

Remove share body logic #11987

Remove share body logic #11987

Conversation

kunga commented Nov 26, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 26, 2024 • edited Loading

github-actions bot commented Nov 27, 2024 • edited Loading

github-actions bot commented Nov 27, 2024 • edited Loading

github-actions bot commented Nov 27, 2024 • edited Loading

github-actions bot commented Nov 27, 2024 • edited Loading

kunga Nov 27, 2024

Choose a reason for hiding this comment

snaury left a comment

Choose a reason for hiding this comment

kunga commented Nov 28, 2024

kunga commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024 •

edited

Loading