Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yt provider] Don't run operation input if sections have nodes to calculate #11947

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

rvu1024
Copy link
Member

@rvu1024 rvu1024 commented Nov 25, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@rvu1024 rvu1024 added the area/yql YQL query language issues label Nov 25, 2024
@rvu1024 rvu1024 requested a review from a team as a code owner November 25, 2024 12:51
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 12:53:04 UTC Pre-commit check linux-x86_64-release-asan for e3c5faa has started.
2024-11-25 12:53:15 UTC Artifacts will be uploaded here
2024-11-25 12:56:11 UTC ya make is running...
🟡 2024-11-25 14:26:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9156 9090 0 12 6 48

🟢 2024-11-25 14:27:45 UTC Build successful.
🟢 2024-11-25 14:28:15 UTC ydbd size 4.9 GiB changed* by +74.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 346aedc merge: e3c5faa diff diff %
ydbd size 5 284 326 944 Bytes 5 284 402 768 Bytes +74.0 KiB +0.001%
ydbd stripped size 1 359 968 560 Bytes 1 359 973 872 Bytes +5.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 12:53:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for e3c5faa has started.
2024-11-25 12:53:50 UTC Artifacts will be uploaded here
2024-11-25 12:56:46 UTC ya make is running...
🟢 2024-11-25 14:19:48 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24909 22077 0 0 2719 113

🟢 2024-11-25 14:21:55 UTC Build successful.
🟢 2024-11-25 14:22:15 UTC ydbd size 2.5 GiB changed* by +35.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 346aedc merge: e3c5faa diff diff %
ydbd size 2 690 056 568 Bytes 2 690 093 344 Bytes +35.9 KiB +0.001%
ydbd stripped size 482 185 488 Bytes 482 187 024 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rvu1024 rvu1024 marked this pull request as draft November 26, 2024 09:03
@rvu1024 rvu1024 changed the title [yt provider] Add Left! updates in CalculateColumnGroups optimizer [yt provider] Don't run operation input if sections have nodes to calculate Nov 27, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 27, 2024
@rvu1024 rvu1024 marked this pull request as ready for review November 27, 2024 16:17
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 16:18:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 699924b has started.
2024-11-27 16:18:14 UTC Artifacts will be uploaded here
2024-11-27 16:21:09 UTC ya make is running...
🟡 2024-11-27 17:19:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30668 27823 0 2 2720 123

2024-11-27 17:21:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-27 17:41:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
734 (only retried tests) 625 0 1 0 108

2024-11-27 17:41:49 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-27 17:53:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
675 (only retried tests) 567 0 0 0 108

🟢 2024-11-27 17:53:39 UTC Build successful.
🟢 2024-11-27 17:54:03 UTC ydbd size 2.5 GiB changed* by +8.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f54668a merge: 699924b diff diff %
ydbd size 2 694 438 592 Bytes 2 694 447 712 Bytes +8.9 KiB +0.000%
ydbd stripped size 482 133 104 Bytes 482 134 000 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rvu1024 rvu1024 requested a review from vitstn November 27, 2024 16:18
Copy link

github-actions bot commented Nov 27, 2024

2024-11-27 16:18:26 UTC Pre-commit check linux-x86_64-release-asan for 699924b has started.
2024-11-27 16:18:37 UTC Artifacts will be uploaded here
2024-11-27 16:21:35 UTC ya make is running...
🟡 2024-11-27 17:41:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13329 13246 0 27 7 49

🟢 2024-11-27 17:42:52 UTC Build successful.
🟢 2024-11-27 17:43:21 UTC ydbd size 4.9 GiB changed* by +21.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f54668a merge: 699924b diff diff %
ydbd size 5 293 726 840 Bytes 5 293 748 816 Bytes +21.5 KiB +0.000%
ydbd stripped size 1 360 903 600 Bytes 1 360 911 184 Bytes +7.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@rvu1024 rvu1024 merged commit 34a26dd into ydb-platform:main Nov 28, 2024
11 checks passed
rvu1024 added a commit to rvu1024/ydb that referenced this pull request Nov 28, 2024
vitstn pushed a commit that referenced this pull request Nov 28, 2024
@rvu1024 rvu1024 deleted the fix_col_grp_left branch January 11, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants