Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable-24-3] Remove old restriction: keys with Uint8 column values >127 are currently prohibited (#11886) #11901

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

KIKIMR-7112

Due to an old comparator error there is restriction Keys with Uint8 column values >127 are currently prohibited.
The comparator error has been fixed long ago. So the restriction should be removed.

Changelog category

  • Bugfix

Additional information

...

@azevaykin azevaykin requested a review from a team as a code owner November 22, 2024 19:13
Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 19:16:53 UTC Pre-commit check for 8c57079 has started.
2024-11-22 19:19:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-22 19:42:41 UTC Build successful.
2024-11-22 19:42:59 UTC Tests are running...
🔴 2024-11-22 21:42:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10420 10312 0 39 28 41

🟢 2024-11-22 21:43:32 UTC ydbd size 5.6 GiB changed* by -26.6 KiB, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 9d525db merge: 8c57079 diff diff %
ydbd size 5 996 959 144 Bytes 5 996 931 856 Bytes -26.6 KiB -0.000%
ydbd stripped size 1 503 030 304 Bytes 1 503 019 616 Bytes -10.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 19:17:40 UTC Pre-commit check for 8c57079 has started.
2024-11-22 19:20:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-22 19:27:11 UTC Build successful.

Copy link

github-actions bot commented Nov 22, 2024

2024-11-22 19:17:40 UTC Pre-commit check for 8c57079 has started.
2024-11-22 19:20:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-22 20:01:10 UTC Build successful.
2024-11-22 20:01:27 UTC Tests are running...
🔴 2024-11-22 21:46:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38982 33698 0 29 5217 38

🟢 2024-11-22 21:47:05 UTC ydbd size 8.3 GiB changed* by +34.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 0ab8d25 merge: 8c57079 diff diff %
ydbd size 8 865 263 456 Bytes 8 865 298 576 Bytes +34.3 KiB +0.000%
ydbd stripped size 484 011 848 Bytes 484 019 560 Bytes +7.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit ac5d203 into ydb-platform:stable-24-3 Nov 25, 2024
8 of 12 checks passed
@azevaykin azevaykin deleted the stable-24-3-uint8 branch December 6, 2024 14:06
@azevaykin azevaykin restored the stable-24-3-uint8 branch December 22, 2024 18:37
azevaykin added a commit to azevaykin/ydb that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants