Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple reader #11894

Merged
merged 32 commits into from
Nov 26, 2024
Merged

Simple reader #11894

merged 32 commits into from
Nov 26, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement
  • Performance improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:03:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 77c3abd has started.
⚪ 2024-11-22 15:04:05 UTC Artifacts will be uploaded here
⚫ 2024-11-22 15:05:28 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:04:41 UTC Pre-commit check linux-x86_64-release-asan for 77c3abd has started.
⚪ 2024-11-22 15:04:52 UTC Artifacts will be uploaded here
⚫ 2024-11-22 15:05:28 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:08:40 UTC Pre-commit check linux-x86_64-release-asan for 1660046 has started.
⚪ 2024-11-22 15:08:50 UTC Artifacts will be uploaded here
⚪ 2024-11-22 15:12:04 UTC ya make is running...
🔴 2024-11-22 15:19:53 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:10:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1660046 has started.
⚪ 2024-11-22 15:11:04 UTC Artifacts will be uploaded here
⚪ 2024-11-22 15:14:30 UTC ya make is running...
🔴 2024-11-22 15:20:46 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:30:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 94c6ad3 has started.
⚪ 2024-11-22 15:31:26 UTC Artifacts will be uploaded here
⚪ 2024-11-22 15:35:07 UTC ya make is running...
⚫ 2024-11-22 15:39:51 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:32:54 UTC Pre-commit check linux-x86_64-release-asan for 94c6ad3 has started.
⚪ 2024-11-22 15:33:07 UTC Artifacts will be uploaded here
⚪ 2024-11-22 15:36:32 UTC ya make is running...
⚫ 2024-11-22 15:39:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:44:49 UTC Pre-commit check linux-x86_64-release-asan for 636531c has started.
⚪ 2024-11-22 15:45:01 UTC Artifacts will be uploaded here
⚪ 2024-11-22 15:48:31 UTC ya make is running...
🔴 2024-11-22 15:53:46 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

⚪ 2024-11-22 15:44:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 636531c has started.
⚪ 2024-11-22 15:45:07 UTC Artifacts will be uploaded here
⚪ 2024-11-22 15:48:36 UTC ya make is running...
🔴 2024-11-22 15:57:09 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

⚪ 2024-11-23 08:45:36 UTC Pre-commit check linux-x86_64-release-asan for e842fea has started.
⚪ 2024-11-23 08:45:47 UTC Artifacts will be uploaded here
⚪ 2024-11-23 08:49:03 UTC ya make is running...
🟡 2024-11-23 10:28:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10518 10440 0 14 13 51

🟢 2024-11-23 10:29:10 UTC Build successful.
🟡 2024-11-23 10:29:38 UTC ydbd size 4.9 GiB changed* by +354.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8e35b97 merge: e842fea diff diff %
ydbd size 5 285 166 656 Bytes 5 285 529 952 Bytes +354.8 KiB +0.007%
ydbd stripped size 1 359 563 472 Bytes 1 359 640 912 Bytes +75.6 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

⚪ 2024-11-23 08:46:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for e842fea has started.
⚪ 2024-11-23 08:46:32 UTC Artifacts will be uploaded here
⚪ 2024-11-23 08:49:58 UTC ya make is running...
🟡 2024-11-23 10:22:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41982 36268 0 3 5601 110

⚪ 2024-11-23 10:26:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-23 10:37:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 10 0 0 1 107

🟢 2024-11-23 10:38:02 UTC Build successful.
🟡 2024-11-23 10:38:22 UTC ydbd size 2.5 GiB changed* by +151.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8e35b97 merge: e842fea diff diff %
ydbd size 2 691 749 192 Bytes 2 691 904 520 Bytes +151.7 KiB +0.006%
ydbd stripped size 482 183 984 Bytes 482 189 040 Bytes +4.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

⚪ 2024-11-23 17:55:18 UTC Pre-commit check linux-x86_64-release-asan for 07cd75e has started.
⚪ 2024-11-23 17:55:29 UTC Artifacts will be uploaded here
⚫ 2024-11-23 17:57:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

⚪ 2024-11-23 18:01:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 93b6ebc has started.
⚪ 2024-11-23 18:01:43 UTC Artifacts will be uploaded here
⚪ 2024-11-23 18:05:04 UTC ya make is running...
🟡 2024-11-23 19:39:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41987 35834 0 357 5679 117

⚪ 2024-11-23 19:42:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-23 19:55:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
558 (only retried tests) 105 0 340 1 112

⚪ 2024-11-23 19:55:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-23 20:08:39 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
452 (only retried tests) 4 0 336 0 112

🟢 2024-11-23 20:08:48 UTC Build successful.
🔴 2024-11-23 20:09:12 UTC ydbd size 2.5 GiB changed* by +3.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 398fb41 merge: 93b6ebc diff diff %
ydbd size 2 691 757 096 Bytes 2 695 463 608 Bytes +3.5 MiB +0.138%
ydbd stripped size 482 186 480 Bytes 482 497 744 Bytes +304.0 KiB +0.065%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

⚪ 2024-11-23 18:05:19 UTC Pre-commit check linux-x86_64-release-asan for 93b6ebc has started.
⚪ 2024-11-23 18:05:31 UTC Artifacts will be uploaded here
⚪ 2024-11-23 18:08:48 UTC ya make is running...
🟡 2024-11-23 19:46:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10519 10163 0 295 8 53

🟢 2024-11-23 19:47:13 UTC Build successful.
🔴 2024-11-23 19:47:41 UTC ydbd size 4.9 GiB changed* by +7.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 398fb41 merge: 93b6ebc diff diff %
ydbd size 5 285 179 424 Bytes 5 292 763 264 Bytes +7.2 MiB +0.143%
ydbd stripped size 1 359 568 912 Bytes 1 360 585 680 Bytes +992.9 KiB +0.075%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 14:54:20 UTC Pre-commit check linux-x86_64-release-asan for 977805d has started.
⚪ 2024-11-25 14:54:53 UTC Artifacts will be uploaded here
⚫ 2024-11-25 14:56:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 14:54:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 977805d has started.
⚪ 2024-11-25 14:54:45 UTC Artifacts will be uploaded here
⚫ 2024-11-25 14:56:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 14:58:36 UTC Pre-commit check linux-x86_64-release-asan for 8a09469 has started.
⚪ 2024-11-25 14:58:40 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:01:56 UTC ya make is running...
⚫ 2024-11-25 15:09:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 14:59:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a09469 has started.
⚪ 2024-11-25 14:59:26 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:02:49 UTC ya make is running...
⚫ 2024-11-25 15:09:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 15:13:19 UTC Pre-commit check linux-x86_64-release-asan for d7902e7 has started.
⚪ 2024-11-25 15:13:34 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:16:54 UTC ya make is running...
🔴 2024-11-25 15:21:50 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 15:13:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for d7902e7 has started.
⚪ 2024-11-25 15:13:34 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:16:57 UTC ya make is running...
🔴 2024-11-25 15:22:42 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 15:36:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for f436fb8 has started.
⚪ 2024-11-25 15:37:23 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:41:15 UTC ya make is running...
🟡 2024-11-25 17:13:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26310 23478 0 1 2719 112

⚪ 2024-11-25 17:15:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-25 17:27:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 4 0 1 0 108

⚪ 2024-11-25 17:27:16 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-25 17:28:47 UTC ydbd size 2.5 GiB changed* by +3.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 2bc34d4 merge: f436fb8 diff diff %
ydbd size 2 690 447 960 Bytes 2 694 362 080 Bytes +3.7 MiB +0.145%
ydbd stripped size 482 237 072 Bytes 482 555 344 Bytes +310.8 KiB +0.066%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-11-25 17:28:50 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 15:38:36 UTC Pre-commit check linux-x86_64-release-asan for f436fb8 has started.
⚪ 2024-11-25 15:38:49 UTC Artifacts will be uploaded here
⚪ 2024-11-25 15:42:22 UTC ya make is running...
🟡 2024-11-25 17:25:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10515 10429 0 22 14 50

🟢 2024-11-25 17:26:12 UTC Build successful.
🔴 2024-11-25 17:26:47 UTC ydbd size 4.9 GiB changed* by +7.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 2bc34d4 merge: f436fb8 diff diff %
ydbd size 5 285 275 800 Bytes 5 293 178 520 Bytes +7.5 MiB +0.150%
ydbd stripped size 1 360 239 152 Bytes 1 361 269 264 Bytes +1006.0 KiB +0.076%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 17:30:36 UTC Pre-commit check linux-x86_64-release-asan for 57f350b has started.
⚪ 2024-11-25 17:30:51 UTC Artifacts will be uploaded here
⚪ 2024-11-25 17:34:06 UTC ya make is running...
⚫ 2024-11-25 18:00:46 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 17:31:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 57f350b has started.
⚪ 2024-11-25 17:31:55 UTC Artifacts will be uploaded here
⚪ 2024-11-25 17:35:12 UTC ya make is running...
⚫ 2024-11-25 18:00:46 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 18:03:18 UTC Pre-commit check linux-x86_64-release-asan for 5750ae2 has started.
⚪ 2024-11-25 18:03:23 UTC Artifacts will be uploaded here
⚪ 2024-11-25 18:06:37 UTC ya make is running...
🟡 2024-11-25 19:13:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10516 10439 0 24 7 46

🟢 2024-11-25 19:14:48 UTC Build successful.
🔴 2024-11-25 19:15:16 UTC ydbd size 4.9 GiB changed* by +7.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: a925034 merge: 5750ae2 diff diff %
ydbd size 5 285 275 832 Bytes 5 293 183 096 Bytes +7.5 MiB +0.150%
ydbd stripped size 1 360 239 152 Bytes 1 361 270 480 Bytes +1007.2 KiB +0.076%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

⚪ 2024-11-25 18:03:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5750ae2 has started.
⚪ 2024-11-25 18:03:43 UTC Artifacts will be uploaded here
⚪ 2024-11-25 18:07:00 UTC ya make is running...
🟢 2024-11-25 19:04:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26309 23481 0 0 2718 110

🟢 2024-11-25 19:07:04 UTC Build successful.
🔴 2024-11-25 19:07:21 UTC ydbd size 2.5 GiB changed* by +3.7 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: a925034 merge: 5750ae2 diff diff %
ydbd size 2 690 447 992 Bytes 2 694 363 968 Bytes +3.7 MiB +0.146%
ydbd stripped size 482 237 072 Bytes 482 555 728 Bytes +311.2 KiB +0.066%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 26, 2024 05:53
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 26, 2024 05:53
@ivanmorozov333 ivanmorozov333 merged commit 6ed5294 into ydb-platform:main Nov 26, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the simple_reader branch November 26, 2024 10:40
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 27, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
@ivanmorozov333 @zverevgeny
Simple reader (ydb-platform#11894)
e809d77 
Conflicts:
	ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@ivanmorozov333 @zverevgeny
Simple reader (ydb-platform#11894)
e247f81 
Conflicts:
	ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@ivanmorozov333 @zverevgeny
Simple reader (ydb-platform#11894)
8f07350 
Conflicts:
	ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
@ivanmorozov333 @zverevgeny
Simple reader (ydb-platform#11894)
2963536 
Conflicts:
	ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @zverevgeny