Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQL-17542 remove function with confusing name CreateKqpTaskRunner #1183

Merged
merged 1 commit into from
Jan 22, 2024
Merged

YQL-17542 remove function with confusing name CreateKqpTaskRunner #1183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ void TKqpScanComputeActor::DoBootstrap() {
};
}

auto taskRunner = CreateKqpTaskRunner(execCtx, settings, logger);
auto taskRunner = MakeDqTaskRunner(execCtx, settings, logger);
TBase::SetTaskRunner(taskRunner);

auto wakeup = [this] { ContinueExecute(); };
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/kqp/executer_actor/kqp_literal_executer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ class TKqpLiteralExecuter {
<< message);
};

auto taskRunner = CreateKqpTaskRunner(context, settings, log);
auto taskRunner = MakeDqTaskRunner(context, settings, log);
TaskRunners.emplace_back(taskRunner);

auto taskSettings = NDq::TDqTaskSettings(&protoTask);
Expand Down
8 changes: 1 addition & 7 deletions ydb/core/kqp/runtime/kqp_tasks_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NDqProto::TTaskOutput& outp
}
}

TIntrusivePtr<IDqTaskRunner> CreateKqpTaskRunner(const TDqTaskRunnerContext& execCtx,
const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc)
{
return MakeDqTaskRunner(execCtx, settings, logFunc);
}


TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField<NDqProto::TDqTask>&& tasks,
const TDqTaskRunnerContext& execCtx, const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc)
Expand All @@ -92,7 +86,7 @@ TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField<NDqProto::TD
try {
for (auto&& task : tasks) {
ui64 taskId = task.GetId();
auto runner = CreateKqpTaskRunner(execCtx, settings, logFunc);
auto runner = MakeDqTaskRunner(execCtx, settings, logFunc);
if (auto* stats = runner->GetStats()) {
Stats.emplace(taskId, stats);
}
Expand Down
3 changes: 0 additions & 3 deletions ydb/core/kqp/runtime/kqp_tasks_runner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ NYql::NDq::IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NYql::NDqProto::
const NKikimr::NMiniKQL::THolderFactory& holderFactory,
TVector<NYql::NDq::IDqOutput::TPtr>&& outputs);

TIntrusivePtr<NYql::NDq::IDqTaskRunner> CreateKqpTaskRunner(const NYql::NDq::TDqTaskRunnerContext& execCtx,
const NYql::NDq::TDqTaskRunnerSettings& settings, const NYql::NDq::TLogFunc& logFunc);


class TKqpTasksRunner : public TSimpleRefCount<TKqpTasksRunner>, private TNonCopyable {
public:
Expand Down
Loading