Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portion_id to log scope in TReadPortionInfoWithBlobs::RestoreBatch #11771

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

fexolm
Copy link
Contributor

@fexolm fexolm commented Nov 20, 2024

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Nov 20, 2024

2024-11-20 06:43:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for de469a6 has started.
2024-11-20 06:43:59 UTC Artifacts will be uploaded here
2024-11-20 06:47:07 UTC ya make is running...
🔴 2024-11-20 06:49:51 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Nov 20, 2024

2024-11-20 06:44:03 UTC Pre-commit check linux-x86_64-release-asan for de469a6 has started.
2024-11-20 06:44:14 UTC Artifacts will be uploaded here
2024-11-20 06:47:24 UTC ya make is running...
🔴 2024-11-20 06:50:40 UTC Build failed, see the logs. Also see fail summary

@fexolm fexolm force-pushed the fexolm/add-partition-id-log branch from cecdcad to b4bfca9 Compare November 20, 2024 11:20
Copy link

github-actions bot commented Nov 20, 2024

2024-11-20 11:22:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for f980678 has started.
2024-11-20 11:22:44 UTC Artifacts will be uploaded here
2024-11-20 11:25:42 UTC ya make is running...
🟡 2024-11-20 12:14:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15203 13681 0 1 1406 115

2024-11-20 12:15:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-20 12:27:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 8 0 0 1 108

🟢 2024-11-20 12:57:47 UTC Build successful.
🟢 2024-11-20 12:58:06 UTC ydbd size 2.5 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2c79389 merge: f980678 diff diff %
ydbd size 2 686 274 448 Bytes 2 686 276 928 Bytes +2.4 KiB +0.000%
ydbd stripped size 481 286 448 Bytes 481 286 768 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 20, 2024

2024-11-20 11:23:03 UTC Pre-commit check linux-x86_64-release-asan for f980678 has started.
2024-11-20 11:23:15 UTC Artifacts will be uploaded here
2024-11-20 11:26:11 UTC ya make is running...
🟡 2024-11-20 12:28:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8968 8907 0 11 4 46

🟢 2024-11-20 12:28:52 UTC Build successful.
🟢 2024-11-20 12:29:19 UTC ydbd size 4.9 GiB changed* by +5.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2c79389 merge: f980678 diff diff %
ydbd size 5 264 863 208 Bytes 5 264 868 520 Bytes +5.2 KiB +0.000%
ydbd stripped size 1 351 633 392 Bytes 1 351 633 968 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 20, 2024 12:00
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 20, 2024 12:00
@fexolm fexolm merged commit 872bb4d into ydb-platform:main Nov 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants