Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading logic in case memory control #11768

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix reading logic in case memory control #11768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89ad923
fix reading logic in case memory control
ivanmorozov333 Nov 20, 2024
de97d2e
fix
ivanmorozov333 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ydb/core/tx/columnshard/engines/reader/plain_reader/iterator/source.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ class IDataSource {
virtual bool DoStartFetchingAccessor(const std::shared_ptr<IDataSource>& sourcePtr, const TFetchingScriptCursor& step) = 0;

public:
virtual bool NeedAccessorsForRead() const = 0;
virtual bool NeedAccessorsFetching() const = 0;

bool StartFetchingAccessor(const std::shared_ptr<IDataSource>& sourcePtr, const TFetchingScriptCursor& step) {
Expand Down Expand Up @@ -110,7 +111,7 @@ class IDataSource {
void SetSourceInMemory(const bool value) {
AFL_VERIFY(!IsSourceInMemoryFlag);
IsSourceInMemoryFlag = value;
if (NeedAccessorsFetching()) {
if (NeedAccessorsForRead()) {
AFL_VERIFY(StageData);
if (!value) {
StageData->SetUseFilter(value);
Expand Down Expand Up @@ -317,6 +318,10 @@ class TPortionDataSource: public IDataSource {
virtual bool DoStartFetchingAccessor(const std::shared_ptr<IDataSource>& sourcePtr, const TFetchingScriptCursor& step) override;

public:
virtual bool NeedAccessorsForRead() const override {
return true;
}

virtual bool NeedAccessorsFetching() const override {
return !StageData || !StageData->HasPortionAccessor();
}
Expand Down Expand Up @@ -425,6 +430,10 @@ class TCommittedDataSource: public IDataSource {
}

public:
virtual bool NeedAccessorsForRead() const override {
return false;
}

virtual bool NeedAccessorsFetching() const override {
return false;
}
Expand Down
Loading