Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergelibs yurchuk manual #11568

Merged
merged 92 commits into from
Nov 14, 2024

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Nov 13, 2024

Manual mergelibs due to conflicts in wf

rvu1024 and others added 30 commits November 8, 2024 13:44
commit_hash:e7deb73902788e8e694c8da7719f9c7a4e77f698
change base скрипт
commit_hash:abea0d7a031fd7bbbb1e754495e2c482b073be62
commit_hash:b75c4510058a45b92316d448f6ac2dc21963b920
commit_hash:ea73897466c683c4f852d5c9b6eebee419e6b8ab
commit_hash:be10606b22b15d660282895983c88ae5a0db0be9
commit_hash:f9919e12f1ad5fc8cec36ba2d5a434245af7d92b
Plan:

 1) Remove `IAttributedDictionary` type from the public API. \+

 2) Remove `Set` method from public API in favor of `operator<<=`. \+

 3) Adopt `ConvertTo<T>` (or other name) CPO with proper extension into `NYT::NYson::ConvertTo` from `yt/core`.

 4) Use CPO from (3) to eliminate direct dependency on `yt/core` of `Get/Find` methods from attributes API.

 5) Adopt `ConvertToYsonString` (or other name) CPO with proper extension into `yt/core` customisations.

 6) Use CPO from (5) to eliminate direct dependency on `yt/core` of `TErrorAttribute` ctor.

 7) Swap attributes implementation to the one which doesn’t use `IAttributeDictionary`.

 8) At this point `stripped_error*` can be moved to library/cpp/yt and so can recursively dependant on THROW macro methods `Get/Find/…`.

 9) Adjust CPO’s to work with `std::string` instead of `TYsonString` assuming text format to be used (maybe `TString` for now).

10) Remove dep of `library/cpp/yt/error` on `yson` entirely.

This pr addresses 3-4 steps of plan. Below is a brief explanation of design decisions.

We want to have a concept which detects if there is a `ConvertTo` method and if true, try calling it. Templates can only perform unqualified name lookup and if we allow non-ADL overloads to be found, we would have dependency on inclusion order (if `ConvertTo` is included prior to our code, everything works fine, but if the order is reverse, templated dispatch would fail, but direct call would work just fine). That is why we adopt niebloids which first disable ADL lookup of the name `ConvertTo` by directing it to niebloid implemented via `TagInvoke` mechanism. TagInvoke design <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1895r0.pdf> . TL;DR: we want to have behavior which is consistent with inclusion order.

Key difference now is that `ConvertTo` works consistently in both manual calls and template function body calls and is no longer visible for ADL part of the unqualified name lookup
commit_hash:32af641bd0af559bfe670c2ceb36721fb4afc2dd
commit_hash:17dbd6d7e5fc440afa2d816e245a73e25135bfb5
commit_hash:cba3283f48e43daee374c408d91d1fed33861da4
commit_hash:b2b69ddfc6b8407ae1b67895aee91f96e439d07d
commit_hash:6dd56a3c0d552a30b3e30a2b133d638716e1893d
init
commit_hash:16572ab4e94aea4f7455c2ccb90b70ea99a412db
commit_hash:3f697645c477cec6c6eb25aa02724b47de71544c
commit_hash:2e32c346f257520a6c3629b88dc628744d3d3386
[nodiff:caesar]
commit_hash:eb743854a8d8c28984b9774cd4ad7774dae69eed
commit_hash:0468f946ddc0d3a27c085e6e5ec4ce8121c4024d
commit_hash:761e2e80642a3d32073f0261b3f5b1992e54a74f
commit_hash:e86979e06d3da29afb1906e79ad128b77553722b
Move node_modules bundle for peers only when those exist
commit_hash:ba53ab8e38bbf8c45cdb921344bf780ff1d5f9da
add constant for HTTP 434 code
commit_hash:bb04bc4efd36dc9989de7535b40c968c69b27472
commit_hash:3381c362bf53465449cc36ad460347615208e001
Remaining jbuild code does not read this key anymore.
commit_hash:e630ee72ec38fc1361861167ba61b46d03e7a099
commit_hash:88de11271aee6ce875a836cbfb24e825d8e7fa99
commit_hash:a48f9d9abf0ac0bec1edeb52eb1d3fea3fe7d758
Support WITH_KOTLIN_GRPC for ya ide gradle
commit_hash:3393b00307a4160894a72e073eb2eeb9e8f0d747
Support options for call rescompiler in CMake
commit_hash:8110f08c01093f7c7186effee493f2c269031868
commit_hash:1495166c0ac2e13c7e4f9be22ca76a5268e67d0d
From hash: [9f16b1f02cbf93ca08e1aa39e3063c96b86d6ebf](HIDDEN_URL
From revision: [15278243](HIDDEN_URL
[CI flow](HIDDEN_URL
Flow triggered by user: [robot-ci](HIDDEN_URL

Update tools: test_tool, os_ya, ya_bin, os_test_tool
commit_hash:e9c21e145d7d1a0bf9f6b7e43356fe8035218297
commit_hash:f0bc2fa36fa94ba3e69729ccaa2d71f15f3b9330
Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 07:41:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for e13887d has started.
2024-11-14 07:41:29 UTC Artifacts will be uploaded here
2024-11-14 07:49:49 UTC ya make is running...
🔴 2024-11-14 07:51:33 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 07:41:27 UTC Pre-commit check linux-x86_64-release-asan for e13887d has started.
2024-11-14 07:41:37 UTC Artifacts will be uploaded here
2024-11-14 07:50:01 UTC ya make is running...
🔴 2024-11-14 07:50:18 UTC Build failed, see the logs. Also see fail summary

E1pp and others added 3 commits November 14, 2024 12:22
Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 09:56:00 UTC Pre-commit check linux-x86_64-release-asan for d69b684 has started.
2024-11-14 09:56:11 UTC Artifacts will be uploaded here
2024-11-14 10:04:15 UTC ya make is running...
🔴 2024-11-14 10:04:31 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 09:56:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for d69b684 has started.
2024-11-14 09:56:31 UTC Artifacts will be uploaded here
2024-11-14 10:04:35 UTC ya make is running...
2024-11-14 10:51:52 UTC Check cancelled

robot-piglet and others added 5 commits November 14, 2024 13:32
commit_hash:513da6b12f03f09633629ffd3bc8732063ad3a98
Update YFM for ya make to latest version
commit_hash:ed715d7e095d0862895cde5ae816fad944039c9e
commit_hash:05ab74f9ed1a1c6e8ca77975c6c23c79432b7093
Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 10:55:12 UTC Pre-commit check linux-x86_64-release-asan for 665afdd has started.
2024-11-14 10:55:50 UTC Artifacts will be uploaded here
2024-11-14 11:04:56 UTC ya make is running...
🔴 2024-11-14 11:06:36 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 10:56:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 665afdd has started.
2024-11-14 10:56:21 UTC Artifacts will be uploaded here
2024-11-14 11:04:24 UTC ya make is running...
🔴 2024-11-14 11:06:23 UTC Build failed, see the logs. Also see fail summary

commit_hash:bbe5982909469ab84284cb16547e69a096d992ea
* Changelog entry
  Type: fix
  Component: proxy

Some fixes in decimal:

* Support parsing of nested `decimal128`/`decimal256` in Arrow.
* Fix bug in `decimal256` unversioned value representation --
  before this change, Arrow parser for `decimal256(n, p)` was
  always emitting strings of length 256 bits, event for n \<= 38,
  which is incorrect in the representation of YT `decimal(n, p)`
  type. Now it produces strings of variadic length (32, 64, 128
  or 256 bits) depending on n, similar to `decimal128(n, p)`.

---

Pull Request resolved: <ytsaurus/ytsaurus#942>
commit_hash:32e66c7eb4d996caf0893f97d269fb1930bc5f7a
@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Nov 14, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Nov 14, 2024
commit_hash:ef0c01e74df8c79f53eaa311abe8b6ac0419e864
Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 14:09:34 UTC Pre-commit check linux-x86_64-release-asan for 2f4f74a has started.
2024-11-14 14:09:45 UTC Artifacts will be uploaded here
2024-11-14 14:18:15 UTC ya make is running...
🔴 2024-11-14 14:19:49 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 14:09:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2f4f74a has started.
2024-11-14 14:10:33 UTC Artifacts will be uploaded here
2024-11-14 14:19:23 UTC ya make is running...
🔴 2024-11-14 14:21:44 UTC Build failed, see the logs. Also see fail summary

rvu1024 and others added 3 commits November 14, 2024 17:12
Example of new logging:

```
[perf] yql_expr_optimize.cpp:540: Execution of [ExpandApply] took 20.9ms
```
commit_hash:701cc78f48eee1a8c0f824edb6a9310fd348ba92
Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 14:29:34 UTC Pre-commit check linux-x86_64-release-asan for cf60174 has started.
2024-11-14 14:29:45 UTC Artifacts will be uploaded here
2024-11-14 14:38:04 UTC ya make is running...
🟡 2024-11-14 16:54:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11987 11875 0 32 30 50

🟢 2024-11-14 16:55:16 UTC Build successful.
🟢 2024-11-14 16:55:48 UTC ydbd size 4.9 GiB changed* by -883.0 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d3eebb6 merge: cf60174 diff diff %
ydbd size 6 179 299 856 Bytes 5 253 405 056 Bytes -883.0 MiB -14.984%
ydbd stripped size 1 540 780 816 Bytes 1 349 997 776 Bytes -181.9 MiB -12.382%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 14, 2024

2024-11-14 14:29:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for cf60174 has started.
2024-11-14 14:29:50 UTC Artifacts will be uploaded here
2024-11-14 14:38:00 UTC ya make is running...
🟡 2024-11-14 16:17:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76780 62667 0 11 13986 116

2024-11-14 16:24:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-14 16:36:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 15 0 0 0 108

🟢 2024-11-14 16:36:52 UTC Build successful.
🟢 2024-11-14 16:37:12 UTC ydbd size 2.5 GiB changed* by -354.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d3eebb6 merge: cf60174 diff diff %
ydbd size 3 052 991 864 Bytes 2 680 828 864 Bytes -354.9 MiB -12.190%
ydbd stripped size 483 022 624 Bytes 480 711 632 Bytes -2.2 MiB -0.478%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk marked this pull request as ready for review November 14, 2024 14:59
@maximyurchuk maximyurchuk requested a review from a team as a code owner November 14, 2024 14:59
@alexv-smirnov alexv-smirnov merged commit 4239317 into ydb-platform:main Nov 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.