Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary chain set in huge blob keeper heap #11566

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Support arbitrary chain set in huge blob keeper heap #11566

merged 1 commit into from
Nov 20, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Nov 13, 2024

Changelog entry

Support arbitrary chain set in huge blob keeper heap

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Introduce feature allowing to change huge blob size set transparently.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:12:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8939bec has started.
⚪ 2024-11-13 13:13:05 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:16:37 UTC ya make is running...
⚫ 2024-11-13 13:31:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:15:42 UTC Pre-commit check linux-x86_64-release-asan for 8939bec has started.
⚪ 2024-11-13 13:15:52 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:19:13 UTC ya make is running...
⚫ 2024-11-13 13:31:06 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/huge-heap-supports-arbitrary-slots branch from 3b4ad0c to d546c2c Compare November 13, 2024 13:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:35:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4910d8 has started.
⚪ 2024-11-13 13:35:31 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:38:56 UTC ya make is running...
⚫ 2024-11-13 13:46:26 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:35:51 UTC Pre-commit check linux-x86_64-release-asan for d4910d8 has started.
⚪ 2024-11-13 13:36:01 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:39:15 UTC ya make is running...
⚫ 2024-11-13 13:46:25 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/huge-heap-supports-arbitrary-slots branch from d546c2c to df5e57e Compare November 13, 2024 13:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:48:05 UTC Pre-commit check linux-x86_64-release-asan for b71bc66 has started.
⚪ 2024-11-13 13:48:15 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:51:30 UTC ya make is running...
🟡 2024-11-13 15:18:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10440 10329 0 54 8 49

🟢 2024-11-13 15:19:24 UTC Build successful.
🟢 2024-11-13 15:20:00 UTC ydbd size 5.7 GiB changed* by -33.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ee51155 merge: b71bc66 diff diff %
ydbd size 6 171 497 008 Bytes 6 171 462 432 Bytes -33.8 KiB -0.001%
ydbd stripped size 1 538 180 752 Bytes 1 538 178 672 Bytes -2.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

⚪ 2024-11-13 13:48:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for b71bc66 has started.
⚪ 2024-11-13 13:48:16 UTC Artifacts will be uploaded here
⚪ 2024-11-13 13:51:38 UTC ya make is running...
🟡 2024-11-13 15:03:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41809 36112 0 26 5558 113

⚪ 2024-11-13 15:13:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-13 15:28:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 8 0 17 0 109

⚪ 2024-11-13 15:28:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-13 15:40:07 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
126 (only retried tests) 0 0 17 0 109

🟢 2024-11-13 15:40:16 UTC Build successful.
🟢 2024-11-13 15:40:42 UTC ydbd size 2.8 GiB changed* by -21.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ee51155 merge: b71bc66 diff diff %
ydbd size 3 049 731 352 Bytes 3 049 709 160 Bytes -21.7 KiB -0.001%
ydbd stripped size 482 438 240 Bytes 482 437 344 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the vdisk/huge-heap-supports-arbitrary-slots branch from df5e57e to 34b17c8 Compare November 19, 2024 05:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 05:08:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for c8bd835 has started.
⚪ 2024-11-19 05:09:09 UTC Artifacts will be uploaded here
⚪ 2024-11-19 05:12:31 UTC ya make is running...
🟡 2024-11-19 06:42:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41885 36191 0 21 5558 115

⚪ 2024-11-19 06:46:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-19 06:59:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
133 (only retried tests) 3 0 18 1 111

⚪ 2024-11-19 06:59:21 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-19 07:11:51 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 1 0 19 0 110

🟢 2024-11-19 07:11:58 UTC Build successful.
🟢 2024-11-19 07:12:21 UTC ydbd size 2.5 GiB changed* by -13.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dbd9c12 merge: c8bd835 diff diff %
ydbd size 2 684 642 200 Bytes 2 684 627 936 Bytes -13.9 KiB -0.001%
ydbd stripped size 481 178 288 Bytes 481 176 560 Bytes -1.7 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 05:11:07 UTC Pre-commit check linux-x86_64-release-asan for c8bd835 has started.
⚪ 2024-11-19 05:11:18 UTC Artifacts will be uploaded here
⚪ 2024-11-19 05:14:37 UTC ya make is running...
🟡 2024-11-19 06:51:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10474 10381 0 35 9 49

🟢 2024-11-19 06:51:57 UTC Build successful.
🟢 2024-11-19 06:52:24 UTC ydbd size 4.9 GiB changed* by -720 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: dbd9c12 merge: c8bd835 diff diff %
ydbd size 5 261 264 592 Bytes 5 261 263 872 Bytes -720 Bytes -0.000%
ydbd stripped size 1 351 328 400 Bytes 1 351 335 152 Bytes +6.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the vdisk/huge-heap-supports-arbitrary-slots branch from 34b17c8 to 5b618a8 Compare November 19, 2024 10:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 10:35:42 UTC Pre-commit check linux-x86_64-release-asan for 28aae85 has started.
⚪ 2024-11-19 10:35:54 UTC Artifacts will be uploaded here
⚫ 2024-11-19 10:36:15 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/huge-heap-supports-arbitrary-slots branch from 5b618a8 to 3fb0e62 Compare November 19, 2024 10:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 10:37:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 67612b3 has started.
⚪ 2024-11-19 10:38:10 UTC Artifacts will be uploaded here
⚪ 2024-11-19 10:41:35 UTC ya make is running...
🟡 2024-11-19 11:45:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41850 36152 0 6 5567 125

⚪ 2024-11-19 11:48:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-19 11:59:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 26 0 0 1 108

🟢 2024-11-19 12:00:04 UTC Build successful.
🟢 2024-11-19 12:00:25 UTC ydbd size 2.5 GiB changed* by -15.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 481ccad merge: 67612b3 diff diff %
ydbd size 2 685 547 360 Bytes 2 685 531 360 Bytes -15.6 KiB -0.001%
ydbd stripped size 481 239 632 Bytes 481 237 200 Bytes -2.4 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 10:40:16 UTC Pre-commit check linux-x86_64-release-asan for 67612b3 has started.
⚪ 2024-11-19 10:40:27 UTC Artifacts will be uploaded here
⚪ 2024-11-19 10:43:55 UTC ya make is running...
🟡 2024-11-19 11:59:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10475 10390 0 30 8 47

🟢 2024-11-19 12:00:52 UTC Build successful.
🟢 2024-11-19 12:01:20 UTC ydbd size 4.9 GiB changed* by -10.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 481ccad merge: 67612b3 diff diff %
ydbd size 5 263 069 840 Bytes 5 263 058 640 Bytes -10.9 KiB -0.000%
ydbd stripped size 1 351 510 096 Bytes 1 351 511 920 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit 5876bb1 into ydb-platform:main Nov 20, 2024
10 checks passed
@alexvru alexvru deleted the vdisk/huge-heap-supports-arbitrary-slots branch November 20, 2024 08:50
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 21, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 21, 2024
Merged
@naspirato naspirato mentioned this pull request Nov 21, 2024
Open
@alexvru alexvru mentioned this pull request Nov 22, 2024
Merged
alexvru added a commit to alexvru/ydb that referenced this pull request Nov 22, 2024
@alexvru
Revert "Support arbitrary chain set in huge blob keeper heap (ydb-pla…
f437d65 
…tform#11566)"

This reverts commit 5876bb1.
naspirato pushed a commit that referenced this pull request Nov 22, 2024
@alexvru
Revert "Support arbitrary chain set in huge blob keeper heap (#11566)" (
f5beef5 
#11891)
alexvru added a commit to alexvru/ydb that referenced this pull request Nov 25, 2024
@alexvru
Revert "Revert "Support arbitrary chain set in huge blob keeper heap (y…
a88c2af 
…db-platform#11566)" (ydb-platform#11891)"

This reverts commit f5beef5.
alexvru added a commit to alexvru/ydb that referenced this pull request Nov 25, 2024
@alexvru
Revert "Revert "Support arbitrary chain set in huge blob keeper heap (y…
bcd60b7 
…db-platform#11566)" (ydb-platform#11891)"

This reverts commit f5beef5.
alexvru added a commit to alexvru/ydb that referenced this pull request Nov 25, 2024
@alexvru
Revert "Revert "Support arbitrary chain set in huge blob keeper heap (y…
91d8dad 
…db-platform#11566)" (ydb-platform#11891)"

This reverts commit f5beef5.
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
@alexvru @dahbka-lis
Revert "Support arbitrary chain set in huge blob keeper heap (ydb-pla…
8e6e920 
…tform#11566)" (ydb-platform#11891)
alexvru added a commit to alexvru/ydb that referenced this pull request Nov 25, 2024
@alexvru
Revert "Revert "Support arbitrary chain set in huge blob keeper heap (y…
6d6f78d 
…db-platform#11566)" (ydb-platform#11891)"

This reverts commit f5beef5.
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
@alexvru @dahbka-lis
Revert "Support arbitrary chain set in huge blob keeper heap (ydb-pla…
407102f 
…tform#11566)" (ydb-platform#11891)
This was referenced Nov 27, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@va-kuznecov va-kuznecov va-kuznecov approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvru @va-kuznecov