Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compaction memory prediction for special case #11565

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement
  • Performance improvement

Copy link

github-actions bot commented Nov 13, 2024

2024-11-13 12:45:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9903471 has started.
2024-11-13 12:45:59 UTC Artifacts will be uploaded here
2024-11-13 12:48:52 UTC ya make is running...
2024-11-13 12:49:34 UTC Check cancelled

Copy link

github-actions bot commented Nov 13, 2024

2024-11-13 12:46:10 UTC Pre-commit check linux-x86_64-release-asan for 9903471 has started.
2024-11-13 12:46:21 UTC Artifacts will be uploaded here
2024-11-13 12:49:28 UTC Check cancelled

Copy link

github-actions bot commented Nov 13, 2024

2024-11-13 12:51:13 UTC Pre-commit check linux-x86_64-release-asan for 48698b9 has started.
2024-11-13 12:51:57 UTC Artifacts will be uploaded here
2024-11-13 12:55:41 UTC ya make is running...
🟡 2024-11-13 14:04:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8935 8831 0 45 11 48

🟢 2024-11-13 14:04:52 UTC Build successful.
🟢 2024-11-13 14:05:28 UTC ydbd size 5.7 GiB changed* by +512 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 519686a merge: 48698b9 diff diff %
ydbd size 6 171 366 248 Bytes 6 171 366 760 Bytes +512 Bytes +0.000%
ydbd stripped size 1 538 165 264 Bytes 1 538 165 392 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 13, 2024

2024-11-13 12:51:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 48698b9 has started.
2024-11-13 12:51:39 UTC Artifacts will be uploaded here
2024-11-13 12:54:40 UTC ya make is running...
🟡 2024-11-13 13:43:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15129 13603 0 8 1405 113

2024-11-13 13:44:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-13 13:56:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 8 0 0 0 108

🟢 2024-11-13 13:56:39 UTC Build successful.
🟢 2024-11-13 13:57:00 UTC ydbd size 2.8 GiB changed* by +208 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 519686a merge: 48698b9 diff diff %
ydbd size 3 049 680 184 Bytes 3 049 680 392 Bytes +208 Bytes +0.000%
ydbd stripped size 482 435 680 Bytes 482 435 744 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 14, 2024 14:57
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 14, 2024 14:57
@ivanmorozov333 ivanmorozov333 merged commit f282430 into ydb-platform:main Nov 14, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_memory_prediction branch November 14, 2024 14:57
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants