YQ-3855 Add cookie to events RD <-> read_actor #11562
Conversation
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| template <class TEventPtr> | ||
| bool TRowDispatcher::CheckSession(TAtomicSharedPtr<ConsumerInfo>& consumer, const TEventPtr& ev) { | ||
| if (ev->Cookie != consumer->Generation) { |
There was a problem hiding this comment.
А тут прямо строгая проверка нужна, а не <= ?
There was a problem hiding this comment.
Да. Инициатором "соединения" является read_actor (и он увеличивает generation).
Если ev->Cookie < consumer->Generation - значит пришло старое сообщение.
Если ev->Cookie > consumer->Generation - такого не может быть (если только бага в коде / проигнорировали StartSession и т.п.). Можно assert добавить в этом случае.
There was a problem hiding this comment.
А при TEvStartSession добавлены особые проверки на эти Generation
There was a problem hiding this comment.
assert не нужно, так лучше)
Changelog entry
...
Changelog category
Additional information
...