Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix busy-wait in async compute actor #11507

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Nov 12, 2024

Aligns code with sync compute actor

Changelog entry

...

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

This code strangely mismatch with sync CA and apparently results in busy-wait in certain conditions.

Aligns code with sync compute actor
Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 09:00:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 85f5b61 has started.
2024-11-12 09:00:31 UTC Artifacts will be uploaded here
2024-11-12 09:03:34 UTC ya make is running...
🟡 2024-11-12 10:04:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74100 59982 0 10 13993 115

2024-11-12 10:11:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-12 10:23:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 10 0 0 1 110

🟢 2024-11-12 10:24:00 UTC Build successful.
🟢 2024-11-12 10:24:22 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7b36db5 merge: 85f5b61 diff diff %
ydbd size 3 049 975 776 Bytes 3 049 975 776 Bytes 0 Bytes 0.000%
ydbd stripped size 482 437 656 Bytes 482 437 656 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 12, 2024

2024-11-12 09:00:20 UTC Pre-commit check linux-x86_64-release-asan for 85f5b61 has started.
2024-11-12 09:00:30 UTC Artifacts will be uploaded here
2024-11-12 09:03:34 UTC ya make is running...
🟡 2024-11-12 10:08:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9442 9339 0 34 22 47

🟢 2024-11-12 10:09:09 UTC Build successful.
🟢 2024-11-12 10:09:42 UTC ydbd size 5.7 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7b36db5 merge: 85f5b61 diff diff %
ydbd size 6 172 064 968 Bytes 6 172 064 936 Bytes -32 Bytes -0.000%
ydbd stripped size 1 538 284 624 Bytes 1 538 284 624 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review November 12, 2024 11:42
@yumkam yumkam requested review from a team as code owners November 12, 2024 11:42
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 12, 2024
@yumkam yumkam changed the title [WIP] [RFC] Fix busy-wait in async compute actor Fix busy-wait in async compute actor Nov 12, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 12, 2024
@yumkam yumkam merged commit 75b75e9 into ydb-platform:main Nov 12, 2024
13 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants