Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 add switch for virtual style addressing #1150

Merged

Conversation

Enjection
Copy link
Member

  • add s3 virtual addressing switch support

Changelog entry

Add support for switching s3 path layout in export/import operations

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Jan 19, 2024

2024-01-22 11:15:27 UTC Pre-commit check for 97560df has started.
2024-01-22 11:15:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-22 11:54:28 UTC Build successful.
2024-01-22 11:54:41 UTC Tests are running...
🔴 2024-01-22 13:31:57 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59992 50749 0 4 9228 11

Copy link

github-actions bot commented Jan 19, 2024

2024-01-22 11:15:08 UTC Pre-commit check for 97560df has started.
2024-01-22 11:15:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-22 11:56:47 UTC Build successful.
2024-01-22 11:57:01 UTC Tests are running...
🔴 2024-01-22 13:37:39 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15889 15802 0 20 47 20

fomichev3000
fomichev3000 previously approved these changes Jan 22, 2024
Copy link
Member

@fomichev3000 fomichev3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add comments to public protobuf with the description/link to explanation what S3 virtual host addressing is.

@Enjection Enjection merged commit 7fd3a1f into main Jan 22, 2024
3 of 5 checks passed
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
@vitstn vitstn mentioned this pull request Jan 29, 2024
@alexv-smirnov alexv-smirnov deleted the feature/KIKIMR-20813/support-s3-virtual-style-addressing branch February 6, 2024 10:47
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants