Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove confusing timeout macro #11431

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

uzhastik
Copy link
Collaborator

@uzhastik uzhastik commented Nov 8, 2024

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

by default test timeout equals to maximum timeout value for specified test size:
small - 60
medium - 600
large - 3600

timeout macro could be used to make timeout lower, but not bigger
to avoid misunderstanding and simplify ya.make files we suggest to remove timeout macro or use it explicitly to make timeout less than maximum

Copy link

github-actions bot commented Nov 8, 2024

2024-11-08 20:32:58 UTC Pre-commit check linux-x86_64-release-asan for fc3b90c has started.
2024-11-08 20:33:09 UTC Artifacts will be uploaded here
2024-11-08 20:36:14 UTC ya make is running...
🟡 2024-11-08 21:36:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11432 11369 0 22 11 30

🟢 2024-11-08 21:37:55 UTC Build successful.
🟢 2024-11-08 21:38:23 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3c5b82e merge: fc3b90c diff diff %
ydbd size 6 165 750 184 Bytes 6 165 750 088 Bytes -96 Bytes -0.000%
ydbd stripped size 1 537 477 872 Bytes 1 537 477 808 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 8, 2024

2024-11-08 20:33:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc3b90c has started.
2024-11-08 20:33:14 UTC Artifacts will be uploaded here
2024-11-08 20:36:17 UTC ya make is running...
🟡 2024-11-08 21:29:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69379 55474 0 3 13803 99

2024-11-08 21:36:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-08 21:47:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 8 0 0 0 94

🟢 2024-11-08 21:47:14 UTC Build successful.
🟢 2024-11-08 21:47:31 UTC ydbd size 2.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3c5b82e merge: fc3b90c diff diff %
ydbd size 3 046 706 072 Bytes 3 046 706 072 Bytes 0 Bytes 0.000%
ydbd stripped size 482 218 136 Bytes 482 218 136 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:57:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 19e0a81 has started.
2024-11-28 11:57:23 UTC Artifacts will be uploaded here
2024-11-28 12:00:30 UTC ya make is running...
2024-11-28 12:01:02 UTC Check cancelled

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 11:57:13 UTC Pre-commit check linux-x86_64-release-asan for 19e0a81 has started.
2024-11-28 11:57:26 UTC Artifacts will be uploaded here
2024-11-28 12:00:29 UTC ya make is running...
2024-11-28 12:01:02 UTC Check cancelled

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 12:02:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for f12f156 has started.
2024-11-28 12:02:29 UTC Artifacts will be uploaded here
2024-11-28 12:05:22 UTC ya make is running...
🟢 2024-11-28 12:51:07 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17338 17201 0 0 27 110

🟢 2024-11-28 12:52:31 UTC Build successful.
🟢 2024-11-28 12:52:49 UTC ydbd size 2.5 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a02f6d5 merge: f12f156 diff diff %
ydbd size 2 695 027 736 Bytes 2 695 027 736 Bytes 0 Bytes 0.000%
ydbd stripped size 482 195 312 Bytes 482 195 312 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 28, 2024

2024-11-28 12:02:41 UTC Pre-commit check linux-x86_64-release-asan for f12f156 has started.
2024-11-28 12:03:21 UTC Artifacts will be uploaded here
2024-11-28 12:06:46 UTC ya make is running...
🟡 2024-11-28 13:03:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13739 13683 0 13 1 42

🟢 2024-11-28 13:04:35 UTC Build successful.
🟢 2024-11-28 13:05:04 UTC ydbd size 4.9 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a02f6d5 merge: f12f156 diff diff %
ydbd size 5 294 884 792 Bytes 5 294 884 696 Bytes -96 Bytes -0.000%
ydbd stripped size 1 361 164 464 Bytes 1 361 164 400 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@uzhastik uzhastik marked this pull request as ready for review November 28, 2024 17:58
@uzhastik uzhastik requested review from a team as code owners November 28, 2024 17:58
@uzhastik uzhastik requested a review from niksaveliev November 28, 2024 17:58
@uzhastik uzhastik enabled auto-merge (squash) November 29, 2024 12:29
@uzhastik uzhastik merged commit 991917c into ydb-platform:main Nov 29, 2024
10 checks passed
@uzhastik uzhastik deleted the no_timeout branch November 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.