add tiering info to TTL in public api #11390
Conversation
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
0e3b7a2 to
4365df4
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
0cfa3a7 to
15c255a
Compare
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
b918b90 to
035c779
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| message DateTypeColumnModeSettings { | ||
| // The row will be considered as expired at the moment of time, when the value | ||
| // The row will be assigned a tier at the moment of time, when the value |
There was a problem hiding this comment.
Какое отношение tier имеет к TTL у строковых таблиц?
There was a problem hiding this comment.
В строковых таблиц планируется поддержать тиринг и тогда он будет описываться так же, как и для колоночных — через TTL
|
|
||
| static std::optional<TTtlSettings> DeserializeFromProto(const Ydb::Table::TtlSettings& proto); |
| , Action_(action) { | ||
| } |
There was a problem hiding this comment.
Не надо смешивать разные стили в одном файле. В этом файле так:
ctor::ctor()
: field1()
, field2()
{| return TTtlSettings(TValueSinceUnixEpochModeSettings(proto.value_since_unix_epoch_v1().column_name(), TProtoAccessor::FromProto(proto.value_since_unix_epoch_v1().column_unit()), legacyExpireAfter), proto.run_interval_seconds()); | ||
| case Ydb::Table::TtlSettings::MODE_NOT_SET: | ||
| return std::nullopt; | ||
| break; |
| return std::nullopt; | ||
| } | ||
|
|
||
| TTtlSettings::TTtlSettings(TMode mode, ui32 runIntervalSeconds) : Mode_(std::move(mode)), RunInterval_(TDuration::Seconds(runIntervalSeconds)) {} |
There was a problem hiding this comment.
В этом файле ты одинаковые конструкции написал тремя разными способами. Приведи к единому стилю (см. мой комментарий выше).
Conflicts: ydb/core/tx/schemeshard/common/validation.h ydb/core/tx/schemeshard/schemeshard_info_types.h ydb/core/ydb_convert/ya.make
Conflicts: ydb/core/tx/schemeshard/common/validation.h ydb/core/tx/schemeshard/schemeshard_info_types.h ydb/core/ydb_convert/ya.make
Conflicts: ydb/core/tx/schemeshard/common/validation.h ydb/core/tx/schemeshard/schemeshard_info_types.h ydb/core/ydb_convert/ya.make
Conflicts: ydb/core/tx/schemeshard/common/validation.h ydb/core/tx/schemeshard/schemeshard_info_types.h ydb/core/ydb_convert/ya.make
rfc: https://nda.ya.ru/t/1qKzgJO979aMVR
В схему конфигурации TTL в public grpc api и flat_scheme_op.proto добавлены тиры, и значение expire_after_seconds сделано опциональным.