Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure nodes manually set as Up do not revert to Down #11349

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

ensure nodes manually set as Up do not revert to Down

Changelog category

  • Bugfix

Additional information

A manual setting must override Hive internal decisions - so it should reset the BecomeUpOnRestart flag, both in case of manual Down, and manual Up.

Copy link

github-actions bot commented Nov 7, 2024

2024-11-07 08:48:01 UTC Pre-commit check linux-x86_64-release-asan for ab9bef9 has started.
2024-11-07 08:48:12 UTC Artifacts will be uploaded here
2024-11-07 08:51:11 UTC ya make is running...
🟡 2024-11-07 10:01:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9258 9183 0 31 11 33

🟢 2024-11-07 10:02:01 UTC Build successful.
🟢 2024-11-07 10:02:33 UTC ydbd size 5.7 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 608b142 merge: ab9bef9 diff diff %
ydbd size 6 162 289 232 Bytes 6 162 297 112 Bytes +7.7 KiB +0.000%
ydbd stripped size 1 536 569 456 Bytes 1 536 571 024 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 7, 2024

2024-11-07 08:48:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for ab9bef9 has started.
2024-11-07 08:48:11 UTC Artifacts will be uploaded here
2024-11-07 08:51:10 UTC ya make is running...
🟡 2024-11-07 09:37:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15330 13819 0 3 1405 103

2024-11-07 09:38:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-07 09:50:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 9 0 0 0 96

🟢 2024-11-07 09:50:13 UTC Build successful.
🟢 2024-11-07 09:50:34 UTC ydbd size 2.8 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 608b142 merge: ab9bef9 diff diff %
ydbd size 3 045 154 816 Bytes 3 045 157 144 Bytes +2.3 KiB +0.000%
ydbd stripped size 481 969 464 Bytes 481 970 040 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke merged commit 7b36db5 into ydb-platform:main Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hive developer UI: make check/cross button behaviour match expectations with Drain
2 participants