Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce snapshot_ro isolation level (#11085) #11252

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ssmike
Copy link
Collaborator

@ssmike ssmike commented Nov 5, 2024

Changelog entry

Don't take locks in SnapshotRO

Changelog category

  • Performance improvement

@ssmike ssmike requested a review from a team as a code owner November 5, 2024 07:40
Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 07:42:08 UTC Pre-commit check for b7ab80a has started.
2024-11-05 07:45:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-05 08:48:31 UTC Build successful.
2024-11-05 08:48:47 UTC Tests are running...
🔴 2024-11-05 10:38:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40285 35008 0 16 5219 42

🟢 2024-11-05 10:39:17 UTC ydbd size 8.2 GiB changed* by +208 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 66baaeb merge: b7ab80a diff diff %
ydbd size 8 856 905 680 Bytes 8 856 905 888 Bytes +208 Bytes +0.000%
ydbd stripped size 483 653 544 Bytes 483 653 608 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 07:44:11 UTC Pre-commit check for b7ab80a has started.
2024-11-05 07:47:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-05 08:27:42 UTC Build successful.

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 07:44:36 UTC Pre-commit check for b7ab80a has started.
2024-11-05 07:47:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-05 08:31:02 UTC Build successful.
2024-11-05 08:31:22 UTC Tests are running...
🔴 2024-11-05 10:42:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11726 11632 0 19 29 46

🟢 2024-11-05 10:43:05 UTC ydbd size 5.6 GiB changed* by +16 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 66baaeb merge: b7ab80a diff diff %
ydbd size 5 990 435 688 Bytes 5 990 435 704 Bytes +16 Bytes +0.000%
ydbd stripped size 1 501 492 352 Bytes 1 501 492 288 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ssmike ssmike enabled auto-merge (squash) November 5, 2024 09:10
@ssmike ssmike merged commit 05747b7 into ydb-platform:stable-24-3 Nov 5, 2024
8 of 12 checks passed
@ssmike ssmike deleted the merge-snapshot-ro branch November 7, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants