Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count ToFlow children twice & print BlockCombineHashed as Aggregation #11245

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Nov 4, 2024

No description provided.

@Hor911 Hor911 requested a review from pashandor789 November 4, 2024 13:34
Copy link

github-actions bot commented Nov 4, 2024

2024-11-04 13:38:25 UTC Pre-commit check linux-x86_64-release-asan for 9976d44 has started.
2024-11-04 13:38:36 UTC Artifacts will be uploaded here
2024-11-04 13:41:39 UTC ya make is running...
🟡 2024-11-04 14:50:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9185 9112 0 29 12 32

🟢 2024-11-04 14:51:37 UTC Build successful.
🟡 2024-11-04 14:52:07 UTC ydbd size 5.7 GiB changed* by +115.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f12f073 merge: 9976d44 diff diff %
ydbd size 6 147 342 800 Bytes 6 147 461 328 Bytes +115.8 KiB +0.002%
ydbd stripped size 1 534 493 616 Bytes 1 534 520 880 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 4, 2024

2024-11-04 13:40:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9976d44 has started.
2024-11-04 13:40:28 UTC Artifacts will be uploaded here
2024-11-04 13:43:35 UTC ya make is running...
🟡 2024-11-04 14:31:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15071 13565 0 7 1404 95

2024-11-04 14:33:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-04 14:44:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 3 0 5 1 93

2024-11-04 14:44:37 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-04 14:55:52 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 0 0 5 0 93

🟢 2024-11-04 14:55:59 UTC Build successful.
🟢 2024-11-04 14:56:21 UTC ydbd size 2.8 GiB changed* by +44.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f12f073 merge: 9976d44 diff diff %
ydbd size 3 038 072 456 Bytes 3 038 117 744 Bytes +44.2 KiB +0.001%
ydbd stripped size 481 429 176 Bytes 481 434 872 Bytes +5.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

pashandor789
pashandor789 previously approved these changes Nov 4, 2024
@Hor911 Hor911 changed the title Don't count ToFlow children twice & print BlockCombineHashed as Aggregate Don't count ToFlow children twice & print BlockCombineHashed as Aggregation Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

2024-11-04 16:24:53 UTC Pre-commit check linux-x86_64-release-asan for 8b7dbff has started.
2024-11-04 16:25:05 UTC Artifacts will be uploaded here
2024-11-04 16:28:10 UTC ya make is running...
🟡 2024-11-04 17:37:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9190 9096 0 47 10 37

🟢 2024-11-04 17:38:08 UTC Build successful.
🟡 2024-11-04 17:38:41 UTC ydbd size 5.7 GiB changed* by +135.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f12f073 merge: 8b7dbff diff diff %
ydbd size 6 147 342 800 Bytes 6 147 481 760 Bytes +135.7 KiB +0.002%
ydbd stripped size 1 534 493 616 Bytes 1 534 522 416 Bytes +28.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 4, 2024

2024-11-04 16:25:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8b7dbff has started.
2024-11-04 16:26:01 UTC Artifacts will be uploaded here
2024-11-04 16:29:00 UTC ya make is running...
🟡 2024-11-04 17:16:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15070 13564 0 2 1404 100

2024-11-04 17:17:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-04 17:32:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 8 0 0 0 94

🟢 2024-11-04 17:33:03 UTC Build successful.
🟢 2024-11-04 17:33:23 UTC ydbd size 2.8 GiB changed* by +52.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f12f073 merge: 8b7dbff diff diff %
ydbd size 3 038 072 456 Bytes 3 038 125 856 Bytes +52.1 KiB +0.002%
ydbd stripped size 481 429 176 Bytes 481 435 256 Bytes +5.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 merged commit 373467c into ydb-platform:main Nov 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants