Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excessive atomicity from IC #11027

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Oct 29, 2024

Changelog entry

Remove excessive atomicity from IC

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Atomic variables were removed as they are obsolete now.

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 07:18:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 880b054 has started.
2024-10-29 07:18:58 UTC Artifacts will be uploaded here
2024-10-29 07:22:04 UTC ya make is running...
🟡 2024-10-29 08:25:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75295 61240 0 1 13953 101

2024-10-29 08:32:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-29 08:43:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
102 (only retried tests) 7 0 1 0 94

2024-10-29 08:44:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-29 08:55:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 2 0 0 0 93

🟢 2024-10-29 08:55:32 UTC Build successful.
🟢 2024-10-29 08:55:54 UTC ydbd size 2.8 GiB changed* by -4.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 903c6b6 merge: 880b054 diff diff %
ydbd size 3 033 922 776 Bytes 3 033 918 728 Bytes -4.0 KiB -0.000%
ydbd stripped size 480 682 264 Bytes 480 681 816 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 07:18:57 UTC Pre-commit check linux-x86_64-release-asan for 880b054 has started.
2024-10-29 07:19:08 UTC Artifacts will be uploaded here
2024-10-29 07:22:13 UTC ya make is running...
🟡 2024-10-29 08:36:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11305 11064 0 54 86 101

🟢 2024-10-29 08:37:12 UTC Build successful.
🟢 2024-10-29 08:37:48 UTC ydbd size 5.7 GiB changed* by -9.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 903c6b6 merge: 880b054 diff diff %
ydbd size 6 139 714 808 Bytes 6 139 704 736 Bytes -9.8 KiB -0.000%
ydbd stripped size 1 532 099 056 Bytes 1 532 098 160 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) October 29, 2024 09:46
@alexvru alexvru merged commit 43363e5 into ydb-platform:main Oct 29, 2024
11 checks passed
@alexvru alexvru deleted the interconnect/remove-excessive-atomicity branch October 29, 2024 09:48
This was referenced Nov 1, 2024
@alexvru alexvru self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants