Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider free slots count in BSC during group allocation #11008

Merged

Conversation

va-kuznecov
Copy link
Member

Changelog entry

Use -FreeSlots() as PickerScore in BSC to properly populate disks of unequal size

Changelog category

  • Improvement

Additional information

...

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 14:53:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 957660d has started.
2024-10-28 14:55:52 UTC Artifacts will be uploaded here
2024-10-28 14:59:27 UTC ya make is running...
🟡 2024-10-28 15:44:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15285 13699 0 4 1482 100

2024-10-28 15:45:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-28 15:54:53 UTC ydbd size 2.8 GiB changed* by +576 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d4eaec4 merge: 957660d diff diff %
ydbd size 3 033 914 584 Bytes 3 033 915 160 Bytes +576 Bytes +0.000%
ydbd stripped size 480 680 664 Bytes 480 680 728 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-28 15:54:55 UTC Check cancelled

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 14:53:26 UTC Pre-commit check linux-x86_64-release-asan for 957660d has started.
2024-10-28 14:55:17 UTC Artifacts will be uploaded here
2024-10-28 14:59:02 UTC ya make is running...
2024-10-28 15:54:39 UTC Check cancelled

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 15:57:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 13ccd2a has started.
2024-10-28 15:57:57 UTC Artifacts will be uploaded here
2024-10-28 16:00:57 UTC ya make is running...
🟡 2024-10-28 16:47:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15282 13780 0 10 1394 98

2024-10-28 16:49:04 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-28 17:00:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 14 0 0 0 93

🟢 2024-10-28 17:00:48 UTC Build successful.
🟢 2024-10-28 17:01:08 UTC ydbd size 2.8 GiB changed* by +1.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d4eaec4 merge: 13ccd2a diff diff %
ydbd size 3 033 914 584 Bytes 3 033 916 184 Bytes +1.6 KiB +0.000%
ydbd stripped size 480 680 664 Bytes 480 680 920 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 15:57:52 UTC Pre-commit check linux-x86_64-release-asan for 13ccd2a has started.
2024-10-28 15:58:02 UTC Artifacts will be uploaded here
2024-10-28 16:01:00 UTC ya make is running...
🟡 2024-10-28 17:17:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9483 9273 0 75 35 100

🟢 2024-10-28 17:17:59 UTC Build successful.
🟢 2024-10-28 17:18:32 UTC ydbd size 5.7 GiB changed* by +672 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d4eaec4 merge: 13ccd2a diff diff %
ydbd size 6 139 704 984 Bytes 6 139 705 656 Bytes +672 Bytes +0.000%
ydbd stripped size 1 532 094 704 Bytes 1 532 094 000 Bytes -704 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexvru
alexvru previously approved these changes Oct 28, 2024
@va-kuznecov va-kuznecov marked this pull request as ready for review October 28, 2024 18:14
Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 18:15:24 UTC Pre-commit check linux-x86_64-release-asan for 7c24fea has started.
2024-10-28 18:15:34 UTC Artifacts will be uploaded here
2024-10-28 18:18:32 UTC ya make is running...
🟡 2024-10-28 19:32:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9467 9229 0 82 54 102

🟢 2024-10-28 19:33:39 UTC Build successful.
🟢 2024-10-28 19:34:15 UTC ydbd size 5.7 GiB changed* by -760 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 634dc20 merge: 7c24fea diff diff %
ydbd size 6 139 711 072 Bytes 6 139 710 312 Bytes -760 Bytes -0.000%
ydbd stripped size 1 532 097 520 Bytes 1 532 097 136 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 18:17:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c24fea has started.
2024-10-28 18:17:58 UTC Artifacts will be uploaded here
2024-10-28 18:20:55 UTC ya make is running...
🟢 2024-10-28 19:05:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15282 13790 0 0 1394 98

🟢 2024-10-28 19:07:10 UTC Build successful.
🟢 2024-10-28 19:07:25 UTC ydbd size 2.8 GiB changed* by +1.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 634dc20 merge: 7c24fea diff diff %
ydbd size 3 033 916 896 Bytes 3 033 918 232 Bytes +1.3 KiB +0.000%
ydbd stripped size 480 681 240 Bytes 480 681 752 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov merged commit 012816b into ydb-platform:main Oct 29, 2024
10 checks passed
@va-kuznecov va-kuznecov deleted the dev/consider_free_slots_in_bsc branch October 29, 2024 11:16
This was referenced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants