Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix abort on invalid null value parsing in BinaryJson #10991

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

swalrus1
Copy link
Collaborator

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 11:56:39 UTC Pre-commit check linux-x86_64-release-asan for 4576fb4 has started.
2024-10-28 11:57:10 UTC Artifacts will be uploaded here
2024-10-28 12:00:26 UTC ya make is running...
2024-10-28 12:09:27 UTC Check cancelled

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 11:57:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4576fb4 has started.
2024-10-28 11:57:23 UTC Artifacts will be uploaded here
2024-10-28 12:00:30 UTC ya make is running...
2024-10-28 12:09:20 UTC Check cancelled

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 12:12:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3b1b951 has started.
2024-10-28 12:12:43 UTC Artifacts will be uploaded here
2024-10-28 12:15:49 UTC ya make is running...
🟡 2024-10-28 13:43:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79244 65190 0 3 13953 98

2024-10-28 13:50:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-28 14:02:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 8 0 0 0 93

🟢 2024-10-28 14:02:48 UTC Build successful.
🟢 2024-10-28 14:03:06 UTC ydbd size 2.8 GiB changed* by -176 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f752bc1 merge: 3b1b951 diff diff %
ydbd size 3 033 679 416 Bytes 3 033 679 240 Bytes -176 Bytes -0.000%
ydbd stripped size 480 648 664 Bytes 480 648 536 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 28, 2024

2024-10-28 12:13:44 UTC Pre-commit check linux-x86_64-release-asan for 3b1b951 has started.
2024-10-28 12:13:55 UTC Artifacts will be uploaded here
2024-10-28 12:17:09 UTC ya make is running...
🟡 2024-10-28 13:57:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15482 15284 0 48 51 99

🟢 2024-10-28 13:58:35 UTC Build successful.
🟢 2024-10-28 13:59:08 UTC ydbd size 5.7 GiB changed* by -104 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f752bc1 merge: 3b1b951 diff diff %
ydbd size 6 139 270 880 Bytes 6 139 270 776 Bytes -104 Bytes -0.000%
ydbd stripped size 1 531 999 984 Bytes 1 531 999 536 Bytes -448 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 enabled auto-merge (squash) October 28, 2024 12:30
@swalrus1 swalrus1 merged commit a0b88ca into ydb-platform:main Oct 28, 2024
10 checks passed
@swalrus1 swalrus1 deleted the fix-json-null branch October 28, 2024 16:18
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants