Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in progress bar working with import benchmarks #10939

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

iddqdex
Copy link
Collaborator

@iddqdex iddqdex commented Oct 25, 2024

Fixed two bugs:

  • Sometimes line with full progressbar duplicates.
  • Size of tables in progressbar reduced when not empty state used.

Now it works fine.

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 15:20:01 UTC Pre-commit check linux-x86_64-release-asan for dea7e8f has started.
2024-10-25 15:20:43 UTC Artifacts will be uploaded here
2024-10-25 15:24:21 UTC ya make is running...
2024-10-25 15:29:31 UTC Check cancelled

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 15:21:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for dea7e8f has started.
2024-10-25 15:21:18 UTC Artifacts will be uploaded here
2024-10-25 15:24:26 UTC ya make is running...
2024-10-25 15:29:36 UTC Check cancelled

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 15:31:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for c430215 has started.
2024-10-25 15:31:56 UTC Artifacts will be uploaded here
2024-10-25 15:35:36 UTC ya make is running...
🟡 2024-10-25 16:21:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14929 13433 0 2 1394 100

2024-10-25 16:23:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-25 16:34:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 7 0 0 0 94

🟢 2024-10-25 16:34:55 UTC Build successful.
🟢 2024-10-25 16:35:15 UTC ydbd size 2.8 GiB changed* by +7.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bb8be1a merge: c430215 diff diff %
ydbd size 3 032 827 456 Bytes 3 032 835 024 Bytes +7.4 KiB +0.000%
ydbd stripped size 480 532 888 Bytes 480 534 200 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 15:33:47 UTC Pre-commit check linux-x86_64-release-asan for c430215 has started.
2024-10-25 15:33:59 UTC Artifacts will be uploaded here
2024-10-25 15:37:07 UTC ya make is running...
🟡 2024-10-25 16:49:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9950 9764 0 46 38 102

🟢 2024-10-25 16:50:50 UTC Build successful.
🟢 2024-10-25 16:51:23 UTC ydbd size 5.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7108e37 merge: c430215 diff diff %
ydbd size 6 137 499 888 Bytes 6 137 499 792 Bytes -96 Bytes -0.000%
ydbd stripped size 1 531 568 144 Bytes 1 531 568 080 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@iddqdex iddqdex enabled auto-merge (squash) October 25, 2024 15:41
@iddqdex iddqdex merged commit 3a89b73 into ydb-platform:main Oct 25, 2024
10 checks passed
@iddqdex iddqdex deleted the fix-progress-bar branch October 25, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants