Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove schema from table version #10878

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 07:25:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for f5bf7f7 has started.
2024-10-25 07:26:05 UTC Artifacts will be uploaded here
2024-10-25 07:29:39 UTC ya make is running...
🔴 2024-10-25 07:51:10 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 07:26:07 UTC Pre-commit check linux-x86_64-release-asan for f5bf7f7 has started.
2024-10-25 07:26:18 UTC Artifacts will be uploaded here
2024-10-25 07:29:41 UTC ya make is running...
🔴 2024-10-25 07:53:22 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 10:44:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 626c8e3 has started.
2024-10-25 10:44:44 UTC Artifacts will be uploaded here
2024-10-25 10:48:01 UTC ya make is running...
🟢 2024-10-25 12:06:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41610 35972 0 0 5539 99

🟢 2024-10-25 12:10:33 UTC Build successful.
🟢 2024-10-25 12:10:54 UTC ydbd size 2.8 GiB changed* by +43.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 86223ca merge: 626c8e3 diff diff %
ydbd size 3 032 571 856 Bytes 3 032 615 888 Bytes +43.0 KiB +0.001%
ydbd stripped size 480 494 808 Bytes 480 499 416 Bytes +4.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 10:44:42 UTC Pre-commit check linux-x86_64-release-asan for 626c8e3 has started.
2024-10-25 10:44:54 UTC Artifacts will be uploaded here
2024-10-25 10:48:24 UTC ya make is running...
🟡 2024-10-25 12:34:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11586 11345 0 70 67 104

🟢 2024-10-25 12:35:12 UTC Build successful.
🟢 2024-10-25 12:35:45 UTC ydbd size 5.7 GiB changed* by +86.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 86223ca merge: 626c8e3 diff diff %
ydbd size 6 136 872 480 Bytes 6 136 960 952 Bytes +86.4 KiB +0.001%
ydbd stripped size 1 531 420 816 Bytes 1 531 440 464 Bytes +19.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review October 25, 2024 14:56
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner October 25, 2024 14:56
@@ -249,7 +249,6 @@ message TTableVersionInfo {
optional uint64 PathId = 1;
optional uint64 SinceStep = 2;
optional uint64 SinceTxId = 3;
optional NKikimrSchemeOp.TColumnTableSchema Schema = 4;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep this line and comment it

@ivanmorozov333 ivanmorozov333 merged commit fe19569 into ydb-platform:main Oct 26, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the clean_useless_store_data branch October 26, 2024 09:01
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants