Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-insensitive mode for searching modules and functions #10842

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Oct 24, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner October 24, 2024 12:56
@vitstn vitstn added the area/yql YQL query language issues label Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 13:02:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4c9c78d has started.
2024-10-24 13:02:39 UTC Artifacts will be uploaded here
2024-10-24 13:05:50 UTC ya make is running...
🔴 2024-10-24 13:08:38 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 13:02:57 UTC Pre-commit check linux-x86_64-release-asan for 4c9c78d has started.
2024-10-24 13:03:09 UTC Artifacts will be uploaded here
2024-10-24 13:06:24 UTC ya make is running...
🔴 2024-10-24 13:12:09 UTC Build failed, see the logs. Also see fail summary

rvu1024
rvu1024 previously approved these changes Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 13:56:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7eb5f38 has started.
2024-10-24 13:57:08 UTC Artifacts will be uploaded here
2024-10-24 13:58:06 UTC Check cancelled

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 13:56:33 UTC Pre-commit check linux-x86_64-release-asan for 7eb5f38 has started.
2024-10-24 13:57:11 UTC Artifacts will be uploaded here
2024-10-24 13:58:06 UTC Check cancelled

rvu1024
rvu1024 previously approved these changes Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 13:59:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c43f76 has started.
2024-10-24 13:59:54 UTC Artifacts will be uploaded here
2024-10-24 14:03:22 UTC ya make is running...
🟡 2024-10-24 15:21:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77852 63813 0 3 13942 94

2024-10-24 15:28:41 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-24 15:40:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 2 0 3 0 91

2024-10-24 15:40:09 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-24 15:43:30 UTC ydbd size 2.8 GiB changed* by +60.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d1a9c41 merge: 5c43f76 diff diff %
ydbd size 3 033 798 008 Bytes 3 033 860 024 Bytes +60.6 KiB +0.002%
ydbd stripped size 481 115 448 Bytes 481 121 976 Bytes +6.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-24 15:43:32 UTC Check cancelled

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 13:59:44 UTC Pre-commit check linux-x86_64-release-asan for 5c43f76 has started.
2024-10-24 13:59:55 UTC Artifacts will be uploaded here
2024-10-24 14:03:18 UTC ya make is running...
🟡 2024-10-24 15:38:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14623 14395 0 62 67 99

🟢 2024-10-24 15:40:01 UTC Build successful.
🟡 2024-10-24 15:40:39 UTC ydbd size 5.7 GiB changed* by +216.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: d1a9c41 merge: 5c43f76 diff diff %
ydbd size 6 138 837 936 Bytes 6 139 059 264 Bytes +216.1 KiB +0.004%
ydbd stripped size 1 532 382 768 Bytes 1 532 414 096 Bytes +30.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

rvu1024
rvu1024 previously approved these changes Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 15:45:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 66005d2 has started.
2024-10-24 15:46:06 UTC Artifacts will be uploaded here
2024-10-24 15:49:31 UTC ya make is running...
2024-10-24 16:23:32 UTC Check cancelled

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 15:46:02 UTC Pre-commit check linux-x86_64-release-asan for 66005d2 has started.
2024-10-24 15:46:12 UTC Artifacts will be uploaded here
2024-10-24 15:49:27 UTC ya make is running...
2024-10-24 16:23:30 UTC Check cancelled

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 16:25:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1d448cd has started.
2024-10-24 16:25:23 UTC Artifacts will be uploaded here
2024-10-24 16:28:34 UTC ya make is running...
🟡 2024-10-24 17:36:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77852 63812 0 2 13942 96

2024-10-24 17:43:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-24 17:55:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 4 0 2 0 91

2024-10-24 17:55:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-24 18:06:40 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
93 (only retried tests) 0 0 2 0 91

🟢 2024-10-24 18:06:47 UTC Build successful.
🟢 2024-10-24 18:07:08 UTC ydbd size 2.8 GiB changed* by +63.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2878186 merge: 1d448cd diff diff %
ydbd size 3 033 845 960 Bytes 3 033 910 672 Bytes +63.2 KiB +0.002%
ydbd stripped size 481 121 656 Bytes 481 128 696 Bytes +6.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 16:25:15 UTC Pre-commit check linux-x86_64-release-asan for 1d448cd has started.
2024-10-24 16:25:32 UTC Artifacts will be uploaded here
2024-10-24 16:28:54 UTC ya make is running...
🟡 2024-10-24 17:49:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14615 14412 0 56 52 95

🟢 2024-10-24 17:50:23 UTC Build successful.
🟡 2024-10-24 17:51:00 UTC ydbd size 5.7 GiB changed* by +224.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2878186 merge: 1d448cd diff diff %
ydbd size 6 138 954 976 Bytes 6 139 184 920 Bytes +224.6 KiB +0.004%
ydbd stripped size 1 532 404 272 Bytes 1 532 433 360 Bytes +28.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 10:15:14 UTC Pre-commit check linux-x86_64-release-asan for 0c8bf82 has started.
2024-10-25 10:15:25 UTC Artifacts will be uploaded here
2024-10-25 10:18:35 UTC ya make is running...
🟡 2024-10-25 11:44:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14610 14415 0 40 53 102

🟢 2024-10-25 11:45:50 UTC Build successful.
🟡 2024-10-25 11:46:26 UTC ydbd size 5.7 GiB changed* by +232.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 827cf58 merge: 0c8bf82 diff diff %
ydbd size 6 136 322 664 Bytes 6 136 560 800 Bytes +232.6 KiB +0.004%
ydbd stripped size 1 531 323 952 Bytes 1 531 361 232 Bytes +36.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 25, 2024

2024-10-25 10:17:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0c8bf82 has started.
2024-10-25 10:17:53 UTC Artifacts will be uploaded here
2024-10-25 10:21:07 UTC ya make is running...
🟢 2024-10-25 11:32:40 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77871 63820 0 0 13954 97

🟢 2024-10-25 11:40:11 UTC Build successful.
🟢 2024-10-25 11:40:30 UTC ydbd size 2.8 GiB changed* by +63.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 827cf58 merge: 0c8bf82 diff diff %
ydbd size 3 032 293 992 Bytes 3 032 358 704 Bytes +63.2 KiB +0.002%
ydbd stripped size 480 463 768 Bytes 480 470 808 Bytes +6.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn requested a review from rvu1024 October 25, 2024 11:17
@vitstn vitstn enabled auto-merge (squash) October 25, 2024 11:37
@vitstn vitstn merged commit a9058c8 into ydb-platform:main Oct 25, 2024
10 checks passed
@vitstn vitstn deleted the case_insensitive_udf branch October 25, 2024 11:46
public:
TUdfIndex();
bool ContainsModule(const TString& moduleName) const;
bool FindFunction(const TString& moduleName, const TString& functionName, TFunctionInfo& function) const;
void SetCaseSentiveSearch(bool caseSensitive);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут опечатка в имени метода

robot-piglet pushed a commit that referenced this pull request Nov 12, 2024
Apply GH: Extract prefix and entries in backup-related sql (#10807)

Apply GH: Fix syntax for Column Family (#10781)

Apply GH: Case-insensitive mode for searching modules and functions (#10842)

Apply GH: Fixed i/o for pg_proc (#10914)

Apply GH: An option to render SQL transalation with Seq! (#11015)
commit_hash:d2d2fcdef2bbd0434236aef325aa071c7e39c526
maximyurchuk pushed a commit that referenced this pull request Nov 12, 2024
Apply GH: Extract prefix and entries in backup-related sql (#10807)

Apply GH: Fix syntax for Column Family (#10781)

Apply GH: Case-insensitive mode for searching modules and functions (#10842)

Apply GH: Fixed i/o for pg_proc (#10914)

Apply GH: An option to render SQL transalation with Seq! (#11015)
commit_hash:d2d2fcdef2bbd0434236aef325aa071c7e39c526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants