Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix volatile transactions getting stuck after a restart #10698

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Oct 22, 2024

Changelog entry

Fix volatile transactions getting stuck after a restart.

Changelog category

  • Bugfix

Additional information

When volatile transactions are enabled it was possible for shards to become stuck after an unfortunate series of restarts, until the affected shards are restarted again.

Fixes #10674.

@snaury snaury marked this pull request as ready for review October 22, 2024 08:10
@snaury snaury requested a review from a team as a code owner October 22, 2024 08:10
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 08:14:17 UTC Pre-commit check for 2985325 has started.
2024-10-22 08:16:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-22 08:39:42 UTC Build successful.
2024-10-22 08:39:58 UTC Tests are running...
🔴 2024-10-22 10:36:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10085 10007 0 9 24 45

🟢 2024-10-22 10:37:16 UTC ydbd size 5.6 GiB changed* by +256 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c3c5c05 merge: 2985325 diff diff %
ydbd size 5 960 306 528 Bytes 5 960 306 784 Bytes +256 Bytes +0.000%
ydbd stripped size 1 495 830 944 Bytes 1 495 831 008 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 08:14:18 UTC Pre-commit check for 2985325 has started.
2024-10-22 08:16:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-22 08:23:04 UTC Build successful.

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 08:17:01 UTC Pre-commit check for 2985325 has started.
2024-10-22 08:19:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-22 08:58:15 UTC Build successful.
2024-10-22 08:58:31 UTC Tests are running...
🔴 2024-10-22 10:21:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14385 13040 0 5 1299 41

🟢 2024-10-22 10:22:07 UTC ydbd size 8.2 GiB changed* by +624 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c3c5c05 merge: 2985325 diff diff %
ydbd size 8 814 802 472 Bytes 8 814 803 096 Bytes +624 Bytes +0.000%
ydbd stripped size 481 913 544 Bytes 481 913 608 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 7ff1c86 into ydb-platform:stable-24-3 Oct 22, 2024
8 of 12 checks passed
@snaury snaury deleted the bugfix-10674-missing-expectations-24-3 branch October 22, 2024 11:52
@snaury snaury self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants