Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable-24-3] Fixes for sinks #10655

Merged

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Oct 21, 2024

Changelog entry

  • Metrics & traces
  • Fix delete/update columns order
  • Fix large writes empty batches

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@nikvas0 nikvas0 requested a review from a team as a code owner October 21, 2024 10:15
Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 10:17:42 UTC Pre-commit check for 613da78 has started.
2024-10-21 10:20:42 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-21 11:00:00 UTC Build successful.

Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 10:19:36 UTC Pre-commit check for 613da78 has started.
2024-10-21 10:22:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-21 11:23:21 UTC Build successful.
2024-10-21 11:23:36 UTC Tests are running...
🔴 2024-10-21 13:13:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40139 34861 0 15 5217 46

🟢 2024-10-21 13:13:54 UTC ydbd size 8.2 GiB changed* by +58.2 KiB, which is < 100.0 KiB vs stable-24-3-10-analytics: OK

ydbd size dash stable-24-3-10-analytics: 75503d5 merge: 613da78 diff diff %
ydbd size 8 846 503 232 Bytes 8 846 562 832 Bytes +58.2 KiB +0.001%
ydbd stripped size 483 060 104 Bytes 483 064 136 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 21, 2024

2024-10-21 10:20:39 UTC Pre-commit check for 613da78 has started.
2024-10-21 10:23:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-21 11:10:47 UTC Build successful.
2024-10-21 11:11:03 UTC Tests are running...
🔴 2024-10-21 13:22:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11594 11489 0 28 30 47

🟢 2024-10-21 13:23:51 UTC ydbd size 5.6 GiB changed* by +77.2 KiB, which is < 100.0 KiB vs stable-24-3-10-analytics: OK

ydbd size dash stable-24-3-10-analytics: 75503d5 merge: 613da78 diff diff %
ydbd size 5 982 395 720 Bytes 5 982 474 800 Bytes +77.2 KiB +0.001%
ydbd stripped size 1 499 892 832 Bytes 1 499 910 464 Bytes +17.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 changed the base branch from stable-24-3-10-analytics to stable-24-3 October 24, 2024 10:42
@nikvas0 nikvas0 requested a review from a team as a code owner October 24, 2024 10:42
@nikvas0 nikvas0 changed the title [Stable-24-3-10-analytics] Fixes for sinks [Stable-24-3] Fixes for sinks Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 10:52:34 UTC Pre-commit check for b14bc80 has started.
2024-10-24 10:55:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-24 11:37:23 UTC Build successful.
2024-10-24 11:37:40 UTC Tests are running...
🔴 2024-10-24 13:43:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11609 11513 0 24 27 45

🟢 2024-10-24 13:44:05 UTC ydbd size 5.6 GiB changed* by +77.2 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c2af35d merge: b14bc80 diff diff %
ydbd size 5 986 541 832 Bytes 5 986 620 856 Bytes +77.2 KiB +0.001%
ydbd stripped size 1 500 699 424 Bytes 1 500 716 992 Bytes +17.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 10:52:37 UTC Pre-commit check for b14bc80 has started.
2024-10-24 10:55:54 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-24 11:33:25 UTC Build successful.

Copy link

github-actions bot commented Oct 24, 2024

2024-10-24 10:53:03 UTC Pre-commit check for b14bc80 has started.
2024-10-24 10:56:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-24 11:56:08 UTC Build successful.
2024-10-24 11:56:24 UTC Tests are running...
🔴 2024-10-24 13:53:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40160 34882 0 15 5219 44

🟢 2024-10-24 13:54:40 UTC ydbd size 8.2 GiB changed* by +58.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c2af35d merge: b14bc80 diff diff %
ydbd size 8 852 077 872 Bytes 8 852 137 528 Bytes +58.3 KiB +0.001%
ydbd stripped size 483 368 712 Bytes 483 372 808 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) October 25, 2024 11:02
@nikvas0 nikvas0 merged commit 0bf5166 into ydb-platform:stable-24-3 Oct 25, 2024
8 of 12 checks passed
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Oct 25, 2024
uzhastik added a commit to uzhastik/ydb that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants