Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persqueue: add user-agent counters #10603

Merged
merged 8 commits into from
Oct 23, 2024
Merged

Conversation

qyryq
Copy link
Collaborator

@qyryq qyryq commented Oct 18, 2024

No description provided.

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 12:13:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3c62e69 has started.
2024-10-18 12:13:39 UTC Artifacts will be uploaded here
2024-10-18 12:16:37 UTC ya make is running...
🟡 2024-10-18 13:19:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41407 35809 0 2 5501 95

2024-10-18 13:22:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 13:34:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 9 0 0 0 89

🟢 2024-10-18 13:34:26 UTC Build successful.
🟡 2024-10-18 13:34:46 UTC ydbd size 2.8 GiB changed* by +241.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a155f1c merge: 3c62e69 diff diff %
ydbd size 3 012 463 728 Bytes 3 012 711 336 Bytes +241.8 KiB +0.008%
ydbd stripped size 477 651 448 Bytes 477 693 496 Bytes +41.1 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 12:13:34 UTC Pre-commit check linux-x86_64-release-asan for 3c62e69 has started.
2024-10-18 12:13:44 UTC Artifacts will be uploaded here
2024-10-18 12:16:41 UTC ya make is running...
🟡 2024-10-18 13:45:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11635 11448 0 48 40 99

🟢 2024-10-18 13:46:48 UTC Build successful.
🟡 2024-10-18 13:47:22 UTC ydbd size 5.7 GiB changed* by +363.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a155f1c merge: 3c62e69 diff diff %
ydbd size 6 103 395 168 Bytes 6 103 766 992 Bytes +363.1 KiB +0.006%
ydbd stripped size 1 521 604 464 Bytes 1 521 727 920 Bytes +120.6 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

continue;
default:
clean.push_back(c);
if (clean.size() == 200) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the magic number to a properly named variable

->GetSubgroup("protocol", protocol)
->GetSubgroup("topic", FullConverter->GetFederationPath())
->GetSubgroup("user-agent", CleanupCounterValueString(UserAgent))
->GetExpiringNamedCounter("sensor", "BytesWrittenByUserAgent", true);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bytes_written_by_user_agent?

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 15:03:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5d7ad5d has started.
2024-10-18 15:03:35 UTC Artifacts will be uploaded here
2024-10-18 15:07:01 UTC ya make is running...
🟡 2024-10-18 16:00:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41374 35778 0 3 5498 95

2024-10-18 16:04:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 16:15:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 6 0 0 0 90

🟢 2024-10-18 16:15:51 UTC Build successful.
🟢 2024-10-18 16:16:08 UTC ydbd size 2.8 GiB changed* by +86.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77f6bc8 merge: 5d7ad5d diff diff %
ydbd size 3 012 692 184 Bytes 3 012 780 720 Bytes +86.5 KiB +0.003%
ydbd stripped size 477 690 008 Bytes 477 700 312 Bytes +10.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 15:05:17 UTC Pre-commit check linux-x86_64-release-asan for 5d7ad5d has started.
2024-10-18 15:05:29 UTC Artifacts will be uploaded here
2024-10-18 15:08:26 UTC ya make is running...
🟡 2024-10-18 16:35:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11658 11223 0 88 304 43

🟢 2024-10-18 16:36:35 UTC Build successful.
🟡 2024-10-18 16:37:08 UTC ydbd size 5.7 GiB changed* by +250.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77f6bc8 merge: 5d7ad5d diff diff %
ydbd size 6 103 710 472 Bytes 6 103 966 504 Bytes +250.0 KiB +0.004%
ydbd stripped size 1 521 729 136 Bytes 1 521 769 008 Bytes +38.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 11:43:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e85ebb has started.
2024-10-20 11:43:22 UTC Artifacts will be uploaded here
2024-10-20 11:46:24 UTC ya make is running...
2024-10-20 11:47:29 UTC Check cancelled

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 11:43:16 UTC Pre-commit check linux-x86_64-release-asan for 1e85ebb has started.
2024-10-20 11:43:26 UTC Artifacts will be uploaded here
2024-10-20 11:46:27 UTC ya make is running...
2024-10-20 11:47:29 UTC Check cancelled

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 11:48:10 UTC Pre-commit check linux-x86_64-release-asan for 348f8ae has started.
2024-10-20 11:48:47 UTC Artifacts will be uploaded here
2024-10-20 11:52:27 UTC ya make is running...
2024-10-20 12:07:06 UTC Check cancelled

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 11:51:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 348f8ae has started.
2024-10-20 11:51:37 UTC Artifacts will be uploaded here
2024-10-20 11:54:43 UTC ya make is running...
2024-10-20 12:07:16 UTC Check cancelled

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 12:11:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d7956f has started.
2024-10-20 12:11:19 UTC Artifacts will be uploaded here
2024-10-20 12:14:20 UTC ya make is running...
🟡 2024-10-20 13:07:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41275 35673 0 4 5502 96

2024-10-20 13:11:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-20 13:22:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 5 0 1 0 93

2024-10-20 13:22:33 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-20 13:33:50 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 0 0 1 0 93

🟡 2024-10-20 13:34:21 UTC ydbd size 2.8 GiB changed* by +104.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e0b481c merge: 0d7956f diff diff %
ydbd size 3 015 151 392 Bytes 3 015 257 840 Bytes +104.0 KiB +0.004%
ydbd stripped size 477 957 592 Bytes 477 970 200 Bytes +12.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 12:11:43 UTC Pre-commit check linux-x86_64-release-asan for 0d7956f has started.
2024-10-20 12:11:53 UTC Artifacts will be uploaded here
2024-10-20 12:15:11 UTC ya make is running...
🟡 2024-10-20 13:48:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11487 11228 0 93 57 109

🟢 2024-10-20 13:49:11 UTC Build successful.
🟡 2024-10-20 13:49:44 UTC ydbd size 5.7 GiB changed* by +284.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 07f2e60 merge: 0d7956f diff diff %
ydbd size 6 108 544 368 Bytes 6 108 836 000 Bytes +284.8 KiB +0.005%
ydbd stripped size 1 522 659 568 Bytes 1 522 712 464 Bytes +51.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 14:33:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 918a2a4 has started.
2024-10-20 14:33:50 UTC Artifacts will be uploaded here
2024-10-20 14:36:59 UTC ya make is running...
🟡 2024-10-20 15:34:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41277 35651 0 7 5516 103

2024-10-20 15:38:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-20 15:49:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
121 (only retried tests) 26 0 1 0 94

2024-10-20 15:49:57 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-20 16:01:14 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 1 0 1 0 93

🟢 2024-10-20 16:01:21 UTC Build successful.
🟡 2024-10-20 16:01:43 UTC ydbd size 2.8 GiB changed* by +122.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e0b481c merge: 918a2a4 diff diff %
ydbd size 3 015 151 392 Bytes 3 015 276 352 Bytes +122.0 KiB +0.004%
ydbd stripped size 477 957 592 Bytes 477 972 440 Bytes +14.5 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 20, 2024

2024-10-20 14:33:42 UTC Pre-commit check linux-x86_64-release-asan for 918a2a4 has started.
2024-10-20 14:33:53 UTC Artifacts will be uploaded here
2024-10-20 14:36:56 UTC ya make is running...
🟡 2024-10-20 16:01:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11483 11200 0 79 90 114

🟢 2024-10-20 16:02:21 UTC Build successful.
🟡 2024-10-20 16:02:55 UTC ydbd size 5.7 GiB changed* by +341.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 07f2e60 merge: 918a2a4 diff diff %
ydbd size 6 108 544 368 Bytes 6 108 894 160 Bytes +341.6 KiB +0.006%
ydbd stripped size 1 522 659 568 Bytes 1 522 721 296 Bytes +60.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@qyryq qyryq marked this pull request as ready for review October 21, 2024 09:26
@qyryq qyryq requested a review from a team as a code owner October 21, 2024 09:26
@qyryq qyryq requested a review from Alek5andr-Kotov October 21, 2024 09:26
Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 11:35:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for b58d191 has started.
2024-10-23 11:35:32 UTC Artifacts will be uploaded here
2024-10-23 11:36:48 UTC Check cancelled

alexnick88
alexnick88 previously approved these changes Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 11:42:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for b68155f has started.
2024-10-23 11:42:46 UTC Artifacts will be uploaded here
2024-10-23 11:45:50 UTC ya make is running...
🟡 2024-10-23 12:42:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41292 35689 0 1 5503 99

2024-10-23 12:45:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-23 12:57:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 4 0 1 0 94

2024-10-23 12:57:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-23 13:08:35 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 1 0 1 0 93

🟢 2024-10-23 13:08:42 UTC Build successful.
🟡 2024-10-23 13:09:05 UTC ydbd size 2.8 GiB changed* by +146.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8074419 merge: b68155f diff diff %
ydbd size 3 012 501 088 Bytes 3 012 650 688 Bytes +146.1 KiB +0.005%
ydbd stripped size 478 225 784 Bytes 478 247 608 Bytes +21.3 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 11:42:35 UTC Pre-commit check linux-x86_64-release-asan for b68155f has started.
2024-10-23 11:42:46 UTC Artifacts will be uploaded here
2024-10-23 11:45:50 UTC ya make is running...
🟡 2024-10-23 13:02:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11441 11259 0 42 36 104

🟢 2024-10-23 13:03:03 UTC Build successful.
🟡 2024-10-23 13:03:35 UTC ydbd size 5.7 GiB changed* by +425.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8074419 merge: b68155f diff diff %
ydbd size 6 100 058 984 Bytes 6 100 494 840 Bytes +425.6 KiB +0.007%
ydbd stripped size 1 522 599 408 Bytes 1 522 670 352 Bytes +69.3 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 13:35:39 UTC Pre-commit check linux-x86_64-release-asan for 8a7a8ef has started.
2024-10-23 13:36:18 UTC Artifacts will be uploaded here
2024-10-23 13:39:46 UTC ya make is running...
🟡 2024-10-23 14:53:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11437 11268 0 35 36 98

🟢 2024-10-23 14:54:16 UTC Build successful.
🔴 2024-10-23 14:54:45 UTC ydbd size 5.7 GiB changed* by +27.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: f1d756b merge: 8a7a8ef diff diff %
ydbd size 6 100 510 128 Bytes 6 129 284 304 Bytes +27.4 MiB +0.472%
ydbd stripped size 1 522 674 704 Bytes 1 530 724 752 Bytes +7.7 MiB +0.529%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 23, 2024

2024-10-23 13:38:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a7a8ef has started.
2024-10-23 13:38:17 UTC Artifacts will be uploaded here
2024-10-23 13:41:23 UTC ya make is running...
🟡 2024-10-23 14:38:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41292 35690 0 1 5503 98

2024-10-23 14:42:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-23 14:53:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 5 0 0 1 93

🟢 2024-10-23 14:53:51 UTC Build successful.
🔴 2024-10-23 14:54:10 UTC ydbd size 2.8 GiB changed* by +16.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: f1d756b merge: 8a7a8ef diff diff %
ydbd size 3 012 732 080 Bytes 3 029 669 560 Bytes +16.2 MiB +0.562%
ydbd stripped size 478 250 424 Bytes 480 731 768 Bytes +2.4 MiB +0.519%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@qyryq qyryq merged commit eebeb70 into ydb-platform:main Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants