Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable spilling #10583

Merged
merged 2 commits into from
Oct 18, 2024
Merged

disable spilling #10583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4df04
fixes applied to spilling enable
gridnevvvit Oct 17, 2024
af0f6fb
disable spilling
gridnevvvit Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ydb/core/kqp/opt/kqp_opt_build_txs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,16 +495,14 @@ class TKqpBuildTxsTransformer : public TSyncTransformerBase {
{
BuildTxTransformer = new TKqpBuildTxTransformer();

const bool enableSpillingGenericQuery =
kqpCtx->IsGenericQuery() && config->SpillingEnabled() &&
config->EnableSpillingGenericQuery;
config->EnableSpillingGenericQuery &= (kqpCtx->IsGenericQuery() && config->SpillingEnabled());

DataTxTransformer = TTransformationPipeline(&typesCtx)
.AddServiceTransformers()
.Add(TExprLogTransformer::Sync("TxOpt", NYql::NLog::EComponent::ProviderKqp, NYql::NLog::ELevel::TRACE), "TxOpt")
.Add(*TypeAnnTransformer, "TypeAnnotation")
.AddPostTypeAnnotation(/* forSubgraph */ true)
.Add(CreateKqpBuildPhyStagesTransformer(enableSpillingGenericQuery, typesCtx, config->BlockChannelsMode), "BuildPhysicalStages")
.Add(CreateKqpBuildPhyStagesTransformer(config->EnableSpillingGenericQuery, typesCtx, config->BlockChannelsMode), "BuildPhysicalStages")
// TODO(ilezhankin): "BuildWideBlockChannels" transformer is required only for BLOCK_CHANNELS_FORCE mode.
.Add(CreateKqpBuildWideBlockChannelsTransformer(typesCtx, config->BlockChannelsMode), "BuildWideBlockChannels")
.Add(*BuildTxTransformer, "BuildPhysicalTx")
Expand Down
4 changes: 2 additions & 2 deletions ydb/core/protos/table_service_config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ message TTableServiceConfig {

message TSpillingServiceConfig {
message TLocalFileConfig {
optional bool Enable = 1 [default = true];
optional bool Enable = 1 [default = false];
optional string Root = 2 [default = ""];
optional uint64 MaxTotalSize = 3 [default = 21474836480]; // 20 GiB
optional uint64 MaxFileSize = 4 [default = 5368709120]; // 5 GiB
Expand Down Expand Up @@ -309,7 +309,7 @@ message TTableServiceConfig {

optional bool EnableImplicitQueryParameterTypes = 66 [ default = false ];

optional string EnableSpillingNodes = 67 [ default = "All" ];
optional string EnableSpillingNodes = 67 [ default = "None" ];

message TComputeSchedulerSettings {
optional uint64 AdvanceTimeIntervalUsec = 1 [default = 50000];
Expand Down
Loading