Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clearing table stats after alter operaion #10509

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

aavdonkin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 12:35:07 UTC Pre-commit check linux-x86_64-release-asan for e3bd802 has started.
2024-10-16 12:35:18 UTC Artifacts will be uploaded here
2024-10-16 12:38:11 UTC ya make is running...
🟡 2024-10-16 14:06:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10434 10237 0 51 43 103

🟢 2024-10-16 14:07:49 UTC Build successful.
🔴 2024-10-16 14:08:23 UTC ydbd size 5.7 GiB changed* by +27.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 030f818 merge: e3bd802 diff diff %
ydbd size 6 099 890 304 Bytes 6 128 282 480 Bytes +27.1 MiB +0.465%
ydbd stripped size 1 521 081 712 Bytes 1 529 063 824 Bytes +7.6 MiB +0.525%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 12:39:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for e3bd802 has started.
2024-10-16 12:39:36 UTC Artifacts will be uploaded here
2024-10-16 12:42:30 UTC ya make is running...
🟡 2024-10-16 13:36:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15384 13834 0 3 1447 100

2024-10-16 13:37:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-16 13:49:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 67 0 0 0 98

🟢 2024-10-16 13:49:33 UTC Build successful.
🔴 2024-10-16 13:49:51 UTC ydbd size 2.8 GiB changed* by +16.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 030f818 merge: e3bd802 diff diff %
ydbd size 3 010 928 160 Bytes 3 027 741 064 Bytes +16.0 MiB +0.558%
ydbd stripped size 477 553 432 Bytes 480 018 776 Bytes +2.4 MiB +0.516%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -120,7 +120,9 @@ void TTablesStorage::TTableExtractedGuard::UseAlterDataVerified() {
TColumnTableInfo::TPtr alterInfo = Object->AlterData;
Y_ABORT_UNLESS(alterInfo);
alterInfo->AlterBody.Clear();
auto stats = Object->Stats;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По названию функции и до этого было непонятно, что она делает, а сейчас стало ещё более запутанно.

@aavdonkin aavdonkin merged commit f0a6e7f into ydb-platform:main Oct 18, 2024
11 checks passed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants