Added counters for local db tables loading times #10402

aavdonkin · 2024-10-14T12:39:14Z

Changelog entry

...

Additional information

...

github-actions · 2024-10-14T12:43:59Z

⚪ 2024-10-14 12:43:59 UTC Pre-commit check linux-x86_64-release-asan for 03d4f78 has started.
⚪ 2024-10-14 12:44:42 UTC Artifacts will be uploaded here
⚪ 2024-10-14 12:48:11 UTC ya make is running...
🟡 2024-10-14 14:20:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10317	10050	0	77	79	111

🟢 2024-10-14 14:21:27 UTC Build successful.
🟡 2024-10-14 14:22:01 UTC ydbd size 5.7 GiB changed* by +416.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `b4ac18d`	merge: `03d4f78`	diff	diff %
ydbd size	6 096 610 408 Bytes	6 097 036 496 Bytes	+416.1 KiB	+0.007%
ydbd stripped size	1 520 381 136 Bytes	1 520 446 032 Bytes	+63.4 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T12:46:47Z

⚪ 2024-10-14 12:46:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 03d4f78 has started.
⚪ 2024-10-14 12:46:58 UTC Artifacts will be uploaded here
⚪ 2024-10-14 12:49:52 UTC ya make is running...
🟡 2024-10-14 13:39:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15086	13587	0	3	1382	114

⚪ 2024-10-14 13:40:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 13:52:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
109 (only retried tests)	6	0	0	1	102

🟢 2024-10-14 13:52:58 UTC Build successful.
🟡 2024-10-14 13:53:17 UTC ydbd size 2.8 GiB changed* by +127.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `b4ac18d`	merge: `03d4f78`	diff	diff %
ydbd size	3 009 371 648 Bytes	3 009 502 240 Bytes	+127.5 KiB	+0.004%
ydbd stripped size	477 377 272 Bytes	477 389 816 Bytes	+12.2 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-15T14:04:08Z

⚪ 2024-10-15 14:04:07 UTC Pre-commit check linux-x86_64-release-asan for 066b340 has started.
⚪ 2024-10-15 14:04:17 UTC Artifacts will be uploaded here
⚪ 2024-10-15 14:07:18 UTC ya make is running...
🟡 2024-10-15 15:40:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10538	10264	0	104	64	106

🟢 2024-10-15 15:41:44 UTC Build successful.
🟡 2024-10-15 15:42:22 UTC ydbd size 5.7 GiB changed* by +586.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e1b2021`	merge: `066b340`	diff	diff %
ydbd size	6 099 183 344 Bytes	6 099 783 776 Bytes	+586.4 KiB	+0.010%
ydbd stripped size	1 521 014 864 Bytes	1 521 092 112 Bytes	+75.4 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-15T14:04:17Z

⚪ 2024-10-15 14:04:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 066b340 has started.
⚪ 2024-10-15 14:04:28 UTC Artifacts will be uploaded here
⚪ 2024-10-15 14:07:34 UTC ya make is running...
🟡 2024-10-15 15:08:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40261	34659	0	15	5481	106

⚪ 2024-10-15 15:12:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-15 15:23:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
119 (only retried tests)	17	0	2	0	100

⚪ 2024-10-15 15:24:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-15 15:35:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
102 (only retried tests)	4	0	0	0	98

🟢 2024-10-15 15:35:26 UTC Build successful.
🟡 2024-10-15 15:35:48 UTC ydbd size 2.8 GiB changed* by +195.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e1b2021`	merge: `066b340`	diff	diff %
ydbd size	3 010 579 120 Bytes	3 010 779 000 Bytes	+195.2 KiB	+0.007%
ydbd stripped size	477 546 712 Bytes	477 572 184 Bytes	+24.9 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-16T09:25:38Z

⚪ 2024-10-16 09:25:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for c2ab1a8 has started.
⚪ 2024-10-16 09:25:48 UTC Artifacts will be uploaded here
⚪ 2024-10-16 09:28:46 UTC ya make is running...
🟡 2024-10-16 10:25:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
40242	34652	0	4	5480	106

⚪ 2024-10-16 10:29:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-16 10:40:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
106 (only retried tests)	7	0	0	0	99

🟢 2024-10-16 10:40:43 UTC Build successful.
🟡 2024-10-16 10:41:01 UTC ydbd size 2.8 GiB changed* by +195.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `a4c9ddf`	merge: `c2ab1a8`	diff	diff %
ydbd size	3 010 890 376 Bytes	3 011 090 288 Bytes	+195.2 KiB	+0.007%
ydbd stripped size	477 548 888 Bytes	477 574 360 Bytes	+24.9 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-16T09:25:41Z

⚪ 2024-10-16 09:25:41 UTC Pre-commit check linux-x86_64-release-asan for c2ab1a8 has started.
⚪ 2024-10-16 09:25:52 UTC Artifacts will be uploaded here
⚪ 2024-10-16 09:29:03 UTC ya make is running...
🟡 2024-10-16 11:00:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10552	10297	0	83	61	111

🟢 2024-10-16 11:01:36 UTC Build successful.
🟡 2024-10-16 11:02:10 UTC ydbd size 5.7 GiB changed* by +590.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `a4c9ddf`	merge: `c2ab1a8`	diff	diff %
ydbd size	6 099 791 976 Bytes	6 100 396 456 Bytes	+590.3 KiB	+0.010%
ydbd stripped size	1 521 054 864 Bytes	1 521 136 144 Bytes	+79.4 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-16T12:40:41Z

⚪ 2024-10-16 12:40:40 UTC Pre-commit check linux-x86_64-release-asan for fd24cbc has started.
⚪ 2024-10-16 12:40:52 UTC Artifacts will be uploaded here
⚪ 2024-10-16 12:43:47 UTC ya make is running...
🟡 2024-10-16 14:08:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10378	10180	0	51	44	103

🟢 2024-10-16 14:09:37 UTC Build successful.
🔴 2024-10-16 14:10:10 UTC ydbd size 5.7 GiB changed* by +27.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash	main: `030f818`	merge: `fd24cbc`	diff	diff %
ydbd size	6 099 890 304 Bytes	6 128 811 240 Bytes	+27.6 MiB	+0.474%
ydbd stripped size	1 521 081 712 Bytes	1 529 138 000 Bytes	+7.7 MiB	+0.530%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-16T12:41:58Z

⚪ 2024-10-16 12:41:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for fd24cbc has started.
⚪ 2024-10-16 12:42:30 UTC Artifacts will be uploaded here
⚪ 2024-10-16 12:46:00 UTC ya make is running...
🟡 2024-10-16 13:35:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15144	13642	0	10	1383	109

⚪ 2024-10-16 13:37:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-16 13:48:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
117 (only retried tests)	17	0	2	0	98

⚪ 2024-10-16 13:48:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-16 14:00:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	2	0	0	0	98

🟢 2024-10-16 14:00:18 UTC Build successful.
🔴 2024-10-16 14:00:39 UTC ydbd size 2.8 GiB changed* by +16.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash	main: `030f818`	merge: `fd24cbc`	diff	diff %
ydbd size	3 010 928 160 Bytes	3 027 917 704 Bytes	+16.2 MiB	+0.564%
ydbd stripped size	477 553 432 Bytes	480 049 880 Bytes	+2.4 MiB	+0.523%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-18T08:33:38Z

⚪ 2024-10-18 08:33:37 UTC Pre-commit check linux-x86_64-release-asan for 6978030 has started.
⚪ 2024-10-18 08:34:24 UTC Artifacts will be uploaded here
⚪ 2024-10-18 08:37:48 UTC ya make is running...
🔴 2024-10-18 08:43:21 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-10-18T08:34:13Z

⚪ 2024-10-18 08:34:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6978030 has started.
⚪ 2024-10-18 08:34:24 UTC Artifacts will be uploaded here
⚪ 2024-10-18 08:37:19 UTC ya make is running...
🔴 2024-10-18 08:42:42 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-10-18T08:54:58Z

⚪ 2024-10-18 08:54:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for ef610c3 has started.
⚪ 2024-10-18 08:55:08 UTC Artifacts will be uploaded here
⚪ 2024-10-18 08:58:03 UTC ya make is running...
🟡 2024-10-18 09:43:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15163	13682	0	1	1384	96

⚪ 2024-10-18 09:44:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 09:55:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
97 (only retried tests)	7	0	0	0	90

🟢 2024-10-18 09:55:59 UTC Build successful.
🟡 2024-10-18 09:56:17 UTC ydbd size 2.8 GiB changed* by +193.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `8ce79cf`	merge: `ef610c3`	diff	diff %
ydbd size	3 012 455 568 Bytes	3 012 653 672 Bytes	+193.5 KiB	+0.007%
ydbd stripped size	477 649 592 Bytes	477 671 864 Bytes	+21.8 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-18T08:54:59Z

⚪ 2024-10-18 08:54:59 UTC Pre-commit check linux-x86_64-release-asan for ef610c3 has started.
⚪ 2024-10-18 08:55:09 UTC Artifacts will be uploaded here
⚪ 2024-10-18 08:58:11 UTC ya make is running...
🟡 2024-10-18 10:27:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10408	10153	0	82	66	107

🟢 2024-10-18 10:28:32 UTC Build successful.
🟡 2024-10-18 10:29:07 UTC ydbd size 5.7 GiB changed* by +607.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `8ce79cf`	merge: `ef610c3`	diff	diff %
ydbd size	6 103 363 728 Bytes	6 103 985 960 Bytes	+607.6 KiB	+0.010%
ydbd stripped size	1 521 591 984 Bytes	1 521 681 008 Bytes	+86.9 KiB	+0.006%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-18T14:34:55Z

⚪ 2024-10-18 14:34:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for f93a913 has started.
⚪ 2024-10-18 14:35:05 UTC Artifacts will be uploaded here
⚪ 2024-10-18 14:38:05 UTC ya make is running...
🔴 2024-10-18 14:43:24 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-10-18T14:34:59Z

⚪ 2024-10-18 14:34:58 UTC Pre-commit check linux-x86_64-release-asan for f93a913 has started.
⚪ 2024-10-18 14:35:09 UTC Artifacts will be uploaded here
⚪ 2024-10-18 14:38:03 UTC ya make is running...
🔴 2024-10-18 14:44:24 UTC Build failed, see the logs. Also see fail summary

github-actions · 2024-10-21T12:48:53Z

⚪ 2024-10-21 12:48:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3783590 has started.
⚪ 2024-10-21 12:49:04 UTC Artifacts will be uploaded here
⚪ 2024-10-21 12:52:02 UTC ya make is running...
🟡 2024-10-21 13:39:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15006	13518	0	3	1389	96

⚪ 2024-10-21 13:40:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-21 13:52:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
99 (only retried tests)	7	0	0	0	92

🟢 2024-10-21 13:52:09 UTC Build successful.
🟡 2024-10-21 13:52:29 UTC ydbd size 2.8 GiB changed* by +180.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e6f71f0`	merge: `3783590`	diff	diff %
ydbd size	3 015 313 344 Bytes	3 015 498 088 Bytes	+180.4 KiB	+0.006%
ydbd stripped size	477 978 264 Bytes	477 998 808 Bytes	+20.1 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T12:49:04Z

⚪ 2024-10-21 12:49:03 UTC Pre-commit check linux-x86_64-release-asan for 3783590 has started.
⚪ 2024-10-21 12:49:16 UTC Artifacts will be uploaded here
⚪ 2024-10-21 12:52:23 UTC ya make is running...
🟡 2024-10-21 14:21:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10241	10011	0	68	56	106

🟢 2024-10-21 14:22:04 UTC Build successful.
🟡 2024-10-21 14:22:37 UTC ydbd size 5.7 GiB changed* by +563.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `e6f71f0`	merge: `3783590`	diff	diff %
ydbd size	6 108 702 688 Bytes	6 109 280 152 Bytes	+563.9 KiB	+0.009%
ydbd stripped size	1 522 711 760 Bytes	1 522 789 904 Bytes	+76.3 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/tx/columnshard/counters/common_data.h

ydb/core/tx/columnshard/columnshard_schema.h

ivanmorozov333 · 2024-10-21T14:20:16Z

ydb/core/tx/columnshard/counters/engine_logs.h

@@ -223,6 +223,13 @@ class TEngineLogsCounters: public TCommonCountersOwner {

    NMonitoring::TDynamicCounters::TCounterPtr IndexMetadataUsageBytes;

+    NMonitoring::TDynamicCounters::TCounterPtr PortionsLoadingTimeCounter;


в отдельный класс все

ydb/core/tx/columnshard/engines/column_engine_logs.cpp

ivanmorozov333 · 2024-10-21T14:21:27Z

ydb/core/tx/columnshard/engines/db_wrapper.cpp

@@ -103,6 +103,7 @@ bool TDbWrapper::LoadColumns(const std::function<void(NOlap::TPortionInfoConstru
    using IndexColumns = NColumnShard::Schema::IndexColumns;
    auto rowset = db.Table<IndexColumns>().Prefix(0).Select();
    if (!rowset.IsReady()) {
+        LOG_S_CRIT("Load: index columns is not ready");


убрать логи

ydb/core/tx/columnshard/engines/insert_table/insert_table.cpp

ydb/core/tx/columnshard/tables_manager.cpp

ivanmorozov333

1

…ss for each table

ydb/core/tx/columnshard/counters/common_data.cpp

ydb/core/tx/columnshard/counters/common_data.h

github-actions · 2024-10-23T15:40:58Z

⚪ 2024-10-23 15:40:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc32939 has started.
⚪ 2024-10-23 15:41:55 UTC Artifacts will be uploaded here
⚪ 2024-10-23 15:45:23 UTC ya make is running...
⚫ 2024-10-23 16:11:48 UTC Check cancelled

github-actions · 2024-10-23T15:43:27Z

⚪ 2024-10-23 15:43:26 UTC Pre-commit check linux-x86_64-release-asan for fc32939 has started.
⚪ 2024-10-23 15:43:38 UTC Artifacts will be uploaded here
⚪ 2024-10-23 15:46:39 UTC ya make is running...
⚫ 2024-10-23 16:11:43 UTC Check cancelled

ydb/core/tx/columnshard/tables_manager.cpp

github-actions · 2024-10-23T16:15:36Z

⚪ 2024-10-23 16:15:35 UTC Pre-commit check linux-x86_64-release-asan for 98da61d has started.
⚪ 2024-10-23 16:15:47 UTC Artifacts will be uploaded here
⚪ 2024-10-23 16:18:53 UTC ya make is running...
⚫ 2024-10-23 17:07:50 UTC Check cancelled

github-actions · 2024-10-23T16:15:50Z

⚪ 2024-10-23 16:15:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98da61d has started.
⚪ 2024-10-23 16:16:02 UTC Artifacts will be uploaded here
⚪ 2024-10-23 16:19:07 UTC ya make is running...
🟡 2024-10-23 17:07:55 UTC ydbd size 2.8 GiB changed* by +289.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `8a7394e`	merge: `98da61d`	diff	diff %
ydbd size	3 029 688 152 Bytes	3 029 984 968 Bytes	+289.9 KiB	+0.010%
ydbd stripped size	480 734 072 Bytes	480 757 560 Bytes	+22.9 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-10-23 17:07:57 UTC Check cancelled

github-actions · 2024-10-23T17:08:43Z

⚪ 2024-10-23 17:08:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for b21e144 has started.
⚪ 2024-10-23 17:08:53 UTC Artifacts will be uploaded here
⚪ 2024-10-23 17:11:51 UTC ya make is running...
🟡 2024-10-23 17:57:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15031	13541	0	3	1390	97

⚪ 2024-10-23 17:58:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-23 18:09:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
98 (only retried tests)	5	0	0	0	93

🟢 2024-10-23 18:09:56 UTC Build successful.
🟡 2024-10-23 18:10:19 UTC ydbd size 2.8 GiB changed* by +179.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `cb09349`	merge: `b21e144`	diff	diff %
ydbd size	3 029 800 848 Bytes	3 029 984 952 Bytes	+179.8 KiB	+0.006%
ydbd stripped size	480 752 376 Bytes	480 757 560 Bytes	+5.1 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-23T17:10:18Z

⚪ 2024-10-23 17:10:18 UTC Pre-commit check linux-x86_64-release-asan for b21e144 has started.
⚪ 2024-10-23 17:11:57 UTC Artifacts will be uploaded here
⚪ 2024-10-23 17:15:53 UTC ya make is running...
🟡 2024-10-23 18:32:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10215	10017	0	53	45	100

🟢 2024-10-23 18:33:20 UTC Build successful.
🟡 2024-10-23 18:33:53 UTC ydbd size 5.7 GiB changed* by +426.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `cb09349`	merge: `b21e144`	diff	diff %
ydbd size	6 129 528 712 Bytes	6 129 964 968 Bytes	+426.0 KiB	+0.007%
ydbd stripped size	1 530 785 904 Bytes	1 530 818 960 Bytes	+32.3 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-24T08:56:47Z

⚪ 2024-10-24 08:56:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 28bec0d has started.
⚪ 2024-10-24 08:57:30 UTC Artifacts will be uploaded here
⚪ 2024-10-24 09:00:58 UTC ya make is running...
⚫ 2024-10-24 09:32:46 UTC Check cancelled

github-actions · 2024-10-24T08:59:48Z

⚪ 2024-10-24 08:59:47 UTC Pre-commit check linux-x86_64-release-asan for 28bec0d has started.
⚪ 2024-10-24 08:59:59 UTC Artifacts will be uploaded here
⚪ 2024-10-24 09:03:08 UTC ya make is running...
⚫ 2024-10-24 09:32:47 UTC Check cancelled

github-actions · 2024-10-24T09:35:04Z

⚪ 2024-10-24 09:35:04 UTC Pre-commit check linux-x86_64-release-asan for f5330ef has started.
⚪ 2024-10-24 09:35:09 UTC Artifacts will be uploaded here
⚪ 2024-10-24 09:38:10 UTC ya make is running...
🟡 2024-10-24 10:53:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10218	10021	0	53	44	100

🟢 2024-10-24 10:54:29 UTC Build successful.
🟡 2024-10-24 10:55:03 UTC ydbd size 5.7 GiB changed* by +438.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `77b0197`	merge: `f5330ef`	diff	diff %
ydbd size	6 135 133 496 Bytes	6 135 581 976 Bytes	+438.0 KiB	+0.007%
ydbd stripped size	1 531 696 976 Bytes	1 531 720 432 Bytes	+22.9 KiB	+0.002%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-24T09:35:06Z

⚪ 2024-10-24 11:05:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for f5330ef has started.
⚪ 2024-10-24 11:05:43 UTC Artifacts will be uploaded here
⚪ 2024-10-24 11:08:43 UTC ya make is running...
🟡 2024-10-24 11:55:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15032	13453	0	7	1476	96

⚪ 2024-10-24 11:56:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-24 12:08:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
186 (only retried tests)	95	0	0	0	91

🟢 2024-10-24 12:08:13 UTC Build successful.
🟡 2024-10-24 12:08:30 UTC ydbd size 2.8 GiB changed* by +183.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `77b0197`	merge: `f5330ef`	diff	diff %
ydbd size	3 032 422 696 Bytes	3 032 610 088 Bytes	+183.0 KiB	+0.006%
ydbd stripped size	480 962 168 Bytes	480 967 480 Bytes	+5.2 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Added counters for local db tables loading times

5097d63

aavdonkin requested a review from a team as a code owner October 14, 2024 12:39

github-actions bot added the new-feature label Oct 14, 2024

Added counters for local tables load fails

4336be2

Use GetValue for counters where Set is used

cea734c

Removed disk space logging

9815eb3

Added tabletId to sensor names

99942a5

Fixed test

b381444

Calculate sum of loading times for all tables in each node

dfe5561

Fixed test

b4edaa4

ivanmorozov333 reviewed Oct 21, 2024

View reviewed changes

ivanmorozov333 approved these changes Oct 21, 2024

View reviewed changes

ivanmorozov333 requested changes Oct 21, 2024

View reviewed changes

Use guard for time measurement; Use separate instanse of counters cla…

233c044

…ss for each table

ivanmorozov333 reviewed Oct 23, 2024

View reviewed changes

ydb/core/tx/columnshard/counters/common_data.cpp Outdated Show resolved Hide resolved

TLoadTimer moved inside TLoadTimeSignals

c114d1f

ivanmorozov333 reviewed Oct 23, 2024

View reviewed changes

ydb/core/tx/columnshard/counters/common_data.h Outdated Show resolved Hide resolved

Use same name for sensors and logs

ad9c035

ivanmorozov333 reviewed Oct 23, 2024

View reviewed changes

ydb/core/tx/columnshard/tables_manager.cpp Show resolved Hide resolved

Added AddLoadingFail call to branch which never executed

6963426

Moved counters to SignalCounters

1f67128

Removed unnecessary include

7eb91ec

ivanmorozov333 approved these changes Oct 24, 2024

View reviewed changes

aavdonkin merged commit 4d5a0f8 into ydb-platform:main Oct 24, 2024
10 checks passed

GrigoriyPA mentioned this pull request Oct 28, 2024

YQ RD fixed use after free #10978

Merged

shnikd mentioned this pull request Nov 7, 2024

Support QueryMeta and diagnostics #11371

Merged

niksaveliev mentioned this pull request Nov 8, 2024

Fix read session correct close ut #11407

Merged

GrigoriyPA mentioned this pull request Nov 13, 2024

YQ WM fixed race with actor context #11576

Merged

niksaveliev mentioned this pull request Nov 14, 2024

Commit for autopartitioned topics #11629

Open

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025

Added counters for local db tables loading times (ydb-platform#10402)

842495e

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

Added counters for local db tables loading times (ydb-platform#10402)

4e35a3a

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

Added counters for local db tables loading times (ydb-platform#10402)

8303e80

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025

Added counters for local db tables loading times (ydb-platform#10402)

21b1a45

zverevgeny mentioned this pull request Jan 9, 2025

Integrate changes from main #13202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added counters for local db tables loading times #10402

Added counters for local db tables loading times #10402

aavdonkin commented Oct 14, 2024

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

ivanmorozov333 Oct 21, 2024

ivanmorozov333 Oct 21, 2024

ivanmorozov333 left a comment

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

		@@ -223,6 +223,13 @@ class TEngineLogsCounters: public TCommonCountersOwner {

		NMonitoring::TDynamicCounters::TCounterPtr IndexMetadataUsageBytes;

		NMonitoring::TDynamicCounters::TCounterPtr PortionsLoadingTimeCounter;

Added counters for local db tables loading times #10402

Added counters for local db tables loading times #10402

Conversation

aavdonkin commented Oct 14, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 15, 2024 • edited Loading

github-actions bot commented Oct 15, 2024 • edited Loading

github-actions bot commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 18, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

ivanmorozov333 Oct 21, 2024

Choose a reason for hiding this comment

ivanmorozov333 Oct 21, 2024

Choose a reason for hiding this comment

ivanmorozov333 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 23, 2024 • edited Loading

github-actions bot commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 24, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading