refactor CreatePartitions endpoint of Kafka API to use TUpdateSchemeActor #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 4226007.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 4226007.
|
8df7353 to
78fe877
Compare
…e TUpdateSchemeActor
78fe877 to
4226007
Compare
nshestakov
previously approved these changes
Jan 16, 2024
alexnick88
reviewed
Jan 17, 2024
| } else { | ||
| SendResultCallback(TEvKafka::TEvTopicModificationResponse::EStatus::ERROR, ReplyMessage); | ||
| } | ||
| if (Issue.IssueCode == Ydb::PersQueue::ErrorCode::ACCESS_DENIED) { |
There was a problem hiding this comment.
Почему такой выбор именно конвертации scheme_error?
There was a problem hiding this comment.
Обсудили, исправил
Fix incorrect output format in case of two same topics provided for Create Partitions. Refactorings + style fixes.
edf18fa to
1ed5af2
Compare
alexnick88
approved these changes
Jan 22, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Jan 29, 2024
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.