Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unregister group race #10020

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

@github-actions github-actions bot added the bugfix label Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 06:27:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 491533b has started.
2024-10-03 06:28:01 UTC Artifacts will be uploaded here
2024-10-03 06:30:53 UTC ya make is running...
🔴 2024-10-03 06:34:31 UTC Build failed, see the logs.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 06:28:07 UTC Pre-commit check linux-x86_64-release-asan for 491533b has started.
2024-10-03 06:28:18 UTC Artifacts will be uploaded here
2024-10-03 06:31:16 UTC ya make is running...
2024-10-03 06:36:56 UTC Check cancelled

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 06:40:22 UTC Pre-commit check linux-x86_64-release-asan for f1e9c01 has started.
2024-10-03 06:40:32 UTC Artifacts will be uploaded here
2024-10-03 06:43:22 UTC ya make is running...
🟡 2024-10-03 08:21:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11504 11305 0 54 38 107

🟢 2024-10-03 08:22:55 UTC Build successful.
🟢 2024-10-03 08:23:26 UTC ydbd size 5.7 GiB changed* by +9.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a491b73 merge: f1e9c01 diff diff %
ydbd size 6 085 731 248 Bytes 6 085 740 784 Bytes +9.3 KiB +0.000%
ydbd stripped size 1 520 437 360 Bytes 1 520 439 280 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 06:40:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for f1e9c01 has started.
2024-10-03 06:41:00 UTC Artifacts will be uploaded here
2024-10-03 06:43:54 UTC ya make is running...
🟡 2024-10-03 07:34:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16461 14983 0 1 1377 100

2024-10-03 07:35:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-03 07:47:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 5 0 0 0 94

🟢 2024-10-03 07:47:27 UTC Build successful.
🟢 2024-10-03 07:47:47 UTC ydbd size 2.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a491b73 merge: f1e9c01 diff diff %
ydbd size 3 001 625 304 Bytes 3 001 628 440 Bytes +3.1 KiB +0.000%
ydbd stripped size 477 324 088 Bytes 477 324 600 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review October 3, 2024 08:25
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) October 3, 2024 08:25
@ivanmorozov333 ivanmorozov333 merged commit 01c8e9f into ydb-platform:main Oct 3, 2024
10 checks passed
fexolm pushed a commit to fexolm/ydb that referenced this pull request Oct 3, 2024
@ivanmorozov333 ivanmorozov333 deleted the fix_unregister_group_race branch October 3, 2024 13:19
fexolm added a commit that referenced this pull request Oct 3, 2024
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Oct 14, 2024
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Oct 15, 2024
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Oct 15, 2024
Co-authored-by: ivanmorozov333 <ivanmorozov@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS fails on VERIFY in NGroupedMemoryManager::TManager::UnregisterGroup
2 participants