Minor changes in TGroupId

ydb-platform · May 27, 2024 · fa8f6a7 · fa8f6a7
1 parent fce0ad8
commit fa8f6a7
Show file tree

Hide file tree

Showing 23 changed files with 93 additions and 66 deletions.
diff --git a/ydb/core/base/id_wrapper.h b/ydb/core/base/id_wrapper.h
@@ -16,7 +16,8 @@ template <typename T, typename Tag> class TIdWrapper {
   T Raw;
 
 public:
-  TIdWrapper() = default;
+  constexpr TIdWrapper() noexcept : Raw(0) {
+  }
 
   ~TIdWrapper() = default;
 
@@ -35,6 +36,14 @@ template <typename T, typename Tag> class TIdWrapper {
     (message->*pfn)(*this);
   }
 
+  static constexpr TIdWrapper FromValue(T value) noexcept {
+        return TIdWrapper(value);
+  }
+
+  static constexpr TIdWrapper Zero() noexcept {
+        return TIdWrapper();
+    }
+
   TIdWrapper &operator+=(const T &other) {
     Raw += other.Raw;
     return *this;

diff --git a/ydb/core/blobstorage/nodewarden/distconf_validate.cpp b/ydb/core/blobstorage/nodewarden/distconf_validate.cpp
@@ -39,7 +39,7 @@ namespace NKikimr::NStorage {
         THashMap<TVDiskID, std::tuple<ui32, ui32, ui32, ui64>> vdisks;
         for (const auto& vslot : current.GetVDisks()) {
             TVDiskID vdiskId = VDiskIDFromVDiskID(vslot.GetVDiskID());
-            const auto it = currentGroupGens.find(vdiskId.GroupID);
+            const auto it = currentGroupGens.find(vdiskId.GroupID.GetRawId());
             if (it == currentGroupGens.end() || it->second != vdiskId.GroupGeneration) {
                 continue;
             }
@@ -75,7 +75,7 @@ namespace NKikimr::NStorage {
             const bool changed = it->second != std::make_tuple(l.GetNodeID(), l.GetPDiskID(), l.GetVDiskSlotID(), l.GetPDiskGuid()) ||
                 invalidatedNodeIds.contains(l.GetNodeID()) ||
                 invalidatedPDiskIds.contains(std::make_tuple(l.GetNodeID(), l.GetPDiskID()));
-            if (changed && !changedGroups.emplace(vdiskId.GroupID).second) {
+            if (changed && !changedGroups.emplace(vdiskId.GroupID.GetRawId()).second) {
                 return "more than one slot has changed in group";
             }
 

diff --git a/ydb/core/blobstorage/nodewarden/node_warden_group_resolver.cpp b/ydb/core/blobstorage/nodewarden/node_warden_group_resolver.cpp
@@ -338,7 +338,7 @@ namespace NKikimr::NStorage {
         }
         for (const auto& [key, value] : LocalVDisks) {
             if (const auto& r = value.RuntimeData; r && !r->DonorMode) {
-                record.AddStartedGroupIds(r->GroupInfo->GroupID);
+                record.AddStartedGroupIds(r->GroupInfo->GroupID.GetRawId());
             }
         }
         Send(ev->Sender, res.release(), 0, ev->Cookie);

diff --git a/ydb/core/blobstorage/vdisk/skeleton/blobstorage_skeletonfront.cpp b/ydb/core/blobstorage/vdisk/skeleton/blobstorage_skeletonfront.cpp
@@ -22,6 +22,7 @@
 #include <ydb/core/util/queue_inplace.h>
 #include <ydb/core/util/stlog.h>
 #include <ydb/core/base/counters.h>
+#include <ydb/core/base/id_wrapper.h>
 #include <ydb/library/wilson_ids/wilson.h>
 #include <ydb/core/node_whiteboard/node_whiteboard.h>
 
@@ -677,7 +678,7 @@ namespace NKikimr {
         ui64 AllocateMessageId() {
             return NextUniqueMessageId++;
         }
-
+        using TGroupId = TIdWrapper<ui32, TGroupIdTag>;
         ////////////////////////////////////////////////////////////////////////
         // NOTIFICATIONS
         ////////////////////////////////////////////////////////////////////////
@@ -714,7 +715,7 @@ namespace NKikimr {
                 const auto &bi = Config->BaseInfo;
                 TString path = Sprintf("vdisk%09" PRIu32 "_%09" PRIu32, bi.PDiskId, bi.VDiskSlotId);
                 TString name = Sprintf("%s VDisk%09" PRIu32 "_%09" PRIu32 " (%" PRIu32 ")",
-                                      VCtx->VDiskLogPrefix.data(), bi.PDiskId, bi.VDiskSlotId, GInfo->GroupID);
+                                      VCtx->VDiskLogPrefix.data(), bi.PDiskId, bi.VDiskSlotId, GInfo->GroupID.GetRawId());
                 mon->RegisterActorPage(vdisksMonPage, path, name, false, ctx.ExecutorThread.ActorSystem, ctx.SelfID);
             }
         }
@@ -1463,7 +1464,7 @@ namespace NKikimr {
                             auto newInfo = TBlobStorageGroupInfo::Parse(record.GetRecentGroup(), nullptr, nullptr);
                             ChangeGeneration(vdiskId, newInfo, ctx);
                             Y_ABORT_UNLESS(vdiskId == SelfVDiskId);
-                            const ui32 groupId = newInfo->GroupID;
+                            const TGroupId groupId = newInfo->GroupID;
                             const ui32 generation = newInfo->GroupGeneration;
                             auto ev = std::make_unique<TEvBlobStorage::TEvUpdateGroupInfo>(groupId, generation, *newInfo->Group);
                             Send(MakeBlobStorageNodeWardenID(SelfId().NodeId()), ev.release());
@@ -1619,7 +1620,7 @@ namespace NKikimr {
                 const TActorContext& ctx) {
             // check group id
             Y_ABORT_UNLESS(info->GroupID == GInfo->GroupID, "GroupId# %" PRIu32 " new GroupId# %" PRIu32,
-                GInfo->GroupID, info->GroupID);
+                GInfo->GroupID.GetRawId(), info->GroupID.GetRawId());
 
             // check target disk id
             Y_ABORT_UNLESS(TVDiskIdShort(SelfVDiskId) == TVDiskIdShort(vdiskId), "Incorrect target VDiskId"
@@ -2114,7 +2115,7 @@ namespace NKikimr {
             chain.emplace_back("storagePool", cfg->BaseInfo.StoragePoolName);
 
             // add 'group' label
-            const ui32 blobstorageGroupId = info->GroupID;
+            const ui32 blobstorageGroupId = info->GroupID.GetRawId();
             chain.emplace_back("group", Sprintf("%09" PRIu32, blobstorageGroupId));
 
             // add 'orderNumber' label (VDisk order number in the group)

diff --git a/ydb/core/cms/cluster_info.cpp b/ydb/core/cms/cluster_info.cpp
@@ -261,7 +261,7 @@ TString TVDiskInfo::PrettyItemName() const
 
 TString TVDiskInfo::GetDeviceName() const
 {
-    return Sprintf("vdisk-%u-%u-%u-%u-%u", VDiskId.GroupID, VDiskId.GroupGeneration,
+    return Sprintf("vdisk-%u-%u-%u-%u-%u", VDiskId.GroupID.GetRawId(), VDiskId.GroupGeneration,
                    VDiskId.FailRealm, VDiskId.FailDomain, VDiskId.VDisk);
 }
 
@@ -1008,7 +1008,7 @@ void TClusterInfo::DebugDump(const TActorContext &ctx) const
         TStringStream ss;
         auto &group = entry.second;
         ss << "BSGroup {" << Endl
-           << "  Id: " << (ui32)group.GroupId << Endl;
+           << "  Id: " << group.GroupId << Endl;
         if (group.Erasure.GetErasure() == TErasureType::ErasureSpeciesCount)
             ss << "  Erasure: UNKNOWN" << Endl;
         else

diff --git a/ydb/core/keyvalue/keyvalue_storage_request.cpp b/ydb/core/keyvalue/keyvalue_storage_request.cpp
@@ -109,7 +109,7 @@ class TKeyValueStorageRequest : public TActorBootstrapped<TKeyValueStorageReques
         IntermediateResults->Stat.PutLatencies.push_back(duration.MilliSeconds());
 
         auto groupId = ev->Get()->GroupId;
-        CheckYellow(ev->Get()->StatusFlags, groupId);
+        CheckYellow(ev->Get()->StatusFlags, groupId.GetRawId());
 
         NKikimrProto::EReplyStatus status = ev->Get()->Status;
         if (status != NKikimrProto::OK) {
@@ -157,14 +157,14 @@ class TKeyValueStorageRequest : public TActorBootstrapped<TKeyValueStorageReques
         wr->StatusFlags.Merge(ev->Get()->StatusFlags.Raw);
         wr->Latency = duration;
         ++WriteRequestsReplied;
-        IntermediateResults->Stat.GroupWrittenBytes[std::make_pair(ev->Get()->Id.Channel(), groupId)] += ev->Get()->Id.BlobSize();
-        IntermediateResults->Stat.GroupWrittenIops[std::make_pair(ev->Get()->Id.Channel(), groupId)] += 1; // FIXME: count distinct blobs?
+        IntermediateResults->Stat.GroupWrittenBytes[std::make_pair(ev->Get()->Id.Channel(), groupId.GetRawId())] += ev->Get()->Id.BlobSize();
+        IntermediateResults->Stat.GroupWrittenIops[std::make_pair(ev->Get()->Id.Channel(), groupId.GetRawId())] += 1; // FIXME: count distinct blobs?
         UpdateRequest(ctx);
     }
 
     void Handle(TEvBlobStorage::TEvPatchResult::TPtr &ev, const TActorContext &ctx) {
         auto groupId = ev->Get()->GroupId;
-        CheckYellow(ev->Get()->StatusFlags, groupId);
+        CheckYellow(ev->Get()->StatusFlags, groupId.GetRawId());
 
         NKikimrProto::EReplyStatus status = ev->Get()->Status;
         if (status != NKikimrProto::OK) {
@@ -211,8 +211,8 @@ class TKeyValueStorageRequest : public TActorBootstrapped<TKeyValueStorageReques
         }
         patch->StatusFlags.Merge(ev->Get()->StatusFlags.Raw);
         ++PatchRequestsReplied;
-        IntermediateResults->Stat.GroupWrittenBytes[std::make_pair(ev->Get()->Id.Channel(), groupId)] += ev->Get()->Id.BlobSize();
-        IntermediateResults->Stat.GroupWrittenIops[std::make_pair(ev->Get()->Id.Channel(), groupId)] += 1;
+        IntermediateResults->Stat.GroupWrittenBytes[std::make_pair(ev->Get()->Id.Channel(), groupId.GetRawId())] += ev->Get()->Id.BlobSize();
+        IntermediateResults->Stat.GroupWrittenIops[std::make_pair(ev->Get()->Id.Channel(), groupId.GetRawId())] += 1;
         UpdateRequest(ctx);
     }
 
@@ -337,8 +337,8 @@ class TKeyValueStorageRequest : public TActorBootstrapped<TKeyValueStorageReques
             if (response.Status == NKikimrProto::OK) {
                 Y_ABORT_UNLESS(response.Buffer.size() == readItem.BlobSize);
                 Y_ABORT_UNLESS(readItem.ValueOffset + readItem.BlobSize <= read.ValueSize);
-                IntermediateResults->Stat.GroupReadBytes[std::make_pair(response.Id.Channel(), groupId)] += response.Buffer.size();
-                IntermediateResults->Stat.GroupReadIops[std::make_pair(response.Id.Channel(), groupId)] += 1; // FIXME: count distinct blobs?
+                IntermediateResults->Stat.GroupReadBytes[std::make_pair(response.Id.Channel(), groupId.GetRawId())] += response.Buffer.size();
+                IntermediateResults->Stat.GroupReadIops[std::make_pair(response.Id.Channel(), groupId.GetRawId())] += 1; // FIXME: count distinct blobs?
                 read.Value.Write(readItem.ValueOffset, std::move(response.Buffer));
             } else {
                 Y_VERIFY_DEBUG_S(response.Status != NKikimrProto::NODATA, "NODATA received for TEvGet"

diff --git a/ydb/core/mind/bscontroller/cmds_storage_pool.cpp b/ydb/core/mind/bscontroller/cmds_storage_pool.cpp
@@ -330,7 +330,7 @@ namespace NKikimr::NBsController {
 
             auto *existing = sp->MutableExistingGroups();
             for (TGroupId groupId : kv.second) {
-                existing->AddGroupId(groupId);
+                existing->AddGroupId(groupId.GetRawId());
             }
         }
 
@@ -541,7 +541,7 @@ namespace NKikimr::NBsController {
             for (const auto& [vslotId, vslot] : StaticVSlots) {
                 auto *x = pb->AddVSlot();
                 vslotId.Serialize(x->MutableVSlotId());
-                x->SetGroupId(vslot.VDiskId.GroupID);
+                x->SetGroupId(vslot.VDiskId.GroupID.GetRawId());
                 x->SetGroupGeneration(vslot.VDiskId.GroupGeneration);
                 x->SetFailRealmIdx(vslot.VDiskId.FailRealm);
                 x->SetFailDomainIdx(vslot.VDiskId.FailDomain);

diff --git a/ydb/core/mind/bscontroller/disk_metrics.cpp b/ydb/core/mind/bscontroller/disk_metrics.cpp
@@ -27,7 +27,7 @@ class TBlobStorageController::TTxUpdateDiskMetrics : public TTransactionBase<TBl
 
         for (const auto& [vslotId, v] : Self->VSlots) {
             if (std::exchange(v->MetricsDirty, false)) {
-                auto&& key = std::tie(v->GroupId, v->GroupGeneration, v->RingIdx, v->FailDomainIdx, v->VDiskIdx);
+                auto&& key = std::tie(v->GroupId.GetRawId(), v->GroupGeneration, v->RingIdx, v->FailDomainIdx, v->VDiskIdx);
                 auto value = v->Metrics;
                 value.ClearVDiskId();
                 db.Table<Schema::VDiskMetrics>().Key(key).Update<Schema::VDiskMetrics::Metrics>(value);

diff --git a/ydb/core/mind/bscontroller/group_geometry_info.h b/ydb/core/mind/bscontroller/group_geometry_info.h
@@ -86,7 +86,7 @@ namespace NKikimr::NBsController {
                 i64 requiredSpace) const {
             TString error;
             for (const bool requireOperational : {true, false}) {
-                if (mapper.AllocateGroup(groupId, group, constrainsts, replacedDisks, forbid, requiredSpace, requireOperational, error)) {
+                if (mapper.AllocateGroup(groupId.GetRawId(), group, constrainsts, replacedDisks, forbid, requiredSpace, requireOperational, error)) {
                     return;
                 }
             }

diff --git a/ydb/core/mind/bscontroller/group_mapper.cpp b/ydb/core/mind/bscontroller/group_mapper.cpp
@@ -1152,7 +1152,7 @@ namespace NKikimr::NBsController {
         return Impl->FindMisplacedVDisks(group);
     }
 
-    std::optional<TPDiskId> TGroupMapper::TargetMisplacedVDisk(ui32 groupId, TGroupMapper::TGroupDefinition& group, 
+    std::optional<TPDiskId> TGroupMapper::TargetMisplacedVDisk(TGroupId groupId, TGroupMapper::TGroupDefinition& group, 
             TVDiskIdShort vdisk, TForbiddenPDisks forbid, i64 requiredSpace, bool requireOperational, TString& error) {
         return Impl->TargetMisplacedVDisk(groupId, group, vdisk, std::move(forbid), requiredSpace, requireOperational, error);
     }

diff --git a/ydb/core/mind/bscontroller/group_metrics_exchange.cpp b/ydb/core/mind/bscontroller/group_metrics_exchange.cpp
@@ -38,7 +38,7 @@ namespace NKikimr::NBsController {
                 for (const TGroupId groupId : record.GetGroupsToQuery()) {
                     if (TGroupInfo *group = Self->FindGroup(groupId)) {
                         auto *item = outRecord.AddGroupMetrics();
-                        item->SetGroupId(group->ID);
+                        item->SetGroupId(group->ID.GetRawId());
                         group->FillInGroupParameters(item->MutableGroupParameters());
                     }
                 }

diff --git a/ydb/core/mind/bscontroller/load_everything.cpp b/ydb/core/mind/bscontroller/load_everything.cpp
@@ -364,7 +364,7 @@ class TBlobStorageController::TTxLoadEverything : public TTransactionBase<TBlobS
                 Y_ABORT_UNLESS(pdisk);
 
                 const TGroupId groupId = slot.GetValue<T::GroupID>();
-                Y_ABORT_UNLESS(groupId);
+                Y_ABORT_UNLESS(groupId.GetRawId());
 
                 auto& x = Self->AddVSlot(vslotId, pdisk, groupId, slot.GetValueOrDefault<T::GroupPrevGeneration>(),
                     slot.GetValue<T::GroupGeneration>(), slot.GetValue<T::Category>(), slot.GetValue<T::RingIdx>(),

diff --git a/ydb/core/mind/bscontroller/migrate.cpp b/ydb/core/mind/bscontroller/migrate.cpp
@@ -65,7 +65,7 @@ class TBlobStorageController::TTxMigrate : public TTransactionBase<TBlobStorageC
                 return false;
             }
             while (!slots.EndOfSet()) {
-                if (!slots.GetValue<Table::GroupID>()) {
+                if (!slots.GetValue<Table::GroupID>().GetRawId()) {
                     // item scheduled for deletion
                     eraseList.push_back(slots.GetKey());
                 }

diff --git a/ydb/core/mind/bscontroller/monitoring.cpp b/ydb/core/mind/bscontroller/monitoring.cpp
@@ -323,7 +323,7 @@ class TBlobStorageController::TTxMonEvent_HealthEvents
 
     static NJson::TJsonValue ToJson(const TVDiskID& vdiskId) {
         NJson::TJsonValue j(NJson::JSON_MAP);
-        j["GroupId"] = vdiskId.GroupID;
+        j["GroupId"] = vdiskId.GroupID.GetRawId();
         j["GroupGeneration"] = vdiskId.GroupGeneration;
         j["FailRealmIdx"] = vdiskId.FailRealm;
         j["FailDomainIdx"] = vdiskId.FailDomain;
@@ -685,17 +685,17 @@ class TBlobStorageController::TTxMonEvent_GetDown : public TTransactionBase<TBlo
 
         auto reportGroup = [](const TGroupInfo& group) {
             NJson::TJsonValue item;
-            item["GroupId"] = group.ID;
+            item["GroupId"] = group.ID.GetRawId();
             item["Down"] = group.Down;
             item["PersistedDown"] = group.PersistedDown;
             return item;
         };
 
-        if (GroupId) {
+        if (GroupId.GetRawId()) {
             if (TGroupInfo* group = Self->FindGroup(GroupId)) {
                 json = reportGroup(*group);
             } else {
-                json["Error"] = Sprintf("GroupId# %" PRIu32 " not found", GroupId);
+                json["Error"] = Sprintf("GroupId# %" PRIu32 " not found", GroupId.GetRawId());
             }
         } else {
             for (const auto& kv : Self->GroupMap) {

diff --git a/ydb/core/mind/bscontroller/propose_group_key.cpp b/ydb/core/mind/bscontroller/propose_group_key.cpp
@@ -70,7 +70,7 @@ class TBlobStorageController::TTxProposeGroupKey : public TTransactionBase<TBlob
         group->EncryptedGroupKey = EncryptedGroupKey;
         group->GroupKeyNonce = GroupKeyNonce;
         group->MainKeyVersion = MainKeyVersion;
-        db.Table<Schema::Group>().Key(GroupId).Update(
+        db.Table<Schema::Group>().Key(GroupId.GetRawId()).Update(
             NIceDb::TUpdate<Schema::Group::LifeCyclePhase>(TBlobStorageGroupInfo::ELCP_IN_USE),
             NIceDb::TUpdate<Schema::Group::MainKeyId>(MainKeyId),
             NIceDb::TUpdate<Schema::Group::EncryptedGroupKey>(EncryptedGroupKey),

diff --git a/ydb/core/mind/bscontroller/register_node.cpp b/ydb/core/mind/bscontroller/register_node.cpp
@@ -269,7 +269,7 @@ class TBlobStorageController::TTxRegisterNode
         for (auto it = Self->VSlots.lower_bound(vslotId); it != Self->VSlots.end() && it->first.NodeId == nodeId; ++it) {
             Self->ReadVSlot(*it->second, Response.get());
             if (!it->second->IsBeingDeleted()) {
-                groupIDsToRead.insert(it->second->GroupId);
+                groupIDsToRead.insert(it->second->GroupId.GetRawId());
             }
         }
 
@@ -380,7 +380,7 @@ void TBlobStorageController::ReadGroups(TSet<ui32>& groupIDsToRead, bool discard
             NKikimrBlobStorage::TNodeWardenServiceSet *serviceSetProto = result->Record.MutableServiceSet();
             NKikimrBlobStorage::TGroupInfo *groupProto = serviceSetProto->AddGroups();
             if (!group) {
-                groupProto->SetGroupID(groupId);
+                groupProto->SetGroupID(groupId.GetRawId());
                 groupProto->SetEntityStatus(NKikimrBlobStorage::DESTROY);
             } else if (group->Listable()) {
                 const TStoragePoolInfo& info = StoragePools.at(group->StoragePoolId);

diff --git a/ydb/core/mind/bscontroller/request_controller_info.cpp b/ydb/core/mind/bscontroller/request_controller_info.cpp
@@ -26,7 +26,7 @@ class TBlobStorageController::TTxRequestControllerInfo : public TTransactionBase
 
         auto processGroup = [&](TGroupInfo *group) {
             auto *protoGroupInfo = responseRecord.AddBSGroupInfo();
-            protoGroupInfo->SetGroupId(group->ID);
+            protoGroupInfo->SetGroupId(group->ID.GetRawId());
             protoGroupInfo->SetErasureSpecies(group->ErasureSpecies);
             const TResourceRawValues& groupResources = group->GetResourceCurrentValues();
             protoGroupInfo->SetDataSize(groupResources.DataSize);

diff --git a/ydb/core/mind/bscontroller/scheme.h b/ydb/core/mind/bscontroller/scheme.h
@@ -121,7 +121,7 @@ struct Schema : NIceDb::Schema {
         struct PDiskID : Column<2, PDisk::PDiskID::ColumnType> {}; // PK + FK PDisk.PDiskID
         struct VSlotID : Column<3, NScheme::NTypeIds::Uint32> {}; // PK
         struct Category : Column<4, NScheme::NTypeIds::Uint64> { using Type = NKikimrBlobStorage::TVDiskKind::EVDiskKind; };
-        struct GroupID : Column<5, Group::ID::ColumnType> {using Type = TIdWrapper<ui32, TGroupIdTag>; }; // FK Group.ID
+        struct GroupID : Column<5, Group::ID::ColumnType> {using Type = TIdWrapper<ui32, TGroupIdTag>; static constexpr Type Default = TIdWrapper<ui32, TGroupIdTag>::Zero(); }; // FK Group.ID
         struct GroupGeneration : Column<6, Group::Generation::ColumnType> {};
         struct RingIdx : Column<7, NScheme::NTypeIds::Uint32> {};
         struct FailDomainIdx : Column<8, NScheme::NTypeIds::Uint32> {};

diff --git a/ydb/core/mind/bscontroller/select_groups.cpp b/ydb/core/mind/bscontroller/select_groups.cpp
@@ -52,7 +52,7 @@ class TBlobStorageController::TTxSelectGroups : public TTransactionBase<TBlobSto
                     if (!group->Down && (group->SeenOperational || !record.GetOnlySeenOperational())) {
                         auto *reportedGroup = pb->AddGroups();
                         reportedGroup->SetErasureSpecies(group->ErasureSpecies);
-                        reportedGroup->SetGroupID(group->ID);
+                        reportedGroup->SetGroupID(group->ID.GetRawId());
                         reportedGroup->SetStoragePoolName(Self->StoragePools.at(group->StoragePoolId).Name);
                         reportedGroup->SetPhysicalGroup(group->IsPhysicalGroup());
                         reportedGroup->SetDecommitted(group->IsDecommitted());

diff --git a/ydb/core/mind/bscontroller/update_group_latencies.cpp b/ydb/core/mind/bscontroller/update_group_latencies.cpp
@@ -25,9 +25,9 @@ class TBlobStorageController::TTxUpdateGroupLatencies : public TTransactionBase<
 
 #define UPDATE_CELL(VALUE, COLUMN) \
             if (const auto& x = stats.VALUE) { \
-                db.Table<Schema::GroupLatencies>().Key(groupId).Update(NIceDb::TUpdate<Schema::GroupLatencies::COLUMN>(x->MicroSeconds())); \
+                db.Table<Schema::GroupLatencies>().Key(groupId.GetRawId()).Update(NIceDb::TUpdate<Schema::GroupLatencies::COLUMN>(x->MicroSeconds())); \
             } else { \
-                db.Table<Schema::GroupLatencies>().Key(groupId).Update(NIceDb::TNull<Schema::GroupLatencies::COLUMN>()); \
+                db.Table<Schema::GroupLatencies>().Key(groupId.GetRawId()).Update(NIceDb::TNull<Schema::GroupLatencies::COLUMN>()); \
             }
 
             UPDATE_CELL(PutTabletLog, PutTabletLogLatencyUs);