Fix release repl token after poisson pill (#10069)

ydb-platform · Oct 4, 2024 · ce8c6eb · ce8c6eb
1 parent 82cbbe7
commit ce8c6eb
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/ydb/core/blobstorage/vdisk/balance/balancing_actor.cpp b/ydb/core/blobstorage/vdisk/balance/balancing_actor.cpp
@@ -82,6 +82,7 @@ namespace NBalancing {
         TBatchManager BatchManager;
 
         TInstant StartTime;
+        bool AquiredReplToken = false;
 
         ///////////////////////////////////////////////////////////////////////////////////////////
         //  Init logic
@@ -220,6 +221,8 @@ namespace NBalancing {
         }
 
         void ScheduleJobQuant() {
+            Y_DEBUG_ABORT_UNLESS(!AquiredReplToken);
+            AquiredReplToken = true;
             Ctx->MonGroup.ReplTokenAquired()++;
 
             // once repl token received, start balancing - waking up sender and deleter
@@ -240,13 +243,14 @@ namespace NBalancing {
 
             if (StartTime + Ctx->Cfg.EpochTimeout < TlsActivationContext->Now()) {
                 Ctx->MonGroup.EpochTimeouts()++;
-                Send(MakeBlobStorageReplBrokerID(), new TEvReleaseReplToken);
                 STLOG(PRI_INFO, BS_VDISK_BALANCING, BSVB04, VDISKP(Ctx->VCtx, "Epoch timeout"));
                 Stop(TDuration::Seconds(0));
                 return;
             }
 
             if (BatchManager.IsBatchCompleted()) {
+                Y_DEBUG_ABORT_UNLESS(AquiredReplToken);
+                AquiredReplToken = false;
                 Send(MakeBlobStorageReplBrokerID(), new TEvReleaseReplToken);
 
                 ContinueBalancing();
@@ -320,6 +324,10 @@ namespace NBalancing {
         void Stop(TDuration timeoutBeforeNextLaunch) {
             STLOG(PRI_INFO, BS_VDISK_BALANCING, BSVB12, VDISKP(Ctx->VCtx, "Stop balancing"), (SendOnMainParts, SendOnMainParts.Data.size()), (TryDeleteParts, TryDeleteParts.Data.size()), (SecondsBeforeNextLaunch, timeoutBeforeNextLaunch.Seconds()));
 
+            if (AquiredReplToken) {
+                Send(MakeBlobStorageReplBrokerID(), new TEvReleaseReplToken);
+            }
+
             Send(BatchManager.SenderId, new NActors::TEvents::TEvPoison);
             Send(BatchManager.DeleterId, new NActors::TEvents::TEvPoison);
             for (const auto& kv : *QueueActorMapPtr) {