Extract SetupBytesWrittenByUserAgentCounter method

ydb-platform · Oct 18, 2024 · ce116f5 · ce116f5
1 parent 0a731fc
commit ce116f5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/ydb/services/persqueue_v1/actors/write_session_actor.cpp b/ydb/services/persqueue_v1/actors/write_session_actor.cpp
@@ -492,6 +492,17 @@ void TWriteSessionActor<UseMigrationProtocol>::InitAfterDiscovery(const TActorCo
 
 }
 
+template<bool UseMigrationProtocol>
+void TWriteSessionActor<UseMigrationProtocol>::SetupBytesWrittenByUserAgentCounter() {
+    static constexpr auto protocol = UseMigrationProtocol ? "pqv1" : "topic";
+    BytesWrittenByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents")
+        ->GetSubgroup("host", "")
+        ->GetSubgroup("protocol", protocol)
+        ->GetSubgroup("topic", FullConverter->GetFederationPath())
+        ->GetSubgroup("user-agent", CleanupCounterValueString(UserAgent))
+        ->GetExpiringNamedCounter("sensor", "BytesWrittenByUserAgent", true);
+}
+
 template<bool UseMigrationProtocol>
 void TWriteSessionActor<UseMigrationProtocol>::SetupCounters()
 {
@@ -522,13 +533,7 @@ void TWriteSessionActor<UseMigrationProtocol>::SetupCounters()
     SessionsCreated.Inc();
     SessionsActive.Inc();
 
-    constexpr auto protocol = UseMigrationProtocol ? "pqv1" : "topic";
-    BytesWrittenByUserAgent = GetServiceCounters(Counters, "pqproxy|userAgents")
-        ->GetSubgroup("host", "")
-        ->GetSubgroup("protocol", protocol)
-        ->GetSubgroup("topic", FullConverter->GetFederationPath())
-        ->GetSubgroup("user-agent", CleanupCounterValueString(UserAgent))
-        ->GetExpiringNamedCounter("sensor", "BytesWrittenByUserAgent", true);
+    SetupBytesWrittenByUserAgentCounter();
 }
 
 template<bool UseMigrationProtocol>
@@ -548,6 +553,8 @@ void TWriteSessionActor<UseMigrationProtocol>::SetupCounters(const TString& clou
 
     SessionsCreated.Inc();
     SessionsActive.Inc();
+
+    SetupBytesWrittenByUserAgentCounter();
 }
 
 template<bool UseMigrationProtocol>

diff --git a/ydb/services/persqueue_v1/actors/write_session_actor.h b/ydb/services/persqueue_v1/actors/write_session_actor.h
@@ -161,6 +161,7 @@ class TWriteSessionActor
     void PrepareRequest(THolder<TEvWrite>&& ev, const TActorContext& ctx);
     void SendWriteRequest(typename TWriteRequestInfo::TPtr&& request, const TActorContext& ctx);
 
+    void SetupBytesWrittenByUserAgentCounter();
     void SetupCounters();
     void SetupCounters(const TString& cloudId, const TString& dbId, const TString& dbPath, const bool isServerless, const TString& folderId);