hotkeys crush on describe (#3462)

ydb-platform · Apr 4, 2024 · adb83de · adb83de
1 parent f4e1957
commit adb83de
Showing 1 changed file with 20 additions and 17 deletions.
diff --git a/ydb/core/viewer/json_hotkeys.h b/ydb/core/viewer/json_hotkeys.h
@@ -80,26 +80,29 @@ class TJsonHotkeys : public TViewerPipeClient<TJsonHotkeys> {
 
     void Handle(TEvSchemeShard::TEvDescribeSchemeResult::TPtr& ev) {
         DescribeResult = ev->Release();
-        const auto& pathDescription = DescribeResult->GetRecord().GetPathDescription();
-        const auto& partitions = pathDescription.GetTablePartitions();
-        const auto& metrics = pathDescription.GetTablePartitionMetrics();
-        TVector<std::pair<ui64, int>> tabletsOrder;
-
-        for (int i = 0; i < metrics.size(); ++i) {
-            tabletsOrder.emplace_back(metrics.Get(i).GetCPU(), i);
-        }
+        const auto& pbRecord(DescribeResult->GetRecord());
+        if (pbRecord.HasPathDescription()) {
+            const auto& pathDescription = pbRecord.GetPathDescription();
+            const auto& partitions = pathDescription.GetTablePartitions();
+            const auto& metrics = pathDescription.GetTablePartitionMetrics();
+            TVector<std::pair<ui64, int>> tabletsOrder;
+
+            for (int i = 0; i < metrics.size(); ++i) {
+                tabletsOrder.emplace_back(metrics.Get(i).GetCPU(), i);
+            }
 
-        Sort(tabletsOrder, std::greater<std::pair<ui64, int>>());
-        ui32 tablets = (ui32) std::max(1, (int) std::ceil(PollingFactor * tabletsOrder.size()));
+            Sort(tabletsOrder, std::greater<std::pair<ui64, int>>());
+            ui32 tablets = (ui32) std::max(1, (int) std::ceil(PollingFactor * tabletsOrder.size()));
 
-        for (ui32 i = 0; i < tablets; ++i) {
-            THolder<TEvDataShard::TEvGetDataHistogramRequest> request = MakeHolder<TEvDataShard::TEvGetDataHistogramRequest>();
-            if (EnableSampling) {
-                request->Record.SetCollectKeySampleMs(30000); // 30 sec
+            for (ui32 i = 0; i < tablets; ++i) {
+                THolder<TEvDataShard::TEvGetDataHistogramRequest> request = MakeHolder<TEvDataShard::TEvGetDataHistogramRequest>();
+                if (EnableSampling) {
+                    request->Record.SetCollectKeySampleMs(30000); // 30 sec
+                }
+                request->Record.SetActualData(true);
+                ui64 datashardId = partitions.Get(tabletsOrder[i].second).GetDatashardId();
+                SendRequestToPipe(ConnectTabletPipe(datashardId), request.Release());
             }
-            request->Record.SetActualData(true);
-            ui64 datashardId = partitions.Get(tabletsOrder[i].second).GetDatashardId();
-            SendRequestToPipe(ConnectTabletPipe(datashardId), request.Release());
         }
 
         RequestDone();