fix

ydb-platform · Jan 10, 2024 · a882c95 · a882c95
1 parent 5831cb3
commit a882c95
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/ydb/core/kqp/opt/physical/effects/kqp_opt_phy_indexes.cpp b/ydb/core/kqp/opt/physical/effects/kqp_opt_phy_indexes.cpp
@@ -138,6 +138,8 @@ TMaybeNode<TDqPhyPrecompute> PrecomputeTableLookupDict(const TDqPhyPrecompute& l
 
     TExprNode::TPtr keys;
 
+    // we need to left only table key columns to perform lookup
+    // unfortunately we can't do it inside lookup stage
     if (fixLookupKeys) {
         auto keyArg = TCoArgument(ctx.NewArgument(pos, "key"));
         auto keysList = TCoArgument(ctx.NewArgument(pos, "keys_list"));

diff --git a/ydb/core/kqp/opt/physical/effects/kqp_opt_phy_upsert_index.cpp b/ydb/core/kqp/opt/physical/effects/kqp_opt_phy_upsert_index.cpp
@@ -351,13 +351,12 @@ TMaybe<TCondenseInputResult> CheckUniqueConstraint(const TExprBase& inputRows, c
     for (const auto& [_, indexDesc] : indexes) {
         hasUniqIndex |= (indexDesc->Type == TIndexDescription::EType::GlobalSyncUnique);
         for (const auto& indexKeyCol : indexDesc->KeyColumns) {
-            if (inputColumns.contains(indexKeyCol)) {
-                if (!usedIndexes.contains(indexDesc->Name) &&
-                    std::find(mainPk.begin(), mainPk.end(), indexKeyCol) == mainPk.end())
-                {
-                    usedIndexes.insert(indexDesc->Name);
-                }
+            if (inputColumns.contains(indexKeyCol)
+                && std::find(mainPk.begin(), mainPk.end(), indexKeyCol) == mainPk.end())
+            {
+                usedIndexes.insert(indexDesc->Name);
             } else {
+                // input always contains key columns
                 YQL_ENSURE(std::find(mainPk.begin(), mainPk.end(), indexKeyCol) == mainPk.end());
                 missedKeyInput.emplace(indexKeyCol);
             }