[dq] Separate setting SplitStageOnDqReplicate (YQL-17382) (#664)

ydb-platform · Dec 22, 2023 · 8fbea85 · 8fbea85
1 parent 55c5812
commit 8fbea85
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/ydb/library/yql/cfg/tests/gateways.conf b/ydb/library/yql/cfg/tests/gateways.conf
@@ -188,6 +188,11 @@ Dq {
         Name: "UseWideChannels"
         Value: "true"
     }
+
+    DefaultSettings {
+        Name: "SplitStageOnDqReplicate"
+        Value: "true"
+    }
 }
 
 Fs {

diff --git a/ydb/library/yql/providers/dq/common/yql_dq_settings.cpp b/ydb/library/yql/providers/dq/common/yql_dq_settings.cpp
@@ -83,10 +83,18 @@ TDqConfiguration::TDqConfiguration() {
         .ValueSetter([this](const TString&, TDqSettings::ESpillingEngine value) {
             SpillingEngine = value;
             if (value != TDqSettings::ESpillingEngine::Disable) {
+                SplitStageOnDqReplicate = false;
                 EnableDqReplicate = true;
             }
         });
     REGISTER_SETTING(*this, DisableLLVMForBlockStages);
+    REGISTER_SETTING(*this, SplitStageOnDqReplicate)
+        .ValueSetter([this](const TString&, bool value) {
+            SplitStageOnDqReplicate = value;
+            if (!value) {
+                EnableDqReplicate = true;
+            }
+        });
 }
 
 } // namespace NYql
diff --git a/ydb/library/yql/providers/dq/common/yql_dq_settings.h b/ydb/library/yql/providers/dq/common/yql_dq_settings.h
@@ -127,6 +127,7 @@ struct TDqSettings {
     NCommon::TConfSetting<bool, false> UseBlockReader;
     NCommon::TConfSetting<ESpillingEngine, false> SpillingEngine;
     NCommon::TConfSetting<bool, false> DisableLLVMForBlockStages;
+    NCommon::TConfSetting<bool, false> SplitStageOnDqReplicate;
 
     // This options will be passed to executor_actor and worker_actor
     template <typename TProtoConfig>

diff --git a/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp b/ydb/library/yql/providers/dq/provider/exec/yql_dq_exectransformer.cpp
@@ -266,7 +266,7 @@ struct TDqsPipelineConfigurator : public IPipelineConfigurator {
         }
         pipeline->Add(
             NDq::CreateDqBuildPhyStagesTransformer(
-                State_->Settings->SpillingEngine.Get().GetOrElse(TDqSettings::TDefault::SpillingEngine) != TDqSettings::ESpillingEngine::Disable,
+                !State_->Settings->SplitStageOnDqReplicate.Get().GetOrElse(true),
                 *pipeline->GetTypeAnnotationContext(), mode
             ),
             "BuildPhy");