Skip to content

Commit

Permalink
add dummy statistics request and response
Browse files Browse the repository at this point in the history
  • Loading branch information
ildar-khisambeev committed Jun 26, 2024
1 parent 79d328b commit 6786b7d
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ydb/core/protos/statistics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ message TEvGetScanStatusResponse {
message TEvStatisticsScanRequest {
optional NKikimrDataEvents.TTableId TableId = 1;
optional bytes StartKey = 2;
// list of columns to gather statistics from. Empty means asking for every column.
repeated uint32 ColumnTags = 3;
// list of statistics types requested. Empty means asking for all available.
repeated uint32 Types = 4;
}

message TEvStatisticsScanResponse {
Expand Down
18 changes: 18 additions & 0 deletions ydb/core/tx/columnshard/columnshard.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include <ydb/core/tx/tx.h>
#include <ydb/core/tx/message_seqno.h>
#include <ydb/core/protos/statistics.pb.h>
#include <ydb/core/protos/tx_columnshard.pb.h>
#include <ydb/public/api/protos/ydb_status_codes.pb.h>
#include <ydb/core/tx/data_events/write_data.h>
Expand Down Expand Up @@ -83,6 +84,9 @@ struct TEvColumnShard {
EvApplyLinksModification,
EvApplyLinksModificationFinished,

EvStatisticsScanRequest,
EvStatisticsScanResponse,

EvEnd
};

Expand Down Expand Up @@ -253,6 +257,20 @@ struct TEvColumnShard {
}
};

struct TEvStatisticsScanRequest
: public TEventPB<TEvStatisticsScanRequest,
NKikimrStat::TEvStatisticsScanRequest,
EvStatisticsScanRequest>
{
};

struct TEvStatisticsScanResponse
: public TEventPB<TEvStatisticsScanResponse,
NKikimrStat::TEvStatisticsScanResponse,
EvStatisticsScanResponse>
{
};

using TEvScan = TEvDataShard::TEvKqpScan;

};
Expand Down
18 changes: 18 additions & 0 deletions ydb/core/tx/columnshard/columnshard__statistics_scan.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#include "columnshard.h"
#include "columnshard_impl.h"

#include <ydb/core/protos/kqp.pb.h>

namespace NKikimr::NColumnShard {

void TColumnShard::Handle(TEvColumnShard::TEvStatisticsScanRequest::TPtr& ev, const TActorContext& ctx) {
auto response = std::make_unique<TEvDataShard::TEvStatisticsScanResponse>();
auto& record = response->Record;
record.SetShardTabletId(TabletID());

record.SetStatus(NKikimrStat::TEvStatisticsScanResponse::SUCCESS);

ctx.Send(new IEventHandle(ev->Sender, TActorId(), response.release(), 0, ev->Cookie));
}

}
4 changes: 4 additions & 0 deletions ydb/core/tx/columnshard/columnshard_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ class TColumnShard
void Handle(TEvPrivate::TEvTieringModified::TPtr& ev, const TActorContext&);
void Handle(TEvPrivate::TEvNormalizerResult::TPtr& ev, const TActorContext&);

void Handle(TEvColumnShard::TEvStatisticsScanRequest::TPtr& ev, const TActorContext& ctx);

void Handle(NActors::TEvents::TEvUndelivered::TPtr& ev, const TActorContext&);

void Handle(NOlap::NBlobOperations::NEvents::TEvDeleteSharedBlobs::TPtr& ev, const TActorContext& ctx);
Expand Down Expand Up @@ -373,6 +375,8 @@ class TColumnShard
HFunc(TEvPrivate::TEvGarbageCollectionFinished, Handle);
HFunc(TEvPrivate::TEvTieringModified, Handle);

HFunc(TEvColumnShard::TEvStatisticsScanRequest, Handle);

HFunc(NActors::TEvents::TEvUndelivered, Handle);

HFunc(NOlap::NBlobOperations::NEvents::TEvDeleteSharedBlobs, Handle);
Expand Down
1 change: 1 addition & 0 deletions ydb/core/tx/columnshard/ya.make
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ SRCS(
columnshard__propose_cancel.cpp
columnshard__propose_transaction.cpp
columnshard__scan.cpp
columnshard__statistics_scan.cpp
columnshard__write.cpp
columnshard__write_index.cpp
columnshard.cpp
Expand Down

0 comments on commit 6786b7d

Please sign in to comment.