move growing into separate function and remove testing stuff

ydb-platform · Oct 28, 2024 · 2ef04c8 · 2ef04c8
1 parent e5d9b3d
commit 2ef04c8
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
@@ -274,15 +274,21 @@ class TState : public TComputationValue<TState> {
             Tongue = CurrentPage->data() + CurrentPosition;
         }
         Throat = States.GetKey(itInsert) + KeyWidth;
-        if (isNew && !IsOutOfMemory) {
+        if (isNew) {
+            SafeGrow();
+        }
+        return isNew;
+    }
+
+    void SafeGrow() {
+        if (!IsOutOfMemory) {
             try {
                 States.CheckGrow();
             } catch (const TMemoryLimitExceededException& e) {
                 Cerr << "State " << (void *)this << " no longer growing\n";
                 IsOutOfMemory = true;
             }
         }
-        return isNew;
     }
 
     bool CheckIsOutOfMemory() const {
@@ -848,7 +854,6 @@ class TSpillingSupportState : public TComputationValue<TSpillingSupportState> {
     }
 
     bool IsSwitchToSpillingModeCondition() const {
-        return false;
         return !HasMemoryForProcessing() || TlsAllocState->GetMaximumLimitValueReached();
     }