Skip to content

Commit

Permalink
Removed obsolete controls
Browse files Browse the repository at this point in the history
  • Loading branch information
domwst committed Feb 5, 2024
1 parent e069320 commit 2e5baa2
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 257 deletions.
62 changes: 0 additions & 62 deletions ydb/core/control/common_controls/tracing_control.cpp

This file was deleted.

33 changes: 0 additions & 33 deletions ydb/core/control/common_controls/tracing_control.h

This file was deleted.

13 changes: 0 additions & 13 deletions ydb/core/control/common_controls/ya.make

This file was deleted.

25 changes: 0 additions & 25 deletions ydb/core/control/immediate_control_board_sampler.h

This file was deleted.

66 changes: 0 additions & 66 deletions ydb/core/control/immediate_control_board_throttler.h

This file was deleted.

6 changes: 0 additions & 6 deletions ydb/core/control/ya.make
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,10 @@ SRCS(
immediate_control_board_impl.cpp
immediate_control_board_impl.h
immediate_control_board_wrapper.h
immediate_control_board_throttler.h
immediate_control_board_sampler.h
)

END()

RECURSE(
common_controls
)

RECURSE_FOR_TESTS(
ut
)
1 change: 0 additions & 1 deletion ydb/core/grpc_services/grpc_request_proxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#include <ydb/core/base/nameservice.h>
#include <ydb/core/cms/console/configs_dispatcher.h>
#include <ydb/core/cms/console/console.h>
#include <ydb/core/control/common_controls/tracing_control.h>
#include <ydb/core/grpc_services/counters/proxy_counters.h>
#include <ydb/core/jaeger_tracing/sampling_throttling_control.h>
#include <ydb/core/tx/tx_proxy/proxy.h>
Expand Down
1 change: 0 additions & 1 deletion ydb/core/keyvalue/ya.make
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ PEERDIR(
ydb/library/actors/protos
ydb/core/base
ydb/core/blobstorage/base
ydb/core/control/common_controls
ydb/core/engine/minikql
ydb/core/keyvalue/protos
ydb/core/protos
Expand Down
50 changes: 0 additions & 50 deletions ydb/core/protos/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1245,61 +1245,11 @@ message TImmediateControlsConfig {
DefaultValue: 8388608 }];
}

message TTracingControls {
message TSamplingThrottlingOptions {
message TThrottlingOptions {
optional uint64 MaxRatePerMinute = 1 [(ControlOptions) = {
Description: "Maximum amount of traced requests per minute",
MinValue: 0,
MaxValue: 300,
DefaultValue: 0,
}];
optional uint64 MaxBurst = 2 [(ControlOptions) = {
Description: "Maximum burst of traced events",
MinValue: 0,
MaxValue: 300,
DefaultValue: 0,
}];
}

message TSamplingOptions {
optional uint64 PPM = 1 [(ControlOptions) = {
Description: "Average amount of sampled requests per one million",
MinValue: 0,
MaxValue: 1000000,
DefaultValue: 0,
}];
optional uint64 Level = 2 [(ControlOptions) = {
Description: "Tracing level of sampled requests",
MinValue: 1,
MaxValue: 15,
DefaultValue: 15,
}];
}

optional TSamplingOptions Sampling = 1;
optional TThrottlingOptions SampledThrottling = 2;
optional TThrottlingOptions ExternalThrottling = 3;
}

message TKeyValue {
optional TSamplingThrottlingOptions AcquireLock = 1;
optional TSamplingThrottlingOptions ExecuteTransaction = 2;
optional TSamplingThrottlingOptions Read = 3;
optional TSamplingThrottlingOptions ReadRange = 4;
optional TSamplingThrottlingOptions ListRange = 5;
optional TSamplingThrottlingOptions GetStorageChannelStatus = 6;
}

optional TKeyValue KeyValue = 1;
}

optional TDataShardControls DataShardControls = 1;
optional TTxLimitControls TxLimitControls = 2;
optional TCoordinatorControls CoordinatorControls = 3;
optional TSchemeShardControls SchemeShardControls = 4;
optional TTCMallocControls TCMallocControls = 5;
optional TTracingControls TracingControls = 6;
};

message TMeteringConfig {
Expand Down

0 comments on commit 2e5baa2

Please sign in to comment.