Added database to request discriminator (#2221)

ydb-platform · Feb 26, 2024 · 23b3575 · 23b3575
1 parent bae9923
commit 23b3575
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 10 deletions.
diff --git a/ydb/core/grpc_services/base/base.h b/ydb/core/grpc_services/base/base.h
@@ -344,7 +344,7 @@ struct TRequestAuxSettings {
     TRateLimiterMode RlMode = TRateLimiterMode::Off;
     void (*CustomAttributeProcessor)(const TSchemeBoardEvents::TDescribeSchemeResult& schemeData, ICheckerIface*) = nullptr;
     TAuditMode AuditMode = TAuditMode::Off;
-    NJaegerTracing::TRequestDiscriminator RequestDiscriminator = NJaegerTracing::TRequestDiscriminator::EMPTY;
+    NJaegerTracing::ERequestType RequestType = NJaegerTracing::ERequestType::UNSPECIFIED;
 };
 
 class TGRpcRequestProxySimple;
@@ -378,7 +378,7 @@ class IRequestProxyCtx
     virtual void LegacyFinishSpan() = 0;
 
     // Used for per-type sampling
-    virtual const NJaegerTracing::TRequestDiscriminator& GetRequestDiscriminator() const {
+    virtual NJaegerTracing::TRequestDiscriminator GetRequestDiscriminator() const {
         return NJaegerTracing::TRequestDiscriminator::EMPTY;
     };
 
@@ -1403,7 +1403,7 @@ class TGrpcRequestCall
     using TRequestIface = typename std::conditional<IsOperation, IRequestOpCtx, IRequestNoOpCtx>::type;
 
 public:
-    static IActor* CreateRpcActor(typename std::conditional<IsOperation, IRequestOpCtx, IRequestNoOpCtx>::type* msg);
+    static IActor* CreateRpcActor(TRequestIface* msg);
     static constexpr bool IsOp = IsOperation;
 
     using TBase = std::conditional_t<TProtoHasValidate<TReq>::Value,
@@ -1445,8 +1445,11 @@ class TGrpcRequestCall
         }
     }
 
-    const NJaegerTracing::TRequestDiscriminator& GetRequestDiscriminator() const override {
-        return AuxSettings.RequestDiscriminator;
+    NJaegerTracing::TRequestDiscriminator GetRequestDiscriminator() const override {
+        return {
+            .RequestType = AuxSettings.RequestType,
+            .Database = TBase::GetDatabaseName(),
+        };
     }
 
     // IRequestCtxBaseMtSafe

diff --git a/ydb/core/jaeger_tracing/request_discriminator.cpp b/ydb/core/jaeger_tracing/request_discriminator.cpp
@@ -4,6 +4,7 @@ namespace NKikimr::NJaegerTracing {
 
 const TRequestDiscriminator TRequestDiscriminator::EMPTY {
     .RequestType = ERequestType::UNSPECIFIED,
+    .Database = NothingObject,
 };
 
 } // namespace NKikimr::NJaegerTracing
diff --git a/ydb/core/jaeger_tracing/request_discriminator.h b/ydb/core/jaeger_tracing/request_discriminator.h
@@ -3,7 +3,9 @@
 #include <cstddef>
 
 #include <util/generic/hash.h>
+#include <util/generic/maybe.h>
 #include <util/generic/strbuf.h>
+#include <util/generic/string.h>
 
 namespace NKikimr::NJaegerTracing {
 
@@ -33,6 +35,7 @@ static const THashMap<TStringBuf, ERequestType> NameToRequestType = {
 
 struct TRequestDiscriminator {
     ERequestType RequestType = ERequestType::UNSPECIFIED;
+    TMaybe<TString> Database = NothingObject;
 
     static const TRequestDiscriminator EMPTY;
 };

diff --git a/ydb/services/keyvalue/grpc_service.cpp b/ydb/services/keyvalue/grpc_service.cpp
@@ -57,9 +57,7 @@ void TKeyValueGRpcService::SetupIncomingRequests(NYdbGrpc::TLoggerPtr logger) {
                 Ydb::KeyValue::Y_CAT(methodName, Response)>(reqCtx, &method,                        \
                     TRequestAuxSettings {                                                           \
                         .RlMode = rlMode,                                                           \
-                        .RequestDiscriminator = {                                                   \
-                            .RequestType = NJaegerTracing::ERequestType::requestType,               \
-                        },                                                                          \
+                        .RequestType = NJaegerTracing::ERequestType::requestType,                   \
                     }));                                                  \
         },                                                                                                   \
         &Ydb::KeyValue::V1::KeyValueService::AsyncService::Y_CAT(Request, methodName),       \

diff --git a/ydb/services/local_discovery/grpc_func_call.h b/ydb/services/local_discovery/grpc_func_call.h
@@ -50,8 +50,11 @@ class TGrpcRequestFunctionCall
         }
     }
 
-    const NJaegerTracing::TRequestDiscriminator& GetRequestDiscriminator() const override {
-        return AuxSettings.RequestDiscriminator;
+    NJaegerTracing::TRequestDiscriminator GetRequestDiscriminator() const override {
+        return {
+            .RequestType = AuxSettings.RequestType,
+            .Database = TBase::GetDatabaseName(),
+        };
     }
 
 private: