Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: missing error handler for arg --auth-token-file #283

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Jan 24, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #280

What is the new behavior?

  • remove code with CheckSecretKey for StatefulSet resource builder
  • use secret with name and key ydb-auth-token-file by default
  • annotations ydb.tech/auth-token-secret-name and ydb.tech/auth-token-secret-key to override defaults

Other information

BinariesDir = "/opt/ydb/bin"
DaemonBinaryName = "ydbd"

AdditionalSecretsDir = "/opt/ydb/secrets"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two vars (and maybe more) seems to be defined as wellKnownDirForAdditionalSecrets as well:

wellKnownDirForAdditionalSecrets = "/opt/ydb/secrets"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It remains here for compatibility. One of the next changes will be switch to use this const from package api/v1alpha

@kobzonega kobzonega merged commit 6f07d13 into ydb-platform:master Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants