Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YDBOPS-9635 use configMap from Storage if Database .spec.configuration empty #199

Merged
merged 4 commits into from
May 13, 2024

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented May 7, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Scenario:

  • I am a ydb user
  • created Storage object with config
  • created Database object without config

Then I need to include some kind of thing in ydb configuration:

  • I'm editing the configuration in Storage object
  • After I'll restart all Storage and all Databases

Result:
I get new configuration for Storage
But on in the Database it did not turn

Issue Number: YDBOPS-9635

What is the new behavior?

  • Check field .spec.configuration in Database object:
    • if config is not defined (spec.configuration == "") and encryption is not enabled (.spec.encryption == nil) then reuse Storage ConfigMap for StatefulSet. That will help to simple and clearly update configuration for YDB cluster.
    • else create/update separate ConfigMap with Database specific configuration

Other information

TODO: avoid using Database field .spec.configuration and use dynconfig instead (YDBOPS-9608)

@kobzonega kobzonega changed the title use configMap from Storage if Database .spec.configuration empty YDBOPS-9635 use configMap from Storage if Database .spec.configuration empty May 8, 2024
@kobzonega kobzonega self-assigned this May 8, 2024
@kobzonega kobzonega requested review from bma13 and artgromov May 8, 2024 10:21
@artgromov artgromov added the ok-to-test Testing pipelines will run label May 13, 2024
@github-actions github-actions bot removed the ok-to-test Testing pipelines will run label May 13, 2024
@kobzonega kobzonega merged commit 86982f3 into master May 13, 2024
12 of 14 checks passed
@kobzonega kobzonega deleted the YDBOPS-9635 branch May 13, 2024 14:16
kobzonega added a commit that referenced this pull request May 13, 2024
kobzonega added a commit that referenced this pull request May 13, 2024
kobzonega added a commit that referenced this pull request May 13, 2024
kobzonega added a commit to kobzonega/ydb-kubernetes-operator that referenced this pull request Jun 25, 2024
kobzonega added a commit to kobzonega/ydb-kubernetes-operator that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants